From nobody Sat Apr 5 15:07:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1738315461; cv=none; d=zohomail.com; s=zohoarc; b=S/G7GZbMMTuQe/uO/5PBmC6U7F2z+TYCIO6jRIySwUzvckYunBB9mOvdw+hB1tG+zvuiuBy/GBPjxmA4MFOH89bBVWdeIOYyLQeqXnP1xmIu6Xvq9JYYXE5skbCkCZ7y5qcsERw+Y54IJcGjAfagSk3xXeA+jWvrfSLX7YI0g/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738315461; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7eLCz9UPuLTx8f1bvgFBOlyPJnGpHcdVMxVwgsUJJ5I=; b=EIC6VQOD/UKzQlSsOSYktnt41CJq/NJC2KH6+wtsoxoq88z6bi+Fl0nsLN4OvIumk/7y3fYVfrvM0gsEQgarACuEajlx0jmHLF9gIQbP5TBpKjiGz4fIOmewxvwDV0LN+SJIS4ojr7itIHcgMz0dWJpvNB43b8iujt2Jnl4NElg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1738315461174946.1090406467872; Fri, 31 Jan 2025 01:24:21 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tdnEa-0008HN-Mm; Fri, 31 Jan 2025 04:22:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdnEZ-0008Gy-Fx for qemu-devel@nongnu.org; Fri, 31 Jan 2025 04:22:43 -0500 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdnEX-0004Du-QE for qemu-devel@nongnu.org; Fri, 31 Jan 2025 04:22:43 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EFB495C5D60; Fri, 31 Jan 2025 09:22:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F7CBC4CEE1; Fri, 31 Jan 2025 09:22:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738315360; bh=EdUmbIHS6wsR+QKUpjXCHpozaxkbBLR0Vx1ZIKvUOQA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HOvOXkecpRaa47P+RjpFqXS8ZIVrDDqxSjx2HXoTdNMONKgpep0PK+w2rOMuj3tno 5hEX2OJ7fc1qyhSaX3KQBcWcf9TeMSqk+BV+slHHWlxLpnNx+ClLgzKbSamTZubDUD P/3i8Snkajpusr8kBH5nkaxouROxAElJIf9YnKt7EkkEjtkJ4joRY0ZunSesQP91Nh 0BJVNLOxlReKkj8LfpoqlppxAqaqwr1P6p0fdWhQ16Br2vcNv3naxSFj0O8JfrwN0C izjq63rfadUR03EntwMCC+Dz0aqw/zjVRARL5fk98c/8lXzOy5hgci1MwM/Aoo0lxw DmUVMErKnZcXA== From: deller@kernel.org To: Richard Henderson , Stefan Hajnoczi , qemu-devel@nongnu.org, Peter Maydell Cc: deller@gmx.de Subject: [PULL v2 5/9] target/hppa: Drop diag_getshadowregs_pa2 and diag_putshadowregs_pa2 Date: Fri, 31 Jan 2025 10:22:25 +0100 Message-ID: <20250131092229.38232-6-deller@kernel.org> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250131092229.38232-1-deller@kernel.org> References: <20250131092229.38232-1-deller@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2604:1380:4641:c500::1; envelope-from=deller@kernel.org; helo=dfw.source.kernel.org X-Spam_score_int: -56 X-Spam_score: -5.7 X-Spam_bar: ----- X-Spam_report: (-5.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.3, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @kernel.org) X-ZM-MESSAGEID: 1738315462567019000 Content-Type: text/plain; charset="utf-8" From: Helge Deller diag_getshadowregs_pa2() and diag_putshadowregs_pa2() were added in commit 3bdf20819e68 based on some analysis of ODE code, but now they conflict with the generic mfdiag/mtdiag instructions. I believe the former analysis was wrong, so remove them again. Note that all diag instructions are badly documented, so most things are based on reverse engineering and thus may be wrong. Signed-off-by: Helge Deller Fixes: 3bdf20819e68 ("target/hppa: Add diag instructions to set/restore sha= dow registers") Reviewed-by: Richard Henderson --- target/hppa/insns.decode | 2 -- target/hppa/translate.c | 10 ---------- 2 files changed, 12 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 71074a64c1..527c453443 100644 --- a/target/hppa/insns.decode +++ b/target/hppa/insns.decode @@ -646,8 +646,6 @@ xmpyu 001110 ..... ..... 010 .0111 .00 t:5 = r1=3D%ra64 r2=3D%rb64 diag_putshadowregs_pa1 000101 00 0000 0000 0001 1010 0100 0000 =20 # For 64-bit PA8700 (PCX-W2) - diag_getshadowregs_pa2 000101 00 0111 1000 0001 1000 0100 0000 - diag_putshadowregs_pa2 000101 00 0111 0000 0001 1000 0100 0000 ] diag_unimp 000101 i:26 } diff --git a/target/hppa/translate.c b/target/hppa/translate.c index dc04f9f3c0..30fba5297a 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -4593,21 +4593,11 @@ static bool trans_diag_getshadowregs_pa1(DisasConte= xt *ctx, arg_empty *a) return !ctx->is_pa20 && do_getshadowregs(ctx); } =20 -static bool trans_diag_getshadowregs_pa2(DisasContext *ctx, arg_empty *a) -{ - return ctx->is_pa20 && do_getshadowregs(ctx); -} - static bool trans_diag_putshadowregs_pa1(DisasContext *ctx, arg_empty *a) { return !ctx->is_pa20 && do_putshadowregs(ctx); } =20 -static bool trans_diag_putshadowregs_pa2(DisasContext *ctx, arg_empty *a) -{ - return ctx->is_pa20 && do_putshadowregs(ctx); -} - static bool trans_diag_unimp(DisasContext *ctx, arg_diag_unimp *a) { CHECK_MOST_PRIVILEGED(EXCP_PRIV_OPR); --=20 2.47.0