From nobody Thu Apr 10 09:41:11 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=@intel.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=intel.com
ARC-Seal: i=1; a=rsa-sha256; t=1737726042; cv=none;
d=zohomail.com; s=zohoarc;
b=BnetT6WBc9gKy4NPVvwRknk2cLrqhbK7scMiCQmQzqukyhKBk4WqBGxLeXDoKxoV3JPJIUMr+G5L1R2mBRYEtqKqPxxQBZV2ViMUcFYzqT8/tCwxBHP8tiFhZA1/JwRU2T2F4P36LWsLh00vd78c3ssTi7jMrO/S+3sYnNd6Nh8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1737726042;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=+se/KJV+vUhgj/F9cb9qKwtG23bld92yjRdi9ZJcr10=;
b=EE1P8D0zfC1GCYpRtzf8D3kQLvIiFe0nM4lZ5N/fkh+3Uixs7//huj1Ke4EGl4Wn+eoZ3+TbHqFrDPzhMX+T7pnIO/GCCYRnQVBQIgZiO8+ylHiJW9KxqTZ3K6etNd1Q/Cbfi9UvYWMVw6867TgoYz7B27Df1t1fe2RxePzFFNM=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=@intel.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<xiaoyao.li@intel.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1737726042308402.73090958910734;
Fri, 24 Jan 2025 05:40:42 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tbJvJ-0002Gx-F9; Fri, 24 Jan 2025 08:40:37 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <xiaoyao.li@intel.com>)
id 1tbJuV-0000V5-7V
for qemu-devel@nongnu.org; Fri, 24 Jan 2025 08:39:47 -0500
Received: from mgamail.intel.com ([198.175.65.13])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <xiaoyao.li@intel.com>)
id 1tbJuT-00042W-E8
for qemu-devel@nongnu.org; Fri, 24 Jan 2025 08:39:46 -0500
Received: from fmviesa003.fm.intel.com ([10.60.135.143])
by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
24 Jan 2025 05:39:26 -0800
Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52])
by fmviesa003.fm.intel.com with ESMTP; 24 Jan 2025 05:39:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1737725986; x=1769261986;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=Td2pdCuaEFQpSTTH/BdQkkMIQipWLW2UwdU/17m7eU4=;
b=UP6Phf08TNm4i7xTZGRxzVb4Xrd5oDHMeovJLc4MfLfTGRS6B6CnWc6l
7TQNhRI4mfROiNxOqAuDRhxN6iNWpy7T2t7F5GbQJAnvT1S9miBIHyoVT
2o3umQ3BVlIQemaIWCj+zAv+ZqLzE6rofcIX2abrCKvmSfLNpaF+IkF7P
L03wkX9p5n+yvcAgpywa8u1pI7Y8KaJawxao9l2+IuN1BOkWP7LA5ha5D
wEtCvSSUDB17+Qs1HTKX7r4dGBi6+hVWNOko5ASGleE61edXTpyrJMtdG
lobh3bZ+5bcBf7NRehFWLmXdUj/N5d/XcJar6OlUh1HMKvxaFI4t3im3P g==;
X-CSE-ConnectionGUID: Y2wecuYnSjWy+RudaZo1DA==
X-CSE-MsgGUID: J43Pba9WQemgLfA8JTTt9g==
X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="49246531"
X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="49246531"
X-CSE-ConnectionGUID: XGn4NuL3ROK2pqBS1b63dw==
X-CSE-MsgGUID: W1io1APpQqeNn+HtZxbpRg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="111804428"
From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Igor Mammedov <imammedo@redhat.com>
Cc: Zhao Liu <zhao1.liu@intel.com>, "Michael S. Tsirkin" <mst@redhat.com>,
Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>, Huacai Chen <chenhuacai@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Francesco Lavra <francescolavra.fl@gmail.com>, xiaoyao.li@intel.com,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [PATCH v7 38/52] i386/apic: Skip kvm_apic_put() for TDX
Date: Fri, 24 Jan 2025 08:20:34 -0500
Message-Id: <20250124132048.3229049-39-xiaoyao.li@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20250124132048.3229049-1-xiaoyao.li@intel.com>
References: <20250124132048.3229049-1-xiaoyao.li@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=198.175.65.13;
envelope-from=xiaoyao.li@intel.com;
helo=mgamail.intel.com
X-Spam_score_int: -63
X-Spam_score: -6.4
X-Spam_bar: ------
X-Spam_report: (-6.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.998, RCVD_IN_DNSWL_MED=-2.3,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @intel.com)
X-ZM-MESSAGEID: 1737726044322019100
Content-Type: text/plain; charset="utf-8"
KVM neithers allow writing to MSR_IA32_APICBASE for TDs, nor allow for
KVM_SET_LAPIC[*].
Note, KVM_GET_LAPIC is also disallowed for TDX. It is called in the path
do_kvm_cpu_synchronize_state()
-> kvm_arch_get_registers()
-> kvm_get_apic()
and it's already disllowed for confidential guest through
guest_state_protected.
[*] https://lore.kernel.org/all/Z3w4Ku4Jq0CrtXne@google.com/
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
hw/i386/kvm/apic.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
index 757510600098..a1850524a67f 100644
--- a/hw/i386/kvm/apic.c
+++ b/hw/i386/kvm/apic.c
@@ -17,6 +17,7 @@
#include "system/hw_accel.h"
#include "system/kvm.h"
#include "kvm/kvm_i386.h"
+#include "kvm/tdx.h"
=20
static inline void kvm_apic_set_reg(struct kvm_lapic_state *kapic,
int reg_id, uint32_t val)
@@ -141,6 +142,10 @@ static void kvm_apic_put(CPUState *cs, run_on_cpu_data=
data)
struct kvm_lapic_state kapic;
int ret;
=20
+ if(is_tdx_vm()) {
+ return;
+ }
+
kvm_put_apicbase(s->cpu, s->apicbase);
kvm_put_apic_state(s, &kapic);
=20
--=20
2.34.1