From nobody Sat Apr 5 18:03:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1737726056; cv=none; d=zohomail.com; s=zohoarc; b=U+K1WMLDlpb5xUkEFabyeDYyjri6liX3d/Asjt5OqRBaKff9tcp2CJHtEiLnvE6r5VvM7ZDnUyGVsfaXGscBQoFBuDF6s6nc/SOqLLoTBcGn8j8Y/9weOTeleANys8oPsvD6Bsg2pJzHEQZnLNiaMGd9u9pvdZK+CijWZRzbFJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1737726056; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wsh3c6cJMjhalquRTb31GaG5AmBp/l831R7JbIxK3R8=; b=lpnxgPVB3e8wFr3mLWvOk892Se5CpODs46q3PCDh2b4c5zON8IpjDGDJDDsV6rYlv1gt5EOqpPz5HwwXymwWlfolauYNswKlyk6/oDxb6ZveTjXoWLvWaQ9rqhUXLuOgRhqYwKGpujCac+5r3RHURel+Y60+88trl00VWfuhLY8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1737726056022681.8496959443762; Fri, 24 Jan 2025 05:40:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tbJvE-0001ez-Nt; Fri, 24 Jan 2025 08:40:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbJuI-0007Ep-To for qemu-devel@nongnu.org; Fri, 24 Jan 2025 08:39:35 -0500 Received: from mgamail.intel.com ([198.175.65.13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbJuH-00042W-BZ for qemu-devel@nongnu.org; Fri, 24 Jan 2025 08:39:34 -0500 Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 05:39:15 -0800 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by fmviesa003.fm.intel.com with ESMTP; 24 Jan 2025 05:39:10 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737725974; x=1769261974; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0CHytoVi2GC8eQQ7AANbOOAGWz2m8eyJezmiyRUq10I=; b=E6Lqi4VPgTgEbjHtd7hr0PXTuf/r46TDKI4fH8pIB9aAbtAn4QTJMOoV 8+uX3fY7Wxge66drUQDHoIV+mlLz+cYOlO6BTc+5f0WUO4M9xRdXcOcGv R6tBtpxdQdakNMq6PBxwfYIyJDrTKaMDPLyY6Ubc7A7ik6qUe3XMzk5aI iKh3XkrngPz/S5l5X98EWoRmp0HfWGQ5wKmgGi0l5///6wXdmVnL2Zp8I l/mM07GN09vAqF77IojENcy/iUyF978DTgy+4yvip7utzNQKloMtMKI/D SsZ5Ss4PUI7cJVa9A4agock0tmLyNcDP2NHiEfMWLeczVZJqotbt6boKz Q==; X-CSE-ConnectionGUID: UEvKGE4aR2OpSJp6oyG0ZQ== X-CSE-MsgGUID: xLd3d4a5Tx6pJpQAZDlmTw== X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="49246508" X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="49246508" X-CSE-ConnectionGUID: hYbMASohSQSUYNitfkfutA== X-CSE-MsgGUID: djbbnopIQ36NvvDoZQdgXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="111804409" From: Xiaoyao Li To: Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Igor Mammedov Cc: Zhao Liu , "Michael S. Tsirkin" , Eric Blake , Markus Armbruster , Peter Maydell , Marcelo Tosatti , Huacai Chen , Rick Edgecombe , Francesco Lavra , xiaoyao.li@intel.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [PATCH v7 35/52] i386/tdx: Disable PIC for TDX VMs Date: Fri, 24 Jan 2025 08:20:31 -0500 Message-Id: <20250124132048.3229049-36-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250124132048.3229049-1-xiaoyao.li@intel.com> References: <20250124132048.3229049-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.13; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -63 X-Spam_score: -6.4 X-Spam_bar: ------ X-Spam_report: (-6.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.998, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1737726058377019100 Content-Type: text/plain; charset="utf-8" Legacy PIC (8259) cannot be supported for TDX VMs since TDX module doesn't allow directly interrupt injection. Using posted interrupts for the PIC is not a viable option as the guest BIOS/kernel will not do EOI for PIC IRQs, i.e. will leave the vIRR bit set. Hence disable PIC for TDX VMs and error out if user wants PIC. Signed-off-by: Xiaoyao Li Acked-by: Gerd Hoffmann --- target/i386/kvm/tdx.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 10059ec8cf92..dcbbe350ec91 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -379,6 +379,13 @@ static int tdx_kvm_init(ConfidentialGuestSupport *cgs,= Error **errp) return -EINVAL; } =20 + if (x86ms->pic =3D=3D ON_OFF_AUTO_AUTO) { + x86ms->pic =3D ON_OFF_AUTO_OFF; + } else if (x86ms->pic =3D=3D ON_OFF_AUTO_ON) { + error_setg(errp, "TDX VM doesn't support PIC"); + return -EINVAL; + } + if (!tdx_caps) { r =3D get_tdx_capabilities(errp); if (r) { --=20 2.34.1