From nobody Thu Apr 10 11:25:36 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=@intel.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=intel.com
ARC-Seal: i=1; a=rsa-sha256; t=1737726270; cv=none;
d=zohomail.com; s=zohoarc;
b=T6N6xPea8ZdUYM31XtfmYw8/i3Re9JofrTgNPSP/MHCE9x3hgTit0T5qJbSmTem8l32baiKs50rhlOUTjN33ZHFQz+d8+g5YEJkRfZhSJycAmFmTSvcbS9WYWiGrPuu/klbqTXtrz5qtaMIQ4Uv3f/mu6Qz0f5/5SXhgIRSNhs0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1737726270;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=eiZScdxiAPC6m20DRoKsoD8EcaGo3QsYOzyOtxYGnHs=;
b=HvxZEFCpY6Tki4/dG43FsTHRBKkgfB5otuXTmUfOtnnu9VKJyAVBqxZT7MUzg9xzmVnjocVBh3/PFetcMQ+sY6DOMMVYwTihhb/odUrCXoJFzpoHNGPAZq07/TLXkt5MEfFyXcTlKad+FQ298OUTuvlanfHgAYS9iL7F/4KDRY4=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=@intel.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<xiaoyao.li@intel.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1737726270205590.4378426095891;
Fri, 24 Jan 2025 05:44:30 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tbJuQ-0008HC-OC; Fri, 24 Jan 2025 08:39:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <xiaoyao.li@intel.com>)
id 1tbJto-0006rt-RP
for qemu-devel@nongnu.org; Fri, 24 Jan 2025 08:39:07 -0500
Received: from mgamail.intel.com ([198.175.65.13])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <xiaoyao.li@intel.com>)
id 1tbJtl-0003xi-8C
for qemu-devel@nongnu.org; Fri, 24 Jan 2025 08:39:03 -0500
Received: from fmviesa003.fm.intel.com ([10.60.135.143])
by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
24 Jan 2025 05:38:44 -0800
Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52])
by fmviesa003.fm.intel.com with ESMTP; 24 Jan 2025 05:38:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1737725942; x=1769261942;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=PnMivpqsKENYPJ5DahWXLvF1ZEiK4OeXxRfzVf2Js5A=;
b=eODL+CXFMhyK7aZpGO03u0fzpVPtFgzN91WRmrLHPBbH1jBgjpVeSxgU
maT6lEkS8HwJDz4bYpF2ggHmeGb+BjhH/MccdG9nzO6zzweC/JYksSRmw
UnM+s3hOR2dpZU/7FRVMDdA3grGmnVOqoprIdWDluX0VuRCAxVlQxSLhZ
Jr7gP6Qd0BZxzsvbcVF4X39cH+jTmvzWyqD3cE7QFL8fQKRVQpM3FH7bg
VTUslFPxPLCqd4tJ0mxmmvOXdpIQfBciQS80NH5WR3IJlOcXWXbkpjwcn
ykzmBehBQU56WToooEPtmSnIomMZ4rlYMqc1NsHDfaLFW4kw8veq+/kDX g==;
X-CSE-ConnectionGUID: tx4+7eNvSY6zXSak0B+sAQ==
X-CSE-MsgGUID: pcyK3i8WQR+XaHmrjjEWqQ==
X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="49246451"
X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="49246451"
X-CSE-ConnectionGUID: iD2telCRSlykT7C4RRvX3Q==
X-CSE-MsgGUID: Q+yP9ClSSDGhPcs6vcezJA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="111804345"
From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
Igor Mammedov <imammedo@redhat.com>
Cc: Zhao Liu <zhao1.liu@intel.com>, "Michael S. Tsirkin" <mst@redhat.com>,
Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>, Huacai Chen <chenhuacai@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Francesco Lavra <francescolavra.fl@gmail.com>, xiaoyao.li@intel.com,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [PATCH v7 27/52] i386/tdx: Handle KVM_SYSTEM_EVENT_TDX_FATAL
Date: Fri, 24 Jan 2025 08:20:23 -0500
Message-Id: <20250124132048.3229049-28-xiaoyao.li@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20250124132048.3229049-1-xiaoyao.li@intel.com>
References: <20250124132048.3229049-1-xiaoyao.li@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=198.175.65.13;
envelope-from=xiaoyao.li@intel.com;
helo=mgamail.intel.com
X-Spam_score_int: -63
X-Spam_score: -6.4
X-Spam_bar: ------
X-Spam_report: (-6.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.998, RCVD_IN_DNSWL_MED=-2.3,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @intel.com)
X-ZM-MESSAGEID: 1737726271346019100
Content-Type: text/plain; charset="utf-8"
TD guest can use TDG.VP.VMCALL<REPORT_FATAL_ERROR> to request
termination. KVM translates such request into KVM_EXIT_SYSTEM_EVENT with
type of KVM_SYSTEM_EVENT_TDX_FATAL.
Add hanlder for such exit. Parse and print the error message, and
terminate the TD guest in the handler.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
Changes in v6:
- replace the patch " i386/tdx: Handle TDG.VP.VMCALL<REPORT_FATAL_ERROR>"
in v5;
---
target/i386/kvm/kvm.c | 10 ++++++++++
target/i386/kvm/tdx-stub.c | 5 +++++
target/i386/kvm/tdx.c | 24 ++++++++++++++++++++++++
target/i386/kvm/tdx.h | 2 ++
4 files changed, 41 insertions(+)
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 7de5014051eb..a76f34537908 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -6128,6 +6128,16 @@ int kvm_arch_handle_exit(CPUState *cs, struct kvm_ru=
n *run)
case KVM_EXIT_HYPERCALL:
ret =3D kvm_handle_hypercall(run);
break;
+ case KVM_EXIT_SYSTEM_EVENT:
+ switch (run->system_event.type) {
+ case KVM_SYSTEM_EVENT_TDX_FATAL:
+ ret =3D tdx_handle_report_fatal_error(cpu, run);
+ break;
+ default:
+ ret =3D -1;
+ break;
+ }
+ break;
default:
fprintf(stderr, "KVM: unknown exit reason %d\n", run->exit_reason);
ret =3D -1;
diff --git a/target/i386/kvm/tdx-stub.c b/target/i386/kvm/tdx-stub.c
index 7748b6d0a446..720a4ff046ee 100644
--- a/target/i386/kvm/tdx-stub.c
+++ b/target/i386/kvm/tdx-stub.c
@@ -13,3 +13,8 @@ int tdx_parse_tdvf(void *flash_ptr, int size)
{
return -EINVAL;
}
+
+int tdx_handle_report_fatal_error(X86CPU *cpu, struct kvm_run *run)
+{
+ return -EINVAL;
+}
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
index 1d0cf29c39f9..f857fddd839b 100644
--- a/target/i386/kvm/tdx.c
+++ b/target/i386/kvm/tdx.c
@@ -601,6 +601,30 @@ int tdx_parse_tdvf(void *flash_ptr, int size)
return tdvf_parse_metadata(&tdx_guest->tdvf, flash_ptr, size);
}
=20
+int tdx_handle_report_fatal_error(X86CPU *cpu, struct kvm_run *run)
+{
+ uint64_t error_code =3D run->system_event.data[0];
+ char *message =3D NULL;
+
+ if (error_code & 0xffff) {
+ error_report("TDX: REPORT_FATAL_ERROR: invalid error code: 0x%lx",
+ error_code);
+ return -1;
+ }
+
+ /* It has optional message */
+ if (run->system_event.data[2]) {
+#define TDX_FATAL_MESSAGE_MAX 64
+ message =3D g_malloc0(TDX_FATAL_MESSAGE_MAX + 1);
+
+ memcpy(message, &run->system_event.data[2], TDX_FATAL_MESSAGE_MAX);
+ message[TDX_FATAL_MESSAGE_MAX] =3D '\0';
+ }
+
+ error_report("TD guest reports fatal error. %s", message ? : "");
+ return -1;
+}
+
static bool tdx_guest_get_sept_ve_disable(Object *obj, Error **errp)
{
TdxGuest *tdx =3D TDX_GUEST(obj);
diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h
index 36a7400e7480..04b5afe199f9 100644
--- a/target/i386/kvm/tdx.h
+++ b/target/i386/kvm/tdx.h
@@ -8,6 +8,7 @@
#endif
=20
#include "confidential-guest.h"
+#include "cpu.h"
#include "hw/i386/tdvf.h"
=20
#define TYPE_TDX_GUEST "tdx-guest"
@@ -59,5 +60,6 @@ bool is_tdx_vm(void);
int tdx_pre_create_vcpu(CPUState *cpu, Error **errp);
void tdx_set_tdvf_region(MemoryRegion *tdvf_mr);
int tdx_parse_tdvf(void *flash_ptr, int size);
+int tdx_handle_report_fatal_error(X86CPU *cpu, struct kvm_run *run);
=20
#endif /* QEMU_I386_TDX_H */
--=20
2.34.1