docs/pcie_sriov.txt | 8 ++- include/hw/pci/pcie_sriov.h | 9 +-- hw/net/igb.c | 10 ++- hw/nvme/ctrl.c | 22 +++--- hw/pci/pci.c | 21 +++++- hw/pci/pcie_sriov.c | 159 ++++++++++++++++++++++++-------------------- hw/ppc/spapr_pci.c | 20 +++++- hw/s390x/s390-pci-bus.c | 42 +++++++++--- hw/pci/trace-events | 2 +- 9 files changed, 187 insertions(+), 106 deletions(-)
Supersedes: <20240714-rombar-v2-0-af1504ef55de@daynix.com> ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") I submitted a RFC series[1] to add support for SR-IOV emulation to virtio-net-pci. During the development of the series, I fixed some trivial bugs and made improvements that I think are independently useful. This series extracts those fixes and improvements from the RFC series. [1]: https://patchew.org/QEMU/20231210-sriov-v2-0-b959e8a6dfaf@daynix.com/ Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- Changes in v20: - Use qdev_is_realized(). - Link to v19: https://lore.kernel.org/r/20250109-reuse-v19-0-f541e82ca5f7@daynix.com Changes in v19: - Avoided inling pci_set_power(). - Link to v18: https://lore.kernel.org/r/20250104-reuse-v18-0-c349eafd8673@daynix.com Changes in v18: - Rebased. - Link to v17: https://lore.kernel.org/r/20241022-reuse-v17-0-bd7c133237e4@daynix.com Changes in v17: - Added patch "pcie_sriov: Ensure VF addr does not overflow". - Changed not to link VF with sPAPR DRC. - Asserted pci_is_vf() when zpci is not found. (Cédric Le Goater) - Link to v16: https://lore.kernel.org/r/20240913-reuse-v16-0-d016b4b4f616@daynix.com Changes in v16: - Added patch "s390x/pci: Avoid creating zpci for VFs". - Added patch "s390x/pci: Allow plugging SR-IOV devices". - Link to v15: https://lore.kernel.org/r/20240823-reuse-v15-0-eddcb960e289@daynix.com Changes in v15: - Fixed variable shadowing in patch "pcie_sriov: Remove num_vfs from PCIESriovPF" - Link to v14: https://lore.kernel.org/r/20240813-reuse-v14-0-4c15bc6ee0e6@daynix.com Changes in v14: - Dropped patch "pcie_sriov: Ensure VF function number does not overflow" as I found the restriction it imposes is unnecessary. - Link to v13: https://lore.kernel.org/r/20240805-reuse-v13-0-aaeaa4d7dfd2@daynix.com Changes in v13: - Added patch "s390x/pci: Check for multifunction after device realization". I found SR-IOV devices, which are multifunction devices, are not supposed to work at all with s390x on QEMU. - Link to v12: https://lore.kernel.org/r/20240804-reuse-v12-0-d3930c4111b2@daynix.com Changes in v12: - Changed to ignore invalid PCI_SRIOV_NUM_VF writes as done for PCI_SRIOV_CTRL_VFE. - Updated the message for patch "hw/pci: Use -1 as the default value for rombar". (Markus Armbruster) - Link to v11: https://lore.kernel.org/r/20240802-reuse-v11-0-fb83bb8c19fb@daynix.com Changes in v11: - Rebased. - Dropped patch "hw/pci: Convert rom_bar into OnOffAuto". - Added patch "hw/pci: Use -1 as the default value for rombar". - Added for-9.2 to give a testing period for possible breakage with libvirt/s390x. - Link to v10: https://lore.kernel.org/r/20240627-reuse-v10-0-7ca0b8ed3d9f@daynix.com Changes in v10: - Added patch "hw/ppc/spapr_pci: Do not reject VFs created after a PF". - Added patch "hw/ppc/spapr_pci: Do not create DT for disabled PCI device". - Added patch "hw/pci: Convert rom_bar into OnOffAuto". - Dropped patch "hw/pci: Determine if rombar is explicitly enabled". - Dropped patch "hw/qdev: Remove opts member". - Link to v9: https://lore.kernel.org/r/20240315-reuse-v9-0-67aa69af4d53@daynix.com Changes in v9: - Rebased. - Restored '#include "qapi/error.h"' (Michael S. Tsirkin) - Added patch "pcie_sriov: Ensure VF function number does not overflow" to fix abortion with wrong PF addr. - Link to v8: https://lore.kernel.org/r/20240228-reuse-v8-0-282660281e60@daynix.com Changes in v8: - Clarified that "hw/pci: Replace -1 with UINT32_MAX for romsize" is not a bug fix. (Markus Armbruster) - Squashed patch "vfio: Avoid inspecting option QDict for rombar" into "hw/pci: Determine if rombar is explicitly enabled". (Markus Armbruster) - Noted the minor semantics change for patch "hw/pci: Determine if rombar is explicitly enabled". (Markus Armbruster) - Link to v7: https://lore.kernel.org/r/20240224-reuse-v7-0-29c14bcb952e@daynix.com Changes in v7: - Replaced -1 with UINT32_MAX when expressing uint32_t. (Markus Armbruster) - Added patch "hw/pci: Replace -1 with UINT32_MAX for romsize". - Link to v6: https://lore.kernel.org/r/20240220-reuse-v6-0-2e42a28b0cf2@daynix.com Changes in v6: - Fixed migration. - Added patch "pcie_sriov: Do not manually unrealize". - Restored patch "pcie_sriov: Release VFs failed to realize" that was missed in v5. - Link to v5: https://lore.kernel.org/r/20240218-reuse-v5-0-e4fc1c19b5a9@daynix.com Changes in v5: - Added patch "hw/pci: Always call pcie_sriov_pf_reset()". - Added patch "pcie_sriov: Reset SR-IOV extended capability". - Removed a reference to PCI_SRIOV_CTRL_VFE in hw/nvme. (Michael S. Tsirkin) - Noted the impact on the guest of patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". (Michael S. Tsirkin) - Changed to use pcie_sriov_num_vfs(). - Restored pci_set_power() and changed it to call pci_set_enabled() only for PFs with an expalanation. (Michael S. Tsirkin) - Reordered patches. - Link to v4: https://lore.kernel.org/r/20240214-reuse-v4-0-89ad093a07f4@daynix.com Changes in v4: - Reverted the change to pci_rom_bar_explicitly_enabled(). (Michael S. Tsirkin) - Added patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". - Added patch "hw/nvme: Refer to dev->exp.sriov_pf.num_vfs". - Link to v3: https://lore.kernel.org/r/20240212-reuse-v3-0-8017b689ce7f@daynix.com Changes in v3: - Extracted patch "hw/pci: Use -1 as a default value for rombar" from patch "hw/pci: Determine if rombar is explicitly enabled" (Philippe Mathieu-Daudé) - Added an audit result of PCIDevice::rom_bar to the message of patch "hw/pci: Use -1 as a default value for rombar" (Philippe Mathieu-Daudé) - Link to v2: https://lore.kernel.org/r/20240210-reuse-v2-0-24ba2a502692@daynix.com Changes in v2: - Reset after enabling a function so that NVMe VF state gets updated. - Link to v1: https://lore.kernel.org/r/20240203-reuse-v1-0-5be8c5ce6338@daynix.com --- Akihiko Odaki (11): hw/ppc/spapr_pci: Do not create DT for disabled PCI device hw/ppc/spapr_pci: Do not reject VFs created after a PF s390x/pci: Avoid creating zpci for VFs s390x/pci: Allow plugging SR-IOV devices s390x/pci: Check for multifunction after device realization pcie_sriov: Do not manually unrealize pcie_sriov: Ensure VF addr does not overflow pcie_sriov: Reuse SR-IOV VF device instances pcie_sriov: Release VFs failed to realize pcie_sriov: Remove num_vfs from PCIESriovPF pcie_sriov: Register VFs after migration docs/pcie_sriov.txt | 8 ++- include/hw/pci/pcie_sriov.h | 9 +-- hw/net/igb.c | 10 ++- hw/nvme/ctrl.c | 22 +++--- hw/pci/pci.c | 21 +++++- hw/pci/pcie_sriov.c | 159 ++++++++++++++++++++++++-------------------- hw/ppc/spapr_pci.c | 20 +++++- hw/s390x/s390-pci-bus.c | 42 +++++++++--- hw/pci/trace-events | 2 +- 9 files changed, 187 insertions(+), 106 deletions(-) --- base-commit: 7433709a147706ad7d1956b15669279933d0f82b change-id: 20240129-reuse-faae22b11934 Best regards, -- Akihiko Odaki <akihiko.odaki@daynix.com>
Hi Michael, It has been a while since this series was reviewed by maintainers of relevant architectures. Can you check if this series is ready to pull? Regards, Akihiko Odaki On 2025/01/16 18:00, Akihiko Odaki wrote: > Supersedes: <20240714-rombar-v2-0-af1504ef55de@daynix.com> > ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") > > I submitted a RFC series[1] to add support for SR-IOV emulation to > virtio-net-pci. During the development of the series, I fixed some > trivial bugs and made improvements that I think are independently > useful. This series extracts those fixes and improvements from the RFC > series. > > [1]: https://patchew.org/QEMU/20231210-sriov-v2-0-b959e8a6dfaf@daynix.com/ > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> > --- > Changes in v20: > - Use qdev_is_realized(). > - Link to v19: https://lore.kernel.org/r/20250109-reuse-v19-0-f541e82ca5f7@daynix.com > > Changes in v19: > - Avoided inling pci_set_power(). > - Link to v18: https://lore.kernel.org/r/20250104-reuse-v18-0-c349eafd8673@daynix.com > > Changes in v18: > - Rebased. > - Link to v17: https://lore.kernel.org/r/20241022-reuse-v17-0-bd7c133237e4@daynix.com > > Changes in v17: > - Added patch "pcie_sriov: Ensure VF addr does not overflow". > - Changed not to link VF with sPAPR DRC. > - Asserted pci_is_vf() when zpci is not found. (Cédric Le Goater) > - Link to v16: https://lore.kernel.org/r/20240913-reuse-v16-0-d016b4b4f616@daynix.com > > Changes in v16: > - Added patch "s390x/pci: Avoid creating zpci for VFs". > - Added patch "s390x/pci: Allow plugging SR-IOV devices". > - Link to v15: https://lore.kernel.org/r/20240823-reuse-v15-0-eddcb960e289@daynix.com > > Changes in v15: > - Fixed variable shadowing in patch > "pcie_sriov: Remove num_vfs from PCIESriovPF" > - Link to v14: https://lore.kernel.org/r/20240813-reuse-v14-0-4c15bc6ee0e6@daynix.com > > Changes in v14: > - Dropped patch "pcie_sriov: Ensure VF function number does not > overflow" as I found the restriction it imposes is unnecessary. > - Link to v13: https://lore.kernel.org/r/20240805-reuse-v13-0-aaeaa4d7dfd2@daynix.com > > Changes in v13: > - Added patch "s390x/pci: Check for multifunction after device > realization". I found SR-IOV devices, which are multifunction devices, > are not supposed to work at all with s390x on QEMU. > - Link to v12: https://lore.kernel.org/r/20240804-reuse-v12-0-d3930c4111b2@daynix.com > > Changes in v12: > - Changed to ignore invalid PCI_SRIOV_NUM_VF writes as done for > PCI_SRIOV_CTRL_VFE. > - Updated the message for patch "hw/pci: Use -1 as the default value for > rombar". (Markus Armbruster) > - Link to v11: https://lore.kernel.org/r/20240802-reuse-v11-0-fb83bb8c19fb@daynix.com > > Changes in v11: > - Rebased. > - Dropped patch "hw/pci: Convert rom_bar into OnOffAuto". > - Added patch "hw/pci: Use -1 as the default value for rombar". > - Added for-9.2 to give a testing period for possible breakage with > libvirt/s390x. > - Link to v10: https://lore.kernel.org/r/20240627-reuse-v10-0-7ca0b8ed3d9f@daynix.com > > Changes in v10: > - Added patch "hw/ppc/spapr_pci: Do not reject VFs created after a PF". > - Added patch "hw/ppc/spapr_pci: Do not create DT for disabled PCI device". > - Added patch "hw/pci: Convert rom_bar into OnOffAuto". > - Dropped patch "hw/pci: Determine if rombar is explicitly enabled". > - Dropped patch "hw/qdev: Remove opts member". > - Link to v9: https://lore.kernel.org/r/20240315-reuse-v9-0-67aa69af4d53@daynix.com > > Changes in v9: > - Rebased. > - Restored '#include "qapi/error.h"' (Michael S. Tsirkin) > - Added patch "pcie_sriov: Ensure VF function number does not overflow" > to fix abortion with wrong PF addr. > - Link to v8: https://lore.kernel.org/r/20240228-reuse-v8-0-282660281e60@daynix.com > > Changes in v8: > - Clarified that "hw/pci: Replace -1 with UINT32_MAX for romsize" is > not a bug fix. (Markus Armbruster) > - Squashed patch "vfio: Avoid inspecting option QDict for rombar" into > "hw/pci: Determine if rombar is explicitly enabled". > (Markus Armbruster) > - Noted the minor semantics change for patch "hw/pci: Determine if > rombar is explicitly enabled". (Markus Armbruster) > - Link to v7: https://lore.kernel.org/r/20240224-reuse-v7-0-29c14bcb952e@daynix.com > > Changes in v7: > - Replaced -1 with UINT32_MAX when expressing uint32_t. > (Markus Armbruster) > - Added patch "hw/pci: Replace -1 with UINT32_MAX for romsize". > - Link to v6: https://lore.kernel.org/r/20240220-reuse-v6-0-2e42a28b0cf2@daynix.com > > Changes in v6: > - Fixed migration. > - Added patch "pcie_sriov: Do not manually unrealize". > - Restored patch "pcie_sriov: Release VFs failed to realize" that was > missed in v5. > - Link to v5: https://lore.kernel.org/r/20240218-reuse-v5-0-e4fc1c19b5a9@daynix.com > > Changes in v5: > - Added patch "hw/pci: Always call pcie_sriov_pf_reset()". > - Added patch "pcie_sriov: Reset SR-IOV extended capability". > - Removed a reference to PCI_SRIOV_CTRL_VFE in hw/nvme. > (Michael S. Tsirkin) > - Noted the impact on the guest of patch "pcie_sriov: Do not reset > NumVFs after unregistering VFs". (Michael S. Tsirkin) > - Changed to use pcie_sriov_num_vfs(). > - Restored pci_set_power() and changed it to call pci_set_enabled() only > for PFs with an expalanation. (Michael S. Tsirkin) > - Reordered patches. > - Link to v4: https://lore.kernel.org/r/20240214-reuse-v4-0-89ad093a07f4@daynix.com > > Changes in v4: > - Reverted the change to pci_rom_bar_explicitly_enabled(). > (Michael S. Tsirkin) > - Added patch "pcie_sriov: Do not reset NumVFs after unregistering VFs". > - Added patch "hw/nvme: Refer to dev->exp.sriov_pf.num_vfs". > - Link to v3: https://lore.kernel.org/r/20240212-reuse-v3-0-8017b689ce7f@daynix.com > > Changes in v3: > - Extracted patch "hw/pci: Use -1 as a default value for rombar" from > patch "hw/pci: Determine if rombar is explicitly enabled" > (Philippe Mathieu-Daudé) > - Added an audit result of PCIDevice::rom_bar to the message of patch > "hw/pci: Use -1 as a default value for rombar" > (Philippe Mathieu-Daudé) > - Link to v2: https://lore.kernel.org/r/20240210-reuse-v2-0-24ba2a502692@daynix.com > > Changes in v2: > - Reset after enabling a function so that NVMe VF state gets updated. > - Link to v1: https://lore.kernel.org/r/20240203-reuse-v1-0-5be8c5ce6338@daynix.com > > --- > Akihiko Odaki (11): > hw/ppc/spapr_pci: Do not create DT for disabled PCI device > hw/ppc/spapr_pci: Do not reject VFs created after a PF > s390x/pci: Avoid creating zpci for VFs > s390x/pci: Allow plugging SR-IOV devices > s390x/pci: Check for multifunction after device realization > pcie_sriov: Do not manually unrealize > pcie_sriov: Ensure VF addr does not overflow > pcie_sriov: Reuse SR-IOV VF device instances > pcie_sriov: Release VFs failed to realize > pcie_sriov: Remove num_vfs from PCIESriovPF > pcie_sriov: Register VFs after migration > > docs/pcie_sriov.txt | 8 ++- > include/hw/pci/pcie_sriov.h | 9 +-- > hw/net/igb.c | 10 ++- > hw/nvme/ctrl.c | 22 +++--- > hw/pci/pci.c | 21 +++++- > hw/pci/pcie_sriov.c | 159 ++++++++++++++++++++++++-------------------- > hw/ppc/spapr_pci.c | 20 +++++- > hw/s390x/s390-pci-bus.c | 42 +++++++++--- > hw/pci/trace-events | 2 +- > 9 files changed, 187 insertions(+), 106 deletions(-) > --- > base-commit: 7433709a147706ad7d1956b15669279933d0f82b > change-id: 20240129-reuse-faae22b11934 > > Best regards,
© 2016 - 2025 Red Hat, Inc.