From nobody Sun Apr 6 23:45:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1736720586; cv=none; d=zohomail.com; s=zohoarc; b=HOGXNGIUeRRrdvv1sIamORj3/gycKke3N5MX8Q1283bP7kmRlKA/Np0W6dItssc6tKVerg6X9PvSQ3/hqK+/9Ia+8Xl4/HFVbmZ4e9NEmCe9/933WVMM0cNqGBAZJlT3p+C2cA29hw7b6mi5U+daJhk6F3CYMp87PXl9FMKZN0o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1736720586; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xIb8JuttOpsx6n0lGPjJoZH2kDKEyQKUDAozyZfVQNI=; b=bg3TSYQCzhOjVPMPov/Dh0V47szljdP4ZzySBACz9siD5rwswTFTTUPPBPv1mBqfTTQIS3xNKqa32jY8k7mw/Pn2Xv42mTw9nD9Snp6rcK+z0hxtFu/92T3DDnlL0Da5ohUUMCwmRWtQlKnKu8ivB4wUrQfDs9jdY2EW0NeSxt4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1736720586099704.0489560483131; Sun, 12 Jan 2025 14:23:06 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tX6Kb-0004x2-Le; Sun, 12 Jan 2025 17:21:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tX6KX-0004tj-D2 for qemu-devel@nongnu.org; Sun, 12 Jan 2025 17:21:14 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tX6KU-0006to-NL for qemu-devel@nongnu.org; Sun, 12 Jan 2025 17:21:13 -0500 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso26176525e9.2 for ; Sun, 12 Jan 2025 14:21:10 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c76esm10367540f8f.47.2025.01.12.14.21.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 12 Jan 2025 14:21:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736720469; x=1737325269; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xIb8JuttOpsx6n0lGPjJoZH2kDKEyQKUDAozyZfVQNI=; b=A66GUq5pwM3+pcjNcxe6chbLk7SSNG43CcbN+wX28YQzwJES5C34IIooADC/LbhK8H XBlFXskOU6W0QBFAHZIP6nkzCgYfi7tXzFryJuMO8UrdTVRjl5mlVbGnoVyyMdsr8teA t217kHLS6htCoDiPnGTcJmeUxjbOAfjQOLVTjMgbVCsA4ocF47Aph7KNdo9fit128JKm 7mt7yL6hoQq+fewvHYZ4zrjS/d4JcdUwwSEUeZ+UrjMYvq3zazDderErWVt6RIxvGnIr m6lJEm166uThGi5kdNTLfW/hIOQzvsaM03Mdhq1pHy39PfSKgcZ3Bh3YMZ5rj4Ma782X e1sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736720469; x=1737325269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIb8JuttOpsx6n0lGPjJoZH2kDKEyQKUDAozyZfVQNI=; b=alerIpDsoo0LnQcx+t2Olr0YxQtjTyn6pBX/a+c/vdYCCGY6+R+sr/713KH2JpBNBm EhQuPannPVrux85EKkby9O9sirhXoZZ2o00A7orJHSPKYBb4VO0BQ1ekIx8hW5JBj7ec 6mI9shBtSOaUKU566N0fONezHs8KBU29maM6IXc0PLPV6PMUA7E+Rx4Bd/nPDXtzYCBp 74RQifSxIEumL2nNT4csub1+woxxKqER4cRBMkPX1vCVTP95w1ytLTfpMIwaWZDDl1i0 evbOUiK+p38v/ve5mWuox6qlD3QH10pQC/7IZQV8F4RRjCtwoPwQuiJNI1MAE6lfNiNL rNbQ== X-Gm-Message-State: AOJu0YxVHqnezVzlsniU72s0Bsly4tODm9MAZBUfNmsyg/w0AEG8QeiF Q1KNUU+xtbrsSJi9qcdzXLomWLqDheFrJ63ThazRPjMKrrlrljhUYfsHaqD7efzw2snLF2TLwPu +BOw= X-Gm-Gg: ASbGnctDKBhl1RtPRJzf/Sq7au/+O7blpQK54MBvqdMeXauGfePTR+Z67m+f9w2ttsH oZB73Lp6ousI0fB1rQiBV/Lw6PT2tO79kaiIQmYJtlEmUBVEL73v7aGKZgxvxT0xzYpnje8DIKu 64OyiBNuoUqoD196Utc2a+s5+njgAFCyVdND55K7sNWwQB1lLtkg7G7vCDmwre8r81wbsQzRlev Ni77N4vsQUJ+EeG7uWwAjEiTmwWXi/MpG0nDVRDEdAlR+69004i2JoI+OTur/celxhpHwZaXKBd KydHO3RxEnWdHL6F7QdiRhOoWUcriLc= X-Google-Smtp-Source: AGHT+IEkBIux/+pbMKGUmXUe3lf6N1usP/74iCueDCTPlbh4zApMxhiCLes+3rAkj2t8ybp7H2kc1w== X-Received: by 2002:a5d:59af:0:b0:382:31a1:8dc3 with SMTP id ffacd0b85a97d-38a87313151mr17382755f8f.35.1736720469017; Sun, 12 Jan 2025 14:21:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Pierrick Bouvier , Bastian Koppelmann Subject: [PULL 45/49] hw/tricore/triboard: Remove unnecessary use of &first_cpu Date: Sun, 12 Jan 2025 23:17:21 +0100 Message-ID: <20250112221726.30206-46-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250112221726.30206-1-philmd@linaro.org> References: <20250112221726.30206-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1736720587418019000 triboard_machine_init() has access to the single CPU via: TriBoardMachineState { TC27XSoCState { TriCoreCPU cpu; ... } tc27x_soc; } ms; Pass it as argument to tricore_load_kernel() so we can remove the &first_cpu global use. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier Reviewed-by: Bastian Koppelmann Message-Id: <20250110180909.83165-1-philmd@linaro.org> --- hw/tricore/triboard.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/tricore/triboard.c b/hw/tricore/triboard.c index 4dba0259cd3..9cc8d282ff2 100644 --- a/hw/tricore/triboard.c +++ b/hw/tricore/triboard.c @@ -31,11 +31,10 @@ #include "hw/tricore/triboard.h" #include "hw/tricore/tc27x_soc.h" =20 -static void tricore_load_kernel(const char *kernel_filename) +static void tricore_load_kernel(TriCoreCPU *cpu, const char *kernel_filena= me) { uint64_t entry; long kernel_size; - TriCoreCPU *cpu; CPUTriCoreState *env; =20 kernel_size =3D load_elf(kernel_filename, NULL, @@ -46,7 +45,6 @@ static void tricore_load_kernel(const char *kernel_filena= me) error_report("no kernel file '%s'", kernel_filename); exit(1); } - cpu =3D TRICORE_CPU(first_cpu); env =3D &cpu->env; env->PC =3D entry; } @@ -62,7 +60,7 @@ static void triboard_machine_init(MachineState *machine) sysbus_realize(SYS_BUS_DEVICE(&ms->tc27x_soc), &error_fatal); =20 if (machine->kernel_filename) { - tricore_load_kernel(machine->kernel_filename); + tricore_load_kernel(&ms->tc27x_soc.cpu, machine->kernel_filename); } } =20 --=20 2.47.1