From nobody Fri Apr 11 12:21:06 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=suse.de
ARC-Seal: i=1; a=rsa-sha256; t=1736511706; cv=none;
d=zohomail.com; s=zohoarc;
b=PhqeXD/eJll8S3pba63BAQ2wXwYqRCyqQ/Qk79Ls6qxNcwZu5AImtiqJqVhgg53zgBHy2KsMsjetA5e2mth4Z+Hk9owdpDUd0nMBOBBrk0NsDex0ktVzlglGnxZKHHeQkpqMuWyz13QI8NoO4fi+/N+UGMXFMJA3xJCo3ZbUx3w=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1736511706;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=ks45ydwG0kBNKzyID683TU9f0dVSpmqSa0joXFagojc=;
b=CYBty5HP96a82K6VmHokputF4C5kC5skWkuR0zxgGu8g6snH1ZPm4ufcb8XZ/DSzrZ2E8UfvN46k2WA40wTp/XEUOAuKdwN71m3gNVGuVybNjeClyDvEgBDUGWuGvz0AXTsIADK9UQoaWYGg3VzDIaKj2JKm/LEWA9gySxaWSYw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<farosas@suse.de> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1736511706120871.3686766317417;
Fri, 10 Jan 2025 04:21:46 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tWDus-0001Yw-Sj; Fri, 10 Jan 2025 07:15:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1tWDum-0001Y0-79
for qemu-devel@nongnu.org; Fri, 10 Jan 2025 07:15:02 -0500
Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1tWDuk-0003On-Bk
for qemu-devel@nongnu.org; Fri, 10 Jan 2025 07:14:59 -0500
Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org
[IPv6:2a07:de40:b281:104:10:150:64:97])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest
SHA256)
(No client certificate requested)
by smtp-out1.suse.de (Postfix) with ESMTPS id 5FE8E210F2;
Fri, 10 Jan 2025 12:14:56 +0000 (UTC)
Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest
SHA256)
(No client certificate requested)
by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EC61713A86;
Fri, 10 Jan 2025 12:14:54 +0000 (UTC)
Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])
by imap1.dmz-prg2.suse.org with ESMTPSA id 6JnZKz4PgWdURwAAD6G6ig
(envelope-from <farosas@suse.de>); Fri, 10 Jan 2025 12:14:54 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;
s=susede2_rsa;
t=1736511296;
h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=ks45ydwG0kBNKzyID683TU9f0dVSpmqSa0joXFagojc=;
b=M/JLnObHmqP6sLeDoDh5t6Kts9jsluH9dmLHpsaFEL1CxjkCcyj9Te84btWQE13YLuJ5f/
YMM61E0cKMS7TLJUI9+tCjBBiEoqdE3aUHfpurfvQ4ngRz7CE4iCWbJuvmfj+DCvSPGmIy
4Hjt2HGngyEdRsYG6WuJ9RN91qSfLRA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
s=susede2_ed25519; t=1736511296;
h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=ks45ydwG0kBNKzyID683TU9f0dVSpmqSa0joXFagojc=;
b=oK/qzWJSQCqj/44nJAPNp/W05cJqdHx9ZW6DPlUmlHjKh3aToaaUseNX0csnLOoyLy/vIl
4q0q/zdLt7CQDNCw==
Authentication-Results: smtp-out1.suse.de;
dkim=pass header.d=suse.de header.s=susede2_rsa header.b="M/JLnObH";
dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="oK/qzWJS"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;
s=susede2_rsa;
t=1736511296;
h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=ks45ydwG0kBNKzyID683TU9f0dVSpmqSa0joXFagojc=;
b=M/JLnObHmqP6sLeDoDh5t6Kts9jsluH9dmLHpsaFEL1CxjkCcyj9Te84btWQE13YLuJ5f/
YMM61E0cKMS7TLJUI9+tCjBBiEoqdE3aUHfpurfvQ4ngRz7CE4iCWbJuvmfj+DCvSPGmIy
4Hjt2HGngyEdRsYG6WuJ9RN91qSfLRA=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
s=susede2_ed25519; t=1736511296;
h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=ks45ydwG0kBNKzyID683TU9f0dVSpmqSa0joXFagojc=;
b=oK/qzWJSQCqj/44nJAPNp/W05cJqdHx9ZW6DPlUmlHjKh3aToaaUseNX0csnLOoyLy/vIl
4q0q/zdLt7CQDNCw==
From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Yuan Liu <yuan1.liu@intel.com>,
Jason Zeng <jason.zeng@intel.com>
Subject: [PULL 25/25] multifd: bugfix for incorrect migration data with qatzip
compression
Date: Fri, 10 Jan 2025 09:14:13 -0300
Message-Id: <20250110121413.12336-26-farosas@suse.de>
X-Mailer: git-send-email 2.35.3
In-Reply-To: <20250110121413.12336-1-farosas@suse.de>
References: <20250110121413.12336-1-farosas@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Queue-Id: 5FE8E210F2
X-Spam-Score: -3.01
X-Rspamd-Action: no action
X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%];
MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];
R_MISSING_CHARSET(0.50)[];
R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];
NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];
MX_GOOD(-0.01)[];
DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,suse.de:dkim,suse.de:mid,suse.de:email];
ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; ARC_NA(0.00)[];
FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+];
TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];
FROM_EQ_ENVFROM(0.00)[];
DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];
FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2];
RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4];
DKIM_TRACE(0.00)[suse.de:+]
X-Rspamd-Server: rspamd1.dmz-prg2.suse.org
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1;
envelope-from=farosas@suse.de; helo=smtp-out1.suse.de
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @suse.de)
X-ZM-MESSAGEID: 1736511707056116600
Content-Type: text/plain; charset="utf-8"
From: Yuan Liu <yuan1.liu@intel.com>
When QPL compression is enabled on the migration channel and the same
dirty page changes from a normal page to a zero page in the iterative
memory copy, the dirty page will not be updated to a zero page again
on the target side, resulting in incorrect memory data on the source
and target sides.
The root cause is that the target side does not record the normal pages
to the receivedmap.
The solution is to add ramblock_recv_bitmap_set_offset in target side
to record the normal pages.
Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Jason Zeng <jason.zeng@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20241218091413.140396-4-yuan1.liu@intel.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/multifd-qatzip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/multifd-qatzip.c b/migration/multifd-qatzip.c
index 7b68397625..6a0e989fae 100644
--- a/migration/multifd-qatzip.c
+++ b/migration/multifd-qatzip.c
@@ -373,6 +373,7 @@ static int qatzip_recv(MultiFDRecvParams *p, Error **er=
rp)
/* Copy each page to its appropriate location. */
for (int i =3D 0; i < p->normal_num; i++) {
memcpy(p->host + p->normal[i], q->out_buf + page_size * i, page_si=
ze);
+ ramblock_recv_bitmap_set_offset(p->block, p->normal[i]);
}
return 0;
}
--=20
2.35.3