From nobody Wed Apr 9 04:14:10 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1735921243; cv=none; d=zohomail.com; s=zohoarc; b=BkKEqsnxdwSuSdP1RBQiq90mQza4mVFpbY419r1+SMtcrsj2/29bwx70LrweSpxCh6fkQ0TmT2jbenhu60s8y+KKJtKKHRJT6Y325/0rX2WlRLWRl7RJIlY6G9gQPgyO4NqwWZtJxN0DeDW7VTeXWJefjPTzr+c5TklfSVeiQX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1735921243; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iixKk5Q0dYDDrARCZDFFwcYNAdJEzOCoUjmmBfG6iF8=; b=Lnyrv02RZsI+WvImNgcjc5HnSpsFj808uYKLEW0xVIdtrEAiwJ7m4QMVqL+R0+Uy52gvcg5owUuc6NVqvQ6Ix4KzXUkqKpDVnFJmlYIL3dZltW3727G+bgz6YVsc5P8RjstvYBDnfK8P0CLYdOz9WyhfFQOH0s3ZGOmJXgaxhKg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1735921243903145.01622366700087; Fri, 3 Jan 2025 08:20:43 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTkOJ-0005ei-Ok; Fri, 03 Jan 2025 11:19:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTkOI-0005eK-3s; Fri, 03 Jan 2025 11:19:14 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTkOG-0001aI-MW; Fri, 03 Jan 2025 11:19:13 -0500 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 503E4Gje026493; Fri, 3 Jan 2025 16:19:03 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43x4mab1qk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Jan 2025 16:19:02 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 503G5wVD002309; Fri, 3 Jan 2025 16:19:02 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43x4mab1qg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Jan 2025 16:19:02 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 503CKMBb004365; Fri, 3 Jan 2025 16:19:01 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43twvk6qkv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Jan 2025 16:19:01 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 503GIwtP32112940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Jan 2025 16:18:58 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EDD4320049; Fri, 3 Jan 2025 16:18:57 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C000220040; Fri, 3 Jan 2025 16:18:55 +0000 (GMT) Received: from gfwr515.rchland.ibm.com (unknown [9.10.239.103]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 3 Jan 2025 16:18:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=iixKk5Q0dYDDrARCZ DFFwcYNAdJEzOCoUjmmBfG6iF8=; b=e7dJKOxXrgL/aXuKXKZRgH12cyKVvVp9+ S6oB0vdGV4fijnrQOswZfcQIk785MMnSUpwpiExu6WAbnYQOQ+zey4fkbIUWk6O8 C9Hl2PHEZRVfqn+5NlVCPNBEG4jc1a24CsvOE6r4vutqH40mcvGJjCgfR8i+SPyV K0/cPwSNbuEaVZ3Q3CM5XhiZr5twj1VWNNEsRsSoXRxccARMfNp2DAR5nBYRvsdG hUoUf9dB0hOZpyEGYA2E7B+I1YDwOY8wMVuWe1jk4Nj1Rj8ah27FyJGoPyEjZoj9 D62PY/VPsdWFOuh1Dn6EtCqux1uvQB9GismWtN4W/raS7+PnDgVRw== From: Chalapathi V To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, fbarrat@linux.ibm.com, npiggin@gmail.com, clg@kaod.org, calebs@linux.ibm.com, chalapathi.v@ibm.com, chalapathi.v@linux.ibm.com, saif.abrar@linux.ibm.com, dantan@linux.vnet.ibm.com, milesg@linux.ibm.com, philmd@linaro.org, alistair@alistair23.me Subject: [PATCH v5 4/4] hw/ssi/pnv_spi: Put a limit to RDR match failures Date: Fri, 3 Jan 2025 10:18:24 -0600 Message-Id: <20250103161824.22469-5-chalapathi.v@linux.ibm.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250103161824.22469-1-chalapathi.v@linux.ibm.com> References: <20250103161824.22469-1-chalapathi.v@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vWoRzg3feIU3L7dmhPJLkzO_tjjw7saS X-Proofpoint-ORIG-GUID: Q2VhpmavniXestWuDPCNPVDYrOnpKBGT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=983 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501030141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=chalapathi.v@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1735921264456116600 Content-Type: text/plain; charset="utf-8" There is a possibility that SPI controller can get into loop due to indefin= ite RDR match failures. Hence put a limit to failures and stop the sequencer. Signed-off-by: Chalapathi V Reviewed-by: Nicholas Piggin --- hw/ssi/pnv_spi.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c index 41beb559c6..d605fa8b46 100644 --- a/hw/ssi/pnv_spi.c +++ b/hw/ssi/pnv_spi.c @@ -20,6 +20,7 @@ #define PNV_SPI_OPCODE_LO_NIBBLE(x) (x & 0x0F) #define PNV_SPI_MASKED_OPCODE(x) (x & 0xF0) #define PNV_SPI_FIFO_SIZE 16 +#define RDR_MATCH_FAILURE_LIMIT 16 =20 /* * Macro from include/hw/ppc/fdt.h @@ -838,21 +839,31 @@ static void operation_sequencer(PnvSpi *s) */ if (GETFIELD(SPI_STS_RDR_FULL, s->status) =3D=3D 1) { bool rdr_matched =3D false; + static int fail_count; rdr_matched =3D does_rdr_match(s); if (rdr_matched) { trace_pnv_spi_RDR_match("success"); + fail_count =3D 0; /* A match occurred, increment the sequencer index. */ seq_index++; s->status =3D SETFIELD(SPI_STS_SEQ_FSM, s->status, SEQ_STATE_INDEX_INCREMENT); } else { trace_pnv_spi_RDR_match("failed"); + fail_count++; /* * Branch the sequencer to the index coded into the op * code. */ seq_index =3D PNV_SPI_OPCODE_LO_NIBBLE(opcode); } + if (fail_count >=3D RDR_MATCH_FAILURE_LIMIT) { + qemu_log_mask(LOG_GUEST_ERROR, "pnv_spi: RDR match fai= lure" + " limit crossed %d times hence requestin= g " + "sequencer to stop.\n", + RDR_MATCH_FAILURE_LIMIT); + stop =3D true; + } /* * Regardless of where the branch ended up we want the * sequencer to continue shifting so we have to clear --=20 2.39.5