From nobody Sun Apr 6 22:16:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1735919685528865.7152668585327; Fri, 3 Jan 2025 07:54:45 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id A1B6899B; Fri, 3 Jan 2025 10:54:44 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 44994977; Fri, 3 Jan 2025 10:54:25 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 4A46296B; Fri, 3 Jan 2025 10:54:22 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C860196E for ; Fri, 3 Jan 2025 10:54:21 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-D0cptFSUNbWyxj0r9RrKpw-1; Fri, 03 Jan 2025 10:54:18 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECFA619560B4; Fri, 3 Jan 2025 15:54:16 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.148]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C0A9319560AA; Fri, 3 Jan 2025 15:54:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735919661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8MK3UcVLcOkZD/EmeCE8e77wopXF8zXhW3+DVQ2Dxmk=; b=WiRt/SG5F7KbiYh7AcI48P2doWQwUHVPVWnt/CCG6uVK6W/mvqfjJUHd6vNQG5YkYH8n8Z sU4uI82Bz4UOPS+I00WGRewQh73apZyX5fLdnt/cG6DjWgljOP/MIpBqtfFNwAyr36L1rS 4gPv7zC5bu5kZJU1L5qs6140VEswbM0= X-MC-Unique: D0cptFSUNbWyxj0r9RrKpw-1 X-Mimecast-MFC-AGG-ID: D0cptFSUNbWyxj0r9RrKpw From: Thomas Huth To: qemu-devel@nongnu.org Subject: [PATCH] Remove the deprecated "-runas" command line option Date: Fri, 3 Jan 2025 16:54:11 +0100 Message-ID: <20250103155411.721759-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BRNJB56EXXLHA7A7UQNNCR4UZBCMPIUS X-Message-ID-Hash: BRNJB56EXXLHA7A7UQNNCR4UZBCMPIUS X-MailFrom: thuth@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: qemu-trivial@nongnu.org, Paolo Bonzini , devel@lists.libvirt.org X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1735919687428116600 Content-Type: text/plain; charset="utf-8" It has been marked as deprecated two releases ago, so it should be fine now to remove this command line option. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 6 ++++++ system/vl.c | 9 --------- qemu-options.hx | 15 +-------------- 4 files changed, 7 insertions(+), 29 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index d6809f94ea..63b46fd520 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -74,12 +74,6 @@ configurations (e.g. -smp drawers=3D1,books=3D1,clusters= =3D1 for x86 PC machine) is marked deprecated since 9.0, users have to ensure that all the topology me= mbers described with -smp are supported by the target machine. =20 -``-runas`` (since 9.1) -'''''''''''''''''''''' - -Use ``-run-with user=3D..`` instead. - - User-mode emulator command line arguments ----------------------------------------- =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index cb1388049a..c6616ce05e 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -555,6 +555,12 @@ to produce an odd effect (rotating input but not displ= ay output). But this was never intended or documented behaviour, so we have dropped the options along with the machine models they were intended for. =20 +``-runas`` (removed in 10.0) +'''''''''''''''''''''''''''' + +Use ``-run-with user=3D..`` instead. + + User-mode emulator command line arguments ----------------------------------------- =20 diff --git a/system/vl.c b/system/vl.c index 0843b7ab49..3c5bd36d7d 100644 --- a/system/vl.c +++ b/system/vl.c @@ -3611,15 +3611,6 @@ void qemu_init(int argc, char **argv) /* Nothing to be parsed here. Especially, do not error out= below. */ break; #if defined(CONFIG_POSIX) - case QEMU_OPTION_runas: - warn_report("-runas is deprecated, use '-run-with user=3D.= ..' instead"); - if (!os_set_runas(optarg)) { - error_report("User \"%s\" doesn't exist" - " (and is not :)", - optarg); - exit(1); - } - break; case QEMU_OPTION_daemonize: os_set_daemonize(true); break; diff --git a/qemu-options.hx b/qemu-options.hx index cc694d3b89..7090d59f6f 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4976,19 +4976,6 @@ SRST ``-nodefaults`` option will disable all those default devices. ERST =20 -#ifndef _WIN32 -DEF("runas", HAS_ARG, QEMU_OPTION_runas, \ - "-runas user change to user id user just before starting the VM\n"= \ - " user can be numeric uid:gid instead\n", - QEMU_ARCH_ALL) -#endif -SRST -``-runas user`` - Immediately before starting guest execution, drop root privileges, - switching to the specified user. This option is deprecated, use - ``-run-with user=3D...`` instead. -ERST - DEF("prom-env", HAS_ARG, QEMU_OPTION_prom_env, "-prom-env variable=3Dvalue\n" " set OpenBIOS nvram variables\n", @@ -5176,7 +5163,7 @@ SRST =20 ``chroot=3Ddir`` can be used for doing a chroot to the specified direc= tory immediately before starting the guest execution. This is especially us= eful - in combination with -runas. + in combination with ``user=3D...``. =20 ``user=3Dusername`` or ``user=3Duid:gid`` can be used to drop root pri= vileges before starting guest execution. QEMU will use the ``setuid`` and ``se= tgid`` --=20 2.47.1