From nobody Wed Apr 9 10:36:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1735672058; cv=none; d=zohomail.com; s=zohoarc; b=mxzg1jYS7EXaEbIG+3P4rlbJ9RWg7l78XWZOAd+qxwt0WYS5l1KSXkcIk6SxjEkqQXK46tfaj+pml1GG4IHuWh0t4jbssBsgzoR6A/qPVNU360ep3BcdZv9rD3Q2O0nfVhJIOmXc99NoufhY5tZXaCc1hYKAUERneJ3HpyhpmCs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1735672058; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GAtXelESZqP9EpLglyIc26IsQk/mXnYos/ye7zC5LFE=; b=XSVGPRR4OhD/aiXqqblAFMqyT03/NDBnPXbYa7VYKiKre7mzCqvXDpVwG/qCI0wG8EQHjzaKbYog24EaqlXYOtlJHVC8MiMql2fctW2nL60Na04lbCP6QuJ3SEYqLSI+8Qi9pha255PloLVfoCOiPw/ljdOLo4JZ2gVX5mhoOqo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1735672058258424.1663937945676; Tue, 31 Dec 2024 11:07:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tShZh-0004Ia-Ot; Tue, 31 Dec 2024 14:06:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tShZg-0004IS-TZ for qemu-devel@nongnu.org; Tue, 31 Dec 2024 14:06:41 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tShZf-00083w-7k for qemu-devel@nongnu.org; Tue, 31 Dec 2024 14:06:40 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3862b364538so5871979f8f.1 for ; Tue, 31 Dec 2024 11:06:38 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4366127c488sm395913725e9.27.2024.12.31.11.06.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 31 Dec 2024 11:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735671997; x=1736276797; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GAtXelESZqP9EpLglyIc26IsQk/mXnYos/ye7zC5LFE=; b=e6C6G1RHQbsEgdiL9YKcK/ySQ43gJVVIVQFWBksWtvnhMLyrnabzqmot7lEIs6G6cD EGoPrXGgk//+VZ5TdMyeBWiwd126OFJLM9tHKJEoRbPfdIrGCrZeL7PQxYAbsLeAMf6N 7QabdYKENT4ur49dnwR4HzcqfTxw1ofdc5ZFEXuZEhdAv27WlHaYOz6warWnIbiTRHdA cJAY0TeWvHMkpQg1ZGg9GzVvnbbF+JASoAYuyhsS7mLAzQyKLgDQ5krnMrIZUhrvCEBV xOtt52g9MCXf7JlTvisxwZQPJGhcVrv59KLkJgG0QTAlU9wtaZOdVU3Wo55gaFsA4oHU vLBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735671997; x=1736276797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GAtXelESZqP9EpLglyIc26IsQk/mXnYos/ye7zC5LFE=; b=r+YVXTBHrXpkJVVKUy++BPWonOm1YVPj3EqZBrcGsv6JoMqw2Hts57XcRXv1OWw6b/ cM/kyTjhKPXIJyBovvNh2F21YwVq/vBGO/UqvhsPg6W4GwYkD1AzcdUkd41Dg5KnxoUS /AOyhIpGEzwwu4wLdmr51xFesFLDRzAbPDOuvZaK9kpkfViUA/uUW4JBCpbC/Fmo5VWD gs8NF81d9GUepuFFvn/gJfpAn35vCeNr8yreU+hxJV+ap7/Dof44kKxJhb0Wrlln+ooc lB/l6orMBTW7NWfq6sD739m1gKxp6K0R1RvZtc+gY/Efvnkii1hKskJYf3WCDmeLVmah Vwrw== X-Gm-Message-State: AOJu0YwyqyuvUSqeJlDw5e363+UfYCDVbDEvfFIg5xlg2fTYORSRJTA1 ULmAw4x9lfE4Al7yszBT+mxwV+HlKQy0ltA7DSYDaGoh7E2Ha2WS2Zv6pWWwwZfgKyeqR3Z5ZZZ PKc8= X-Gm-Gg: ASbGncsVrVo9UUk82+dlkzJEOBolo7fwMXSprYc6mcuNCYEvHJWz357bkj3n3zrSJPM Juv8mdwspVc/BRVhSMS9Zn92W2ltfih1V98c3m1G/9yA+IIwKwpw34HfNoGHhFw/Yw0G8LlV3G8 HXPv3ru3pPrm1wALK/OeLB5o5yNypc5kgOZoU12UTAtAo2DVDOkzJAscfpTlHKToyDZekoKOU5y 2WiM3SPgR8jkVv1F33oAt++r3fmZmpgxsaEQ4nks+I3luikBKY5/BgRdeEvEIqIbTos68QTyisA LXFetvewZ0GbV1V+saEMd6Vw797sqZg= X-Google-Smtp-Source: AGHT+IE3DIwtSg6CuX/wOrQmnkzUlQSocrZdkDNX4ilZX/fsmrntgn8kvwzSHjirCR2MmMUVFWXdDw== X-Received: by 2002:a05:6000:1862:b0:386:4244:15c7 with SMTP id ffacd0b85a97d-38a1a27499amr40080334f8f.25.1735671997224; Tue, 31 Dec 2024 11:06:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Helge Deller , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 3/6] hw/hppa: Reset vCPUs calling resettable_reset() Date: Tue, 31 Dec 2024 20:06:17 +0100 Message-ID: <20241231190620.24442-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241231190620.24442-1-philmd@linaro.org> References: <20241231190620.24442-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1735672058764019100 From: Helge Deller Rather than manually (and incompletely) resetting vCPUs, call resettable_reset() which will fully reset the vCPUs. Remove redundant assignations. Signed-off-by: Helge Deller Co-developed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/hppa/machine.c | 6 +++--- target/hppa/cpu.c | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 65259308e2e..8230f43e41c 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -655,12 +655,12 @@ static void hppa_machine_reset(MachineState *ms, Rese= tType type) for (i =3D 0; i < smp_cpus; i++) { CPUState *cs =3D CPU(cpu[i]); =20 + /* reset CPU */ + resettable_reset(OBJECT(cs), RESET_TYPE_COLD); + cpu_set_pc(cs, firmware_entry); cpu[i]->env.psw =3D PSW_Q; cpu[i]->env.gr[5] =3D CPU_HPA + i * 0x1000; - - cs->exception_index =3D -1; - cs->halted =3D 0; } =20 /* already initialized by machine_hppa_init()? */ diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index d784bcdd602..41538d39d62 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -204,6 +204,7 @@ static void hppa_cpu_reset_hold(Object *obj, ResetType = type) scc->parent_phases.hold(obj, type); } cs->exception_index =3D -1; + cs->halted =3D 0; =20 memset(env, 0, offsetof(CPUHPPAState, end_reset_fields)); =20 --=20 2.47.1