From nobody Wed Apr 9 05:58:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1735053596; cv=none; d=zohomail.com; s=zohoarc; b=herYrEsiTcLwFfN3dMvGbLvgTkstY+A+gul6mC4Id43uHW33bUUSnjMgaxb7Rc1ffZxIR+AarnNuf0WFa1PIHIVI/w1vanenkcn9yn9QdF1GqkFTKw+WkdKKO0Eclmmqc2dh4PXBgUFQPxsbf3LHwvLLQzAgziozSByEI04GWjA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1735053596; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=egtClDkN06NWpvA3BUK2Um5Rud+el5tyQBVjbzMUUQk=; b=OHXUGyGAl0cT4wTYHZG+VEeqhYHaWi2PUDOgLqsIL1LXBbVJFMOhX6kgEwdhzdWSpRtENK/pkDBv1dfyhqSiTeZyu5LUsLXAfx1CZ7vdJ+3XUyiWGraNOXgN1DiRN5ahU2TqYucvNH3UjBwhS1sOt77CNkhxEDQs9njh1HEkUlM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 173505359609319.618717398582817; Tue, 24 Dec 2024 07:19:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ6eX-0008Mp-PR; Tue, 24 Dec 2024 10:16:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ6e9-0007ux-Dk for qemu-devel@nongnu.org; Tue, 24 Dec 2024 10:16:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ6e8-00046F-0R for qemu-devel@nongnu.org; Tue, 24 Dec 2024 10:16:33 -0500 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-BAr2eX90PSegq2bsuRcr_A-1; Tue, 24 Dec 2024 10:16:26 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2510E1956048; Tue, 24 Dec 2024 15:16:24 +0000 (UTC) Received: from corto.redhat.com (unknown [10.39.192.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C7EC03000197; Tue, 24 Dec 2024 15:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735053390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egtClDkN06NWpvA3BUK2Um5Rud+el5tyQBVjbzMUUQk=; b=bXDaFlkv+szKRT85jLF4ZEFWp2JiULVp+rP03puJXBqYfgjs9WEbSGlxhywtF7Xxu+D5wh /0jMRL0sy804IYzxqN0eT05PgFbDqC7InmXR4sjuKe0yksabQ8nt5/8DqkVm0cVKh504cg E2ddIuNJSkxsNR096pqRp1VS4Ba9LHk= X-MC-Unique: BAr2eX90PSegq2bsuRcr_A-1 X-Mimecast-MFC-AGG-ID: BAr2eX90PSegq2bsuRcr_A From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Alex Williamson , Avihai Horon , Hyman Huang , Joao Martins , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 15/17] system/dirtylimit: Don't use migration_is_active() Date: Tue, 24 Dec 2024 16:15:45 +0100 Message-ID: <20241224151547.386529-16-clg@redhat.com> In-Reply-To: <20241224151547.386529-1-clg@redhat.com> References: <20241224151547.386529-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.133, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1735053596321116600 From: Avihai Horon vcpu_dirty_rate_stat_collect() uses migration_is_active() to detect whether migration is running or not, in order to get the correct dirty rate period value. However, recently there has been an effort to simplify the migration status API and reduce it to a single migration_is_running() function. To accommodate this, and since the same functionality can be achieved with migration_is_running(), use it instead of migration_is_active(). Signed-off-by: Avihai Horon Reviewed-by: Hyman Huang Tested-by: Joao Martins Link: https://lore.kernel.org/r/20241218134022.21264-6-avihaih@nvidia.com Signed-off-by: C=C3=A9dric Le Goater --- system/dirtylimit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/system/dirtylimit.c b/system/dirtylimit.c index d94b994bd81bd44b95f120a53ce83b6809e60297..7c071248bbf92389977dab8b7d4= 808c9f57af630 100644 --- a/system/dirtylimit.c +++ b/system/dirtylimit.c @@ -80,8 +80,7 @@ static void vcpu_dirty_rate_stat_collect(void) int i =3D 0; int64_t period =3D DIRTYLIMIT_CALC_TIME_MS; =20 - if (migrate_dirty_limit() && - migration_is_active()) { + if (migrate_dirty_limit() && migration_is_running()) { period =3D migrate_vcpu_dirty_limit_period(); } =20 --=20 2.47.1