From nobody Tue Dec 24 12:23:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1734712013; cv=none; d=zohomail.com; s=zohoarc; b=es5ST4U+Y8M9Z52O26w6xSvie7tMI2AGsyCyqpOAwP5mtvwkS4HgYJr9n/I3vcCKZQ5y/bK24PxSmjUDupB7Iy/uKiOu5s4N1EaqkwIyE05s9vhLwx5YxYFbdr4/Nrg9OHVcJ4uvZmt3prsDdldMRHu5OMvueQd7rBz2Q8FznK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734712013; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=z2q6hztruFV/rEotOSts69LdsvL+mRG0yRstG2pV9uo=; b=Gzt+Klp7Uq9xSilP1PFNAPbdFnGMV/ag9EAjRQXEbGRGSIv/2j5B/ix8N6e429Uyp1CFUlI5xLPX4N5hnF59qVGLwmeV+1Q65A7ZGxSPNdz16CQOgTG9m+GwxdfvAafsRv9PWQcHmBfUJI0wc2IFnopjOslN+nl+7KiQlsbPi/Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734712013896809.0018231695658; Fri, 20 Dec 2024 08:26:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOfjM-0005df-Lg; Fri, 20 Dec 2024 11:20:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOfj7-00058E-Ug for qemu-devel@nongnu.org; Fri, 20 Dec 2024 11:19:48 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOfj4-0008Ie-No for qemu-devel@nongnu.org; Fri, 20 Dec 2024 11:19:45 -0500 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3862d6d5765so1334550f8f.3 for ; Fri, 20 Dec 2024 08:19:42 -0800 (PST) Received: from localhost.localdomain ([78.196.4.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e1a1sm4339770f8f.69.2024.12.20.08.19.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Dec 2024 08:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734711581; x=1735316381; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z2q6hztruFV/rEotOSts69LdsvL+mRG0yRstG2pV9uo=; b=TEBo3kwIaHTyzVIVOEv0Q3X7HZA6oYy6AhqaSjF0G/lVxfY6WmhJnmQ5KQltSZeiwZ g2CX6gBrbMj3EfdQfhEhozT9j34CxJ+Hc3yICURXDMlzpzJOXe5IfRqs1A2/O7vBt2Np 4L4FID3Bv748JxvNLbtdX9yENeBfpgQkyM79hFJgeb+uhik1dEBQdD928mbtsdkJ8bCP h8gz6/Wfz+yMd6XD1p2c07uV5BE2LFTRGHmvC9L114+GvVRxnzPgPoe+jKPbzh9aCU1v PoH+tJG/j7AfzO1g+/kquXYgBP7uok397S/20X4/iqhcd+wMEoh1YLrMlMSZrawFh0kW cXtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734711581; x=1735316381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2q6hztruFV/rEotOSts69LdsvL+mRG0yRstG2pV9uo=; b=W14vA20eZnbZ3EQTOJcJRQN2miY+9xouHctxbHp75Z/swOQkL0JJZqYOGS9EowTDQG IXWTji7eFx2dzIz9LraeyZwdHDwBXnKQ83Q4eGg+nG/JYEf8pouVh+sRJhsbok4NYe9E 36YY853GvJa4sFpVxkbfqW5RHi9NaHMdRbDoNSZR1H9jZT9/R2gZuw2Yn1OHa6Vt5FRa stEpyKH9PBG10J4TIjmVY5gpqRamV9NycASZwDA+dL2p5WJwn8dTCKUfix+pSCewtoZW NYlmrzN4Flr5qbhRb9B0sKqtv/AzX8NUU3zMvEebtr7raWGVFh3/3KFN7CqsvF7ndbsZ IGrQ== X-Gm-Message-State: AOJu0YxSqo002RukP/hgjss4anMY4Xe/J8BBpwXwgPhgFRpLuuHHGaPW IWfAWgZbk0pJlpHXJu+giULDokNHiIBHUe7ZZsgz6kz/B9naB+cFMbcplIk6KGKmP6oYSTFufhL d X-Gm-Gg: ASbGncv/9mdiVSPHWj/iyJMWjCXwp2d11LVUxDFZvJvk0+5iyIz3dLj1XdTyBMlWEpr JykBAEC89K8ZaRxwcKnSAoGbqXl6Q/AFxK8gyWqec9AKcr7A8y09Ep2XnifEMObT+m6qsdwbaRt 9gkjH8tCtL6qNPe6/UtdfippUEz4xdvgPhfZV7HTzWSENHuob48192i8HInWj5nHUVdl7nqAqs1 z7QdYuXOPVtmmtEwT5edhQokYyZ/wpfI2TZQg6MnMTQHq2IqJpQ7pyGCbv7PgzqjLuiGoJEazI= X-Google-Smtp-Source: AGHT+IGGVsqdH+Q181SXn/LFx9R2IMswebc4X+iz8QCUOts8uxi300c/tOUbN9u5rPwZjNijnLxVJQ== X-Received: by 2002:a05:6000:4607:b0:385:f13c:570f with SMTP id ffacd0b85a97d-38a22201424mr3385514f8f.33.1734711580874; Fri, 20 Dec 2024 08:19:40 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Richard Henderson Subject: [PULL 50/59] accel/tcg: Include missing 'exec/translation-block.h' header Date: Fri, 20 Dec 2024 17:15:41 +0100 Message-ID: <20241220161551.89317-51-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241220161551.89317-1-philmd@linaro.org> References: <20241220161551.89317-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1734712016237116600 TB compile flags, tb_page_addr_t type, tb_cflags() and few other methods are defined in "exec/translation-block.h". All these files don't include "exec/translation-block.h" but include "exec/exec-all.h" which include it. Explicitly include "exec/translation-block.h" to be able to remove it from "exec/exec-all.h" later when it won't be necessary. Otherwise we'd get errors such: accel/tcg/internal-target.h:59:20: error: a parameter list without types = is only allowed in a function definition 59 | void tb_lock_page0(tb_page_addr_t); | ^ accel/tcg/tb-hash.h:64:23: error: unknown type name 'tb_page_addr_t' 64 | uint32_t tb_hash_func(tb_page_addr_t phys_pc, vaddr pc, | ^ accel/tcg/tcg-accel-ops.c:62:36: error: use of undeclared identifier 'CF_= CLUSTER_SHIFT' 62 | cflags =3D cpu->cluster_index << CF_CLUSTER_SHIFT; | ^ accel/tcg/watchpoint.c:102:47: error: use of undeclared identifier 'CF_NO= IRQ' 102 | cpu->cflags_next_tb =3D 1 | CF_NOIRQ | curr_c= flags(cpu); | ^ target/i386/helper.c:536:28: error: use of undeclared identifier 'CF_PCRE= L' 536 | if (tcg_cflags_has(cs, CF_PCREL)) { | ^ target/rx/cpu.c:51:21: error: incomplete definition of type 'struct Trans= lationBlock' 51 | cpu->env.pc =3D tb->pc; | ~~^ system/physmem.c:2977:9: error: call to undeclared function 'tb_invalidat= e_phys_range'; ISO C99 and later do not support implicit function declarati= ons [-Wimplicit-function-declaration] 2977 | tb_invalidate_phys_range(addr, addr + length - 1); | ^ plugins/api.c:96:12: error: call to undeclared function 'tb_cflags'; ISO = C99 and later do not support implicit function declarations [-Wimplicit-fun= ction-declaration] 96 | return tb_cflags(tcg_ctx->gen_tb) & CF_MEMI_ONLY; | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-Id: <20241114011310.3615-5-philmd@linaro.org> --- accel/tcg/internal-target.h | 1 + accel/tcg/tb-hash.h | 1 + target/arm/tcg/translate.h | 1 + cpu-target.c | 1 + linux-user/elfload.c | 1 + plugins/api.c | 1 + system/physmem.c | 1 + target/alpha/cpu.c | 1 + target/alpha/translate.c | 1 + target/arm/helper.c | 1 + target/avr/translate.c | 1 + target/hppa/translate.c | 1 + target/i386/tcg/tcg-cpu.c | 1 + target/i386/tcg/translate.c | 1 + target/m68k/translate.c | 1 + target/microblaze/translate.c | 1 + target/openrisc/translate.c | 1 + target/ppc/translate.c | 1 + target/riscv/translate.c | 1 + target/rx/translate.c | 1 + target/s390x/tcg/translate.c | 1 + target/sh4/translate.c | 1 + target/sparc/translate.c | 1 + target/tricore/translate.c | 1 + target/xtensa/translate.c | 1 + 25 files changed, 25 insertions(+) diff --git a/accel/tcg/internal-target.h b/accel/tcg/internal-target.h index 3ed81e740d3..a664be02cc7 100644 --- a/accel/tcg/internal-target.h +++ b/accel/tcg/internal-target.h @@ -10,6 +10,7 @@ #define ACCEL_TCG_INTERNAL_TARGET_H =20 #include "exec/exec-all.h" +#include "exec/translation-block.h" #include "tb-internal.h" =20 /* diff --git a/accel/tcg/tb-hash.h b/accel/tcg/tb-hash.h index a0c61f25cda..a5382f460dc 100644 --- a/accel/tcg/tb-hash.h +++ b/accel/tcg/tb-hash.h @@ -22,6 +22,7 @@ =20 #include "exec/cpu-defs.h" #include "exec/exec-all.h" +#include "exec/translation-block.h" #include "qemu/xxhash.h" #include "tb-jmp-cache.h" =20 diff --git a/target/arm/tcg/translate.h b/target/arm/tcg/translate.h index 9b9abf19925..2d37d7c9f21 100644 --- a/target/arm/tcg/translate.h +++ b/target/arm/tcg/translate.h @@ -6,6 +6,7 @@ #include "tcg/tcg-op-gvec.h" #include "exec/exec-all.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/helper-gen.h" #include "internals.h" #include "cpu-features.h" diff --git a/cpu-target.c b/cpu-target.c index 7a2efa890c4..beec7737907 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -42,6 +42,7 @@ #include "exec/cpu-common.h" #include "exec/exec-all.h" #include "exec/tb-flush.h" +#include "exec/translation-block.h" #include "exec/log.h" #include "hw/core/accel-cpu.h" #include "trace/trace-root.h" diff --git a/linux-user/elfload.c b/linux-user/elfload.c index effd3ab47ef..a2c152e5ad1 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -10,6 +10,7 @@ #include "user/tswap-target.h" #include "user/page-protection.h" #include "exec/page-protection.h" +#include "exec/translation-block.h" #include "user/guest-base.h" #include "user-internals.h" #include "signal-common.h" diff --git a/plugins/api.c b/plugins/api.c index 24ea64e2de5..4110cfaa237 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -43,6 +43,7 @@ #include "tcg/tcg.h" #include "exec/exec-all.h" #include "exec/gdbstub.h" +#include "exec/translation-block.h" #include "exec/translator.h" #include "disas/disas.h" #include "plugin.h" diff --git a/system/physmem.c b/system/physmem.c index 1459dd15eb5..c76503aea82 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -34,6 +34,7 @@ #include "exec/exec-all.h" #include "exec/page-protection.h" #include "exec/target_page.h" +#include "exec/translation-block.h" #include "hw/qdev-core.h" #include "hw/qdev-properties.h" #include "hw/boards.h" diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 70f67e6fd4e..9fa506bff9f 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -24,6 +24,7 @@ #include "qemu/qemu-print.h" #include "cpu.h" #include "exec/exec-all.h" +#include "exec/translation-block.h" #include "fpu/softfloat.h" =20 =20 diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 660788d5c3c..629ff3cde92 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -26,6 +26,7 @@ #include "exec/helper-proto.h" #include "exec/helper-gen.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" =20 #define HELPER_H "helper.h" diff --git a/target/arm/helper.c b/target/arm/helper.c index 449e69a6e39..5b595f951b4 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -20,6 +20,7 @@ #include "qemu/crc32c.h" #include "qemu/qemu-print.h" #include "exec/exec-all.h" +#include "exec/translation-block.h" #include /* for crc32 */ #include "hw/irq.h" #include "system/cpu-timers.h" diff --git a/target/avr/translate.c b/target/avr/translate.c index 2d518921159..f13b997f8d9 100644 --- a/target/avr/translate.c +++ b/target/avr/translate.c @@ -23,6 +23,7 @@ #include "tcg/tcg.h" #include "cpu.h" #include "exec/exec-all.h" +#include "exec/translation-block.h" #include "tcg/tcg-op.h" #include "exec/helper-proto.h" #include "exec/helper-gen.h" diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 51c1762435a..d13f80fe3e4 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -27,6 +27,7 @@ #include "exec/helper-proto.h" #include "exec/helper-gen.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" =20 #define HELPER_H "helper.h" diff --git a/target/i386/tcg/tcg-cpu.c b/target/i386/tcg/tcg-cpu.c index cca19cd40e8..231ecac37d1 100644 --- a/target/i386/tcg/tcg-cpu.c +++ b/target/i386/tcg/tcg-cpu.c @@ -22,6 +22,7 @@ #include "helper-tcg.h" #include "qemu/accel.h" #include "hw/core/accel-cpu.h" +#include "exec/translation-block.h" =20 #include "tcg-cpu.h" =20 diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index ea7995106fb..57e83873934 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -21,6 +21,7 @@ #include "qemu/host-utils.h" #include "cpu.h" #include "exec/exec-all.h" +#include "exec/translation-block.h" #include "tcg/tcg-op.h" #include "tcg/tcg-op-gvec.h" #include "exec/translator.h" diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ad3ce345014..077151c62d9 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -21,6 +21,7 @@ #include "qemu/osdep.h" #include "cpu.h" #include "exec/exec-all.h" +#include "exec/translation-block.h" #include "tcg/tcg-op.h" #include "qemu/log.h" #include "qemu/qemu-print.h" diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 4beaf69e76a..d53995c26d1 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -26,6 +26,7 @@ #include "exec/helper-proto.h" #include "exec/helper-gen.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "qemu/qemu-print.h" =20 #include "exec/log.h" diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index ca566847cb4..028ba66631f 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -26,6 +26,7 @@ #include "qemu/bitops.h" #include "qemu/qemu-print.h" #include "exec/translator.h" +#include "exec/translation-block.h" =20 #include "exec/helper-proto.h" #include "exec/helper-gen.h" diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 47ca50a064b..8ab87f42d67 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -30,6 +30,7 @@ #include "exec/helper-gen.h" =20 #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" #include "qemu/atomic128.h" #include "spr_common.h" diff --git a/target/riscv/translate.c b/target/riscv/translate.c index bccaf8e89a6..5fedde363f7 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -25,6 +25,7 @@ #include "exec/helper-gen.h" =20 #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" #include "semihosting/semihost.h" =20 diff --git a/target/rx/translate.c b/target/rx/translate.c index 9aade2b6e5c..4f43654bad0 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -25,6 +25,7 @@ #include "exec/helper-proto.h" #include "exec/helper-gen.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" =20 #define HELPER_H "helper.h" diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index bcfff40b255..e78815c4f7f 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -40,6 +40,7 @@ #include "exec/helper-gen.h" =20 #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" #include "qemu/atomic128.h" =20 diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 53b092175dc..f076da9bac8 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -23,6 +23,7 @@ #include "tcg/tcg-op.h" #include "exec/helper-proto.h" #include "exec/helper-gen.h" +#include "exec/translation-block.h" #include "exec/translator.h" #include "exec/log.h" #include "qemu/qemu-print.h" diff --git a/target/sparc/translate.c b/target/sparc/translate.c index ac063772310..9be26c804ed 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -27,6 +27,7 @@ #include "tcg/tcg-op-gvec.h" #include "exec/helper-gen.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" #include "fpu/softfloat.h" #include "asi.h" diff --git a/target/tricore/translate.c b/target/tricore/translate.c index 4a12d2ca191..2b67395c09e 100644 --- a/target/tricore/translate.c +++ b/target/tricore/translate.c @@ -30,6 +30,7 @@ =20 #include "tricore-opcodes.h" #include "exec/translator.h" +#include "exec/translation-block.h" #include "exec/log.h" =20 #define HELPER_H "helper.h" diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index f4da4a40f94..3c62c99b4fe 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -37,6 +37,7 @@ #include "qemu/qemu-print.h" #include "semihosting/semihost.h" #include "exec/translator.h" +#include "exec/translation-block.h" =20 #include "exec/helper-proto.h" #include "exec/helper-gen.h" --=20 2.47.1