From nobody Tue Dec 24 13:11:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1734625688; cv=none; d=zohomail.com; s=zohoarc; b=aWUpniJCaCeeELKbadE7n1iqBrWeR8uA4q7RFrqgRhnJ0GesckWPh55I9gvlUIbC6HswtAthrkjMFVSPYxjoNT3T5LSL260c8jYbtJ42i2+vgr0SO8iAaljFlq1PMREyhufkWm63QuyJhlA+VUs6YIuehDAvBCXIiDP5ZymEvIk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734625688; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QndkQAdv+aZOEQr2b2o41BTTLOjnawhbhJJcyyz1yzo=; b=BqZGxvuKa3sUztAMAbI07P4CtCq/ml0IhrNhWrq7GhQjNypF7AfTxnbpwjVUZV4r6sWa1meExpuVo9J5O/k6KGYvKkLrlq+AkaIFEfNFjOuQNJoSrGCuH4Cs17CROcCIyTaE7YXvpO6rlpShVmkZ3a/G59e8/t5hO94s1HtiVvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734625688492198.73173755684195; Thu, 19 Dec 2024 08:28:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOJGx-0004jb-SJ; Thu, 19 Dec 2024 11:21:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOHiW-000395-3s for qemu-devel@nongnu.org; Thu, 19 Dec 2024 09:41:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOHiU-0002MA-Ia for qemu-devel@nongnu.org; Thu, 19 Dec 2024 09:41:31 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-Q3qhqaLkP5-8ywzxRwBnwg-1; Thu, 19 Dec 2024 09:41:23 -0500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361c040ba8so5411305e9.1 for ; Thu, 19 Dec 2024 06:41:22 -0800 (PST) Received: from localhost (p200300cbc7496600b73a466ce6100686.dip0.t-ipconnect.de. [2003:cb:c749:6600:b73a:466c:e610:686]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43656b11aecsm53403925e9.23.2024.12.19.06.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 06:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734619289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QndkQAdv+aZOEQr2b2o41BTTLOjnawhbhJJcyyz1yzo=; b=fboTz2aKOBPFD893G/856eT/1ehnF9yoXSpVF6Vzslw0WY/pzm1nxRNUitTbr0qAG3qNRI vtmilJ6tSr/waVA7L7Z7TqcVnjKPV6+viQxWlixurICeBu/Pye+jsM4kDkIc1Ii4EyKe7Y cemAfJDL3YhEIpVRVv+euieLggqpJNI= X-MC-Unique: Q3qhqaLkP5-8ywzxRwBnwg-1 X-Mimecast-MFC-AGG-ID: Q3qhqaLkP5-8ywzxRwBnwg X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734619282; x=1735224082; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QndkQAdv+aZOEQr2b2o41BTTLOjnawhbhJJcyyz1yzo=; b=CuG7UfZHmA/LdYlQOAStksFpmCSdCZYY7HM1w/N6gNYf+Aa6puJfj6KLIXxvCZjElG AwvPusoJo6QoIGqLbaUlUvKX0nyasI2aU8fFEwtMeTplKwXSxIq6TozoYjHGQ9TU6IVJ rcroDvh9I10p+uyv8X6iTa9qA0+eGVUxnMJE+D2CWa/gE+n9B9nBOIPVRWIIgVrxqYIO wwKYzOYUskZshpUegPOelvsA6R5Ny2c/lTuDJB4ikFNU4BPq58gi2yqvRngmCU38z7gq JflTlhfEg1stCTAr5UTfU4aZT2AVTbNZo0VHKn5IE9ppC+92qKq3Gcx8EqsusEf5Gga3 AhyA== X-Gm-Message-State: AOJu0YyqOCz0cA2ZE+GruLLJQ9hw0fMxMMPzokig0zWDEFMoY7S1TCGC e/xn1erD6xQVcmyyHzcLuIKfp866LjPS9/hEg58+utx3THpKdHthpuvmeU8IPnHbTDWVbQ2r3cp 0dej5gNBXiGSQ9O3Quh/F9iM4lTZ3RCSEqlQ9+c5jJBP429/x9o4GWyS0cOTKQz+Fj/+a47pHjA /afixStJL//+mKI9WDNh2TCSnhy0813KARf+Q= X-Gm-Gg: ASbGnctlpgxoAcFvyBvdCCZBWaThr0dvZhwVJGtxJsu6G1GMagBr6JMSys5iMOg+o1L SXBk9OZLkXFKJmAgiQEZPtkzLQiZ3afIpBT6R2sRYygTk7PQtIwkvbbG8Su6LbIqszzxaMQltYV u7Emxd6Qu+Wbt32/id8g1YSvx7BNB+g1RKOAuFS0xjCNLbgqhdjhqUmwG+Ikkb1+RnFYCB0sfls 3xlTiLy3hlAxMFfrDEoMci+ENgnh6W4RNny1aQjoiHDt8e/PNbaN8K9ojdorTo4W2RCMsTYgCx3 DtXHvkdI+3n41QwFRRQaMvyyhBenPbpT2vcLNoRz X-Received: by 2002:a05:6000:154c:b0:385:decf:52bc with SMTP id ffacd0b85a97d-38a19b1680cmr3294883f8f.32.1734619281825; Thu, 19 Dec 2024 06:41:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6aZO+nDAEA5YjakspU6Sj9NKtxSKEoLpfxqN6jXjYOygAUX94hJOesqUsED3r3p+eGw93Og== X-Received: by 2002:a05:6000:154c:b0:385:decf:52bc with SMTP id ffacd0b85a97d-38a19b1680cmr3294845f8f.32.1734619281426; Thu, 19 Dec 2024 06:41:21 -0800 (PST) From: David Hildenbrand To: qemu-devel@nongnu.org Cc: David Hildenbrand , Paolo Bonzini , Thomas Huth , Halil Pasic , Christian Borntraeger , Eric Farman , Richard Henderson , Nina Schoetterl-Glausch , Heiko Carstens , Ilya Leoshkevich , Janosch Frank , "Michael S. Tsirkin" , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes Date: Thu, 19 Dec 2024 15:41:02 +0100 Message-ID: <20241219144115.2820241-2-david@redhat.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241219144115.2820241-1-david@redhat.com> References: <20241219144115.2820241-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=dhildenb@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.116, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1734625690388116600 Content-Type: text/plain; charset="utf-8" KVM is not happy when starting a VM with weird RAM sizes: # qemu-system-s390x --enable-kvm --nographic -m 1234K qemu-system-s390x: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION failed, slot=3D0, start=3D0x0, size=3D0x244000: Invalid argument kvm_set_phys_mem: error registering slot: Invalid argument Aborted (core dumped) Let's handle that in a better way by rejecting such weird RAM sizes right from the start: # qemu-system-s390x --enable-kvm --nographic -m 1234K qemu-system-s390x: ram size must be multiples of 1 MiB Message-ID: <20241008105455.2302628-2-david@redhat.com> Acked-by: Michael S. Tsirkin Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Acked-by: Janosch Frank Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 67ae34aead..f2a17ecace 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -180,6 +180,17 @@ static void s390_memory_init(MemoryRegion *ram) { MemoryRegion *sysmem =3D get_system_memory(); =20 + if (!QEMU_IS_ALIGNED(memory_region_size(ram), 1 * MiB)) { + /* + * SCLP cannot possibly expose smaller granularity right now and K= VM + * cannot handle smaller granularity. As we don't support NUMA, the + * region size directly corresponds to machine->ram_size, and the = region + * is a single RAM memory region. + */ + error_report("ram size must be multiples of 1 MiB"); + exit(EXIT_FAILURE); + } + /* allocate RAM for core */ memory_region_add_subregion(sysmem, 0, ram); =20 --=20 2.47.1