From nobody Tue Apr 15 01:20:42 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=quarantine dis=none) header.from=zabka.it
ARC-Seal: i=1; a=rsa-sha256; t=1734556062; cv=none;
d=zohomail.com; s=zohoarc;
b=S2GwBC05H1aJjm1VlxfdoGHAPxtMV6d1buMAlGhAKmDl3rRwLmLiP0ahEwOcIue2/OMQMLWAqp2fohdbHhMFX/xJ3DlkW4YYiZj+URvt1SiqK9pF/6VukFtSf5txbsk565AUA2drf2F8tlGNr6DjVydKCkf3I+qUxO/glDDJRAk=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1734556062;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=5IHdsE4vyhVCTmft2b7H4Lze6ALZhpG3BZSBWwvudSU=;
b=iPnH6S/2HEo/oLD8nShr7nE0/A3qSf7FgkQbaTmalf5rDHmZ3w02qjlVX1GLnsOQgx0nnFWx6vjrJp0Yre4+f1F1ElpuuHFD0VmJm2habz7eH08m5FxQAI9qThEnQYDcq3LHahQ0PywZLEp9Ka/4p6zQhwi9/GMqfm06JToVa6k=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<git@zabka.it> (p=quarantine dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1734556062225597.4625745568148;
Wed, 18 Dec 2024 13:07:42 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tO1Fl-0000jE-QS; Wed, 18 Dec 2024 16:06:45 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <git@zabka.it>) id 1tNzpQ-0002Rn-43
for qemu-devel@nongnu.org; Wed, 18 Dec 2024 14:35:29 -0500
Received: from out-170.mta0.migadu.com ([91.218.175.170])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <git@zabka.it>) id 1tNzpN-0004pD-WF
for qemu-devel@nongnu.org; Wed, 18 Dec 2024 14:35:27 -0500
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zabka.it; s=key1;
t=1734550518;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=5IHdsE4vyhVCTmft2b7H4Lze6ALZhpG3BZSBWwvudSU=;
b=eo6JJ82+o4QWs8b/sLjnIs9doZMywE9OEdwq9lOVgYgrKm79vaA/cuz4uC5kOlyvofJ4sD
ExTtt8RFkZhQn4om1GC29N7jPe7DIkCYkSEeJxxJzTbQnvYEFWWWbSG3dDaY8bbQKd8X/C
ulKbkL7DMrcG3lxHTkfsOS85gtsyjuU=
From: Stefan Zabka <git@zabka.it>
To: qemu-devel@nongnu.org
Cc: Stefan Zabka <git@zabka.it>, Paolo Bonzini <pbonzini@redhat.com>,
Peter Xu <peterx@redhat.com>, David Hildenbrand <david@redhat.com>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>
Subject: [PATCH] physmem: allow cpu_memory_rw_debug to write to MMIO devices
Date: Wed, 18 Dec 2024 20:31:53 +0100
Message-ID: <20241218193153.151578-1-git@zabka.it>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=91.218.175.170; envelope-from=git@zabka.it;
helo=out-170.mta0.migadu.com
X-Spam_score_int: -26
X-Spam_score: -2.7
X-Spam_bar: --
X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Mailman-Approved-At: Wed, 18 Dec 2024 16:06:44 -0500
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @zabka.it)
X-ZM-MESSAGEID: 1734556063473116600
Content-Type: text/plain; charset="utf-8"
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/213
Signed-off-by: Stefan Zabka <git@zabka.it>
---
system/physmem.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/system/physmem.c b/system/physmem.c
index dc1db3a384..53cdccefcb 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -3556,6 +3556,7 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr,
hwaddr phys_addr;
vaddr l, page;
uint8_t *buf =3D ptr;
+ bool is_memcpy_access;
=20
cpu_synchronize_state(cpu);
while (len > 0) {
@@ -3574,11 +3575,24 @@ int cpu_memory_rw_debug(CPUState *cpu, vaddr addr,
l =3D len;
phys_addr +=3D (addr & ~TARGET_PAGE_MASK);
if (is_write) {
- res =3D address_space_write_rom(cpu->cpu_ases[asidx].as, phys_=
addr,
- attrs, buf, l);
+ /* if ram/rom region we access the memory
+ via memcpy instead of via the cpu */
+ hwaddr mr_len, addr1;
+ AddressSpace *as =3D cpu->cpu_ases[asidx].as;
+ MemoryRegion *mr =3D address_space_translate(as, phys_addr, &a=
ddr1, &mr_len, is_write, attrs);
+
+ is_memcpy_access =3D memory_region_is_ram(mr) || memory_region=
_is_romd(mr);
+ if(!is_memcpy_access) {
+ l =3D memory_access_size(mr, l, addr1);
+ }
+ } else {
+ is_memcpy_access =3D false;
+ }
+
+ if (is_write && is_memcpy_access) {
+ res =3D address_space_write_rom(cpu->cpu_ases[asidx].as, phys_=
addr, attrs, buf, l);
} else {
- res =3D address_space_read(cpu->cpu_ases[asidx].as, phys_addr,
- attrs, buf, l);
+ res =3D address_space_rw(cpu->cpu_ases[asidx].as, phys_addr, a=
ttrs, buf, l, is_write);
}
if (res !=3D MEMTX_OK) {
return -1;
--=20
2.47.1