From nobody Sat May 10 18:10:09 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass header.i=@intel.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=intel.com
ARC-Seal: i=1; a=rsa-sha256; t=1734513327; cv=none;
d=zohomail.com; s=zohoarc;
b=e4A47fJsZYjsA70Sk0bDBv1Dm3TcWk4ceywIAUTmtlX3W1grJcxM79mCAI8qejX2ceoUtKFHl1ZFZDyjWAuXzFDUtQ/PiANz75JwkF70RcE0IuRgRD2etieEtWT3e+38OVQkSONKFpL2peKATZLCYQMKvG95nbh22e4s8TLz/TA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1734513327;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=o523wQV/s1OmvJkOkKi+gan7a/BWU7TVtm7aCcn+5bw=;
b=D2dl2xNuxv3A0gDsVcTM7fkd6epEcJeH948wdy1NpG4SJsd2PY05KDUD7ixkrfITdBc34zdNUBDGFb1ynWvn+yX8CUl2t8+04BwoDI27BKYPj/62WIROmcSbUyE6Zk/POI1ShfrBFl8Z2L67+178oWiCVUfxVCYfvkL3I0ri2SA=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass header.i=@intel.com;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<yuan1.liu@intel.com> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1734513327262168.57577434007612;
Wed, 18 Dec 2024 01:15:27 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tNq8U-0006ZH-94; Wed, 18 Dec 2024 04:14:30 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <yuan1.liu@intel.com>)
id 1tNq8S-0006YG-EA
for qemu-devel@nongnu.org; Wed, 18 Dec 2024 04:14:28 -0500
Received: from mgamail.intel.com ([192.198.163.13])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <yuan1.liu@intel.com>)
id 1tNq8P-0001ms-A3
for qemu-devel@nongnu.org; Wed, 18 Dec 2024 04:14:28 -0500
Received: from fmviesa002.fm.intel.com ([10.60.135.142])
by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Dec 2024 01:14:21 -0800
Received: from sae-gw02.sh.intel.com (HELO localhost) ([10.239.45.110])
by fmviesa002.fm.intel.com with ESMTP; 18 Dec 2024 01:14:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1734513266; x=1766049266;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=SsQyQYlE/+wDejDYWwjUjjhhdveMqSUSALy6nEYsHk4=;
b=Bi3HgeqEm4i8a/0dbakiixY6kjXUX6aFiFSE0Q2+f/jf1wLTDYzTGS3k
hAMud8vHrPWJ42pwyzoCevft+0OD+6EzyaDYHDfRTDqRPw6awmCtZGBYM
OagxMOlog4WwX6MKtr+ec6k1EyYyOC+YInJT0YecV6J+M4CYVFGx52EeO
jL/EKRPzw+ZxNxuzby9vSWrKFMUKA6slaE9q9wc80leNpxwCjknR1Y3y3
mVxO5PdSf9UdARuB4Y0homIafen9IDn6++SVi6VD+OMi+IvYjKwxEyo5m
gPULXvK3Kckki2V8GKpcwaac1met0asrJugqD4mxtxNvvu1jYAT32xqeB Q==;
X-CSE-ConnectionGUID: QkvvU8wuT7yqV8W6I4D+Yw==
X-CSE-MsgGUID: VBEUOL34Rhu5HK0TjIUf3g==
X-IronPort-AV: E=McAfee;i="6700,10204,11289"; a="37815606"
X-IronPort-AV: E=Sophos;i="6.12,244,1728975600"; d="scan'208";a="37815606"
X-CSE-ConnectionGUID: oF0LLJ6TRRKuWRzpfqnV8w==
X-CSE-MsgGUID: STAJwx1ISMKrq9DMLCYmWg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="121066402"
From: Yuan Liu <yuan1.liu@intel.com>
To: peterx@redhat.com,
farosas@suse.de
Cc: qemu-devel@nongnu.org, yuan1.liu@intel.com, jason.zeng@intel.com,
yichen.wang@bytedance.com
Subject: [PATCH 2/3] multifd: bugfix for incorrect migration data with QPL
compression
Date: Wed, 18 Dec 2024 17:14:12 +0800
Message-ID: <20241218091413.140396-3-yuan1.liu@intel.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20241218091413.140396-1-yuan1.liu@intel.com>
References: <20241218091413.140396-1-yuan1.liu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=192.198.163.13;
envelope-from=yuan1.liu@intel.com;
helo=mgamail.intel.com
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,
DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @intel.com)
X-ZM-MESSAGEID: 1734513329286116600
Content-Type: text/plain; charset="utf-8"
When QPL compression is enabled on the migration channel and the same
dirty page changes from a normal page to a zero page in the iterative
memory copy, the dirty page will not be updated to a zero page again
on the target side, resulting in incorrect memory data on the source
and target sides.
The root cause is that the target side does not record the normal pages
to the receivedmap.
The solution is to add ramblock_recv_bitmap_set_offset in target side
to record the normal pages.
Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Jason Zeng <jason.zeng@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
migration/multifd-qpl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/multifd-qpl.c b/migration/multifd-qpl.c
index bbe466617f..88e2344af2 100644
--- a/migration/multifd-qpl.c
+++ b/migration/multifd-qpl.c
@@ -679,6 +679,7 @@ static int multifd_qpl_recv(MultiFDRecvParams *p, Error=
**errp)
qpl->zlen[i] =3D be32_to_cpu(qpl->zlen[i]);
assert(qpl->zlen[i] <=3D multifd_ram_page_size());
zbuf_len +=3D qpl->zlen[i];
+ ramblock_recv_bitmap_set_offset(p->block, p->normal[i]);
}
=20
/* read compressed pages */
--=20
2.43.0