From nobody Fri May 9 12:20:32 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=reject dis=none) header.from=linux.ibm.com
ARC-Seal: i=1; a=rsa-sha256; t=1734352483; cv=none;
d=zohomail.com; s=zohoarc;
b=LTpkjQTN+zesiKNtuzeodojDn1gP/XPG/x6Pyp7X/BNCCkGy4pAGL9TsyTchyuvK9sl3YqP8GaUKAKgzqZCCSMs7U2rlTFsBabhAamiK4QGSocdSfZrsdxzUCad1+9nD9lIVmNcP9H7lJMQao/JLgYVRZRluvGHOGCpowoV37qc=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1734352483;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=4mhlvfipa+pAxGA6zPLf66uMolrTSoUm2p9Mcz/ybsA=;
b=VNODkfn26kkQXnTO2T6tdD4lPG4O15G7KrUBHkDZnVeQ0jD5D6VZw4mmcknLURs97VDI7EpKMzU4uJph4skjvae6TnEkqmcxEAGMk2MWyjWOgxSvku/xpgtBLR+iKs69d5IcawZF6KHnBUEO++oWut8rKI0fXmachgxSoW0ud+c=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<iii@linux.ibm.com> (p=reject dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1734352483817123.22981353896;
Mon, 16 Dec 2024 04:34:43 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tNAIy-0002UD-0n; Mon, 16 Dec 2024 07:34:32 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <iii@linux.ibm.com>) id 1tNAIw-0002Pm-Nr
for qemu-devel@nongnu.org; Mon, 16 Dec 2024 07:34:30 -0500
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <iii@linux.ibm.com>) id 1tNAIt-0002M3-Vd
for qemu-devel@nongnu.org; Mon, 16 Dec 2024 07:34:30 -0500
Received: from pps.filterd (m0360072.ppops.net [127.0.0.1])
by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id
4BG85Wcn027022;
Mon, 16 Dec 2024 12:34:19 GMT
Received: from ppma21.wdc07v.mail.ibm.com
(5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])
by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43jgd295yh-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Mon, 16 Dec 2024 12:34:19 +0000 (GMT)
Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])
by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id
4BG97t8o005501;
Mon, 16 Dec 2024 12:34:18 GMT
Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227])
by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 43hnbmwvd9-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Mon, 16 Dec 2024 12:34:18 +0000
Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com
[10.20.54.105])
by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
4BGCYGXu56885758
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
Mon, 16 Dec 2024 12:34:16 GMT
Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 41E6520049;
Mon, 16 Dec 2024 12:34:16 +0000 (GMT)
Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 9F7FD20040;
Mon, 16 Dec 2024 12:34:15 +0000 (GMT)
Received: from heavy.ibm.com (unknown [9.171.68.106])
by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP;
Mon, 16 Dec 2024 12:34:15 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc
:content-transfer-encoding:date:from:in-reply-to:message-id
:mime-version:references:subject:to; s=pp1; bh=4mhlvfipa+pAxGA6z
PLf66uMolrTSoUm2p9Mcz/ybsA=; b=XwMtyt5pJNZdDTVKrPhIAnGSg/SvrxEoq
PTxsaQ4MTA2vpg6Y08weYcHKUllrdgngPHZdte/MN6xtLzQ0dlbQSJTtRK2tZ8wb
94g/6LDWxtO6/lVikNinWFJXMyYA7l+c0zrYQMkfUkNlxXRjpKu1oWV4t6N1zl5y
besW5dldNJxwSlJlVgHApOv5lpVVSzZTygAGGrQLI/y4pZv6tEIO8N2NGWNx7v6Z
r/xysLag1oiKIUM2pXyLkeKqsNS93TA+Sfgop9R9Y/FH/FRxmmapwB/95YLX78gC
wgM2LhI6kotJnZMJPBPstAD8VmCWRHcaU5tc26X8FK0Tdo6s/BRkw==
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Warner Losh <imp@bsdimp.com>, Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Kyle Evans <kevans@freebsd.org>,
=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@linaro.org>,
qemu-devel@nongnu.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v3 2/8] gdbstub: Try unlinking the unix socket before binding
Date: Mon, 16 Dec 2024 13:33:20 +0100
Message-ID: <20241216123412.77450-3-iii@linux.ibm.com>
X-Mailer: git-send-email 2.47.0
In-Reply-To: <20241216123412.77450-1-iii@linux.ibm.com>
References: <20241216123412.77450-1-iii@linux.ibm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-TM-AS-GCONF: 00
X-Proofpoint-ORIG-GUID: XuDXHcEGyvmom6dyGJ_dif-bdry2BTKr
X-Proofpoint-GUID: XuDXHcEGyvmom6dyGJ_dif-bdry2BTKr
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30
definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
spamscore=0 bulkscore=0
suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015
mlxlogscore=965 priorityscore=1501 malwarescore=0 impostorscore=0
mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.19.0-2411120000 definitions=main-2412160105
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com;
helo=mx0b-001b2d01.pphosted.com
X-Spam_score_int: -37
X-Spam_score: -3.8
X-Spam_bar: ---
X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,
RCVD_IN_MSPIKE_H2=-1.13, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @ibm.com)
X-ZM-MESSAGEID: 1734352485084116600
Content-Type: text/plain; charset="utf-8"
In case an emulated process execve()s another emulated process, bind()
will fail, because the socket already exists. So try deleting it.
Note that it is not possible to handle this in do_execv(): deleting
gdbserver_user_state.socket_path before safe_execve() is not correct,
because the latter may fail, and afterwards we may lose control.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
gdbstub/user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbstub/user.c b/gdbstub/user.c
index ef52f249ce9..c900d0a52fe 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -337,6 +337,7 @@ static int gdbserver_open_socket(const char *path)
=20
sockaddr.sun_family =3D AF_UNIX;
pstrcpy(sockaddr.sun_path, sizeof(sockaddr.sun_path) - 1, path);
+ unlink(sockaddr.sun_path);
ret =3D bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr));
if (ret < 0) {
perror("bind socket");
--=20
2.47.0