From nobody Wed Apr 16 16:17:55 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1734352555; cv=none; d=zohomail.com; s=zohoarc; b=B+AmgIyeiUs9MxnUTeb3kfQfCmGUZZdX1HGfOf3QEqqR6ajWZzzWhesKCNiCnqY3SQOuNjcYaHmcRkuixuRMzEN5GrXgkwAC8C+vw70j4jFQ0XRNd9R4ubqAXw9aVK8Jkx+TmNmek4axHkgUDPaMMeTzWnn+YkgIkFbqWwvSac0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734352555; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iU+BfY9OuD/w+hNKnoOk2n0zv49GHEu9fd33uKcvpro=; b=TxFTXmGYlz3QNC8KsCzZwF/8OX9z8XSe+IlXFwlXwex7xcXw2h9FdPvJ4Fs6fam51vO6gpAxAIRXCy6k0d4xXvsV9sA7DTiszM2WnBzA5PjUoCJ7BW/8X0pSN4Z5pQPWDGWrJermNWTUeDl6/Gwi/ITWPBk6MIrUa6lruPJGTcs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734352555908270.5423795529117; Mon, 16 Dec 2024 04:35:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNAJ2-0002e0-5T; Mon, 16 Dec 2024 07:34:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNAIw-0002Pn-SZ for qemu-devel@nongnu.org; Mon, 16 Dec 2024 07:34:30 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNAIt-0002Lz-BG for qemu-devel@nongnu.org; Mon, 16 Dec 2024 07:34:30 -0500 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG3rBV7013775; Mon, 16 Dec 2024 12:34:18 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43jcpb27fq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Dec 2024 12:34:18 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BGAZEPZ011295; Mon, 16 Dec 2024 12:34:17 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43hpjjwmxe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Dec 2024 12:34:17 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BGCYFSV60031440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Dec 2024 12:34:15 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8700F20049; Mon, 16 Dec 2024 12:34:15 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EDD5120040; Mon, 16 Dec 2024 12:34:14 +0000 (GMT) Received: from heavy.ibm.com (unknown [9.171.68.106]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 16 Dec 2024 12:34:14 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=iU+BfY9OuD/w+hNKn oOk2n0zv49GHEu9fd33uKcvpro=; b=RNa9zipf/Wp+f/cSiVE3fHTj9kqQVrYaU RqFNjDpYNgqoKesFlu47AZrKm8Tsh3NiLMeWACHbbC+lF+8Mj+G4rxp2iXinluJ0 uPJixDtKefj3DcvhgeOu71JMaTBYr9mhyeBkHAi+x/WmwchEwrYcaADATdSTu4RM rfhG92qsEICWS5XpvxEPqvVKaXprziS7E2F3/GOmSAQoBm7CvpFdzos1TkbccozF vBbcs6Ul2H4FDA7YiG7CcodxLjboNqNuUdTH9iZt8V1jpwd7B9obLa3JODged5Mc 1t5TlxzvHHgMkji5wT1RsVf0tAJmsfu8vfIvl8xTPbJSNLwItwyAg== From: Ilya Leoshkevich To: Warner Losh , Riku Voipio , Laurent Vivier , Paolo Bonzini , Richard Henderson Cc: Kyle Evans , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Ilya Leoshkevich Subject: [PATCH v3 1/8] gdbstub: Allow the %d placeholder in the socket path Date: Mon, 16 Dec 2024 13:33:19 +0100 Message-ID: <20241216123412.77450-2-iii@linux.ibm.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241216123412.77450-1-iii@linux.ibm.com> References: <20241216123412.77450-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: G9MrVTP7GnxXvCosf3v9rImGXHZfNVw5 X-Proofpoint-GUID: G9MrVTP7GnxXvCosf3v9rImGXHZfNVw5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412160105 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1.13, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1734352557604116600 Content-Type: text/plain; charset="utf-8" Just like for QEMU_LOG_FILENAME, replace %d with PID in the GDB socket path. This allows running multi-process applications with, e.g., export QEMU_GDB=3D/tmp/qemu-%d.sock. Currently this is not possible, since the first process will cause the subsequent ones to fail due to not being able to bind() the GDB socket. Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Signed-off-by: Ilya Leoshkevich --- gdbstub/user.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gdbstub/user.c b/gdbstub/user.c index 0b4bfa9c488..ef52f249ce9 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -316,9 +316,19 @@ static bool gdb_accept_socket(int gdb_fd) =20 static int gdbserver_open_socket(const char *path) { + g_autoptr(GString) buf =3D g_string_new(""); struct sockaddr_un sockaddr =3D {}; + char *pid_placeholder; int fd, ret; =20 + pid_placeholder =3D strstr(path, "%d"); + if (pid_placeholder !=3D NULL) { + g_string_append_len(buf, path, pid_placeholder - path); + g_string_append_printf(buf, "%d", qemu_get_thread_id()); + g_string_append(buf, pid_placeholder + 2); + path =3D buf->str; + } + fd =3D socket(AF_UNIX, SOCK_STREAM, 0); if (fd < 0) { perror("create socket"); --=20 2.47.0