From nobody Wed Apr 9 01:13:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1734310246; cv=none; d=zohomail.com; s=zohoarc; b=cT1aASY94M/gpOxA5siHqXRhRoY3RuP47G06om0SfdpBPO5xJ/TrBCPv95JYG5FAb9nQwr36Yv+vSbNKU+dEbA2g5ZVofBexdXLfD/oAPV0lYNpVy2Vu2QPaMGCO5NdaL/vi96F/JIqLMvuUCWLnCf0JZopC+YNEph6WaYJ/EJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734310246; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KGU2u7dc4vF2vyfDv3T9ZFSN7CKazY7j/eyKw4lus10=; b=Kc2YonpmNVRPlDrUqjKg9567pZ0qIBkZJOHLKfURtIM9y//k0bfnnOLMj59TZRh4W+ADjZCyYV5gsyTl1RbG2kLN+3EmYbuZ4drjIiN7vcgQWt20ZAsn++kEXCst+109kkqyfRdyJi9VNmndc/wO3WWtU7O3UIC7dP6UxMdtOJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 173431024604153.832200428443; Sun, 15 Dec 2024 16:50:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMzJ5-0001G2-4Z; Sun, 15 Dec 2024 19:49:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMzJ3-0001Fk-54 for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:49:53 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMzIw-00073I-GB for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:49:52 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-216728b1836so24537615ad.0 for ; Sun, 15 Dec 2024 16:49:44 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5addbf9sm3059586a12.47.2024.12.15.16.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1734310181; x=1734914981; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KGU2u7dc4vF2vyfDv3T9ZFSN7CKazY7j/eyKw4lus10=; b=MN9zGA17PStnPXAYgKMsCO1SAv3FCefEW7nhEpWTQ7PJAW/UXoQcPbq/ZdaP/HXz87 Y6BTOB5AjhjKGAiQwf3X7Sa4i2rVjAlIXyfK2aNqH8SwmXo8kHXQkW6BBTvVjqYh7c1j oM8HhvYgGcXT1o6lSronAYTDa+CKcHC0EwciDvxopfneFxMbjTSLhmOnzf7LgUSB/44R c8+fAIvYLgV+CHDNk1JNPb8qQgdICe536CRR4845aTrPM46Eso/PUzCpWtF2AvBqK63Q unSiKHbvCmyCcjWO8oD8ollTjfstojMwiYFRIK4dLzThrSyMcHJKZoY0w3CEiGQ2SjF5 tXlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734310181; x=1734914981; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KGU2u7dc4vF2vyfDv3T9ZFSN7CKazY7j/eyKw4lus10=; b=nvlcp+HD5ZNQN8JXhcCQNnklesqcVPg29K1PkMjB5ZrcVe6v8DEeS233CGI4Fy9rqB UPUnDzRRQAUMu2Q6VQabJUVCe01MOMBOvskwIOJDbJ1wGJP087dPzXJHh4wQd6hfroEp U3hZZlIP5BfqlvrN6W71DpldfAbuI4MQMBTb6hQTlPXqpPVpmj3AxM6byYvKV0nXiEfV VcqnyEv9XvEBySyey4xdcmvywcN69+qkcqc/mHaLtFTgtfgbJydjoDuF3v8+tFsjGkwW 0YeoBNCwB07yK8JYX/ez/aGJD+aZlSk4jdnEmaLviImloL3kxI3AySqHz+ZRto9hpj62 sB7Q== X-Gm-Message-State: AOJu0YzUGQW6XDuiqwWvoGVCCxs5zLHgGgcBx06ZkFVzCrHWyiBkvtTR L7CDCHTtb5nyTP9FXHznZ/B1OqbRu1jpfR7qcpsg5vCJRjTQ7duY6qISguZu9n+kMUGGyEtqFC5 Z1/MoM8yq2CcJycGQRqRWndP/yvemdXju2/cmTp2Q76ynR3P4yuqNd11u88zhvntyIYEo+evZjT Sz76jmjqn2V1u0ExvRqUPZQrMiNG2mhUPQxb2xfSlpq5r2qJo= X-Gm-Gg: ASbGncuTCqttX1Ov2C/ONr3sUYxaoM1uncS9DyFCXrWRliuQ5jlybTrzv1bi+nQCATB TZK1N76yrnj7Tr0/omJAdl4YaktyfkJQenO+eVP0KCtFi/ny8U2tB3meywmuIKWn6q3kFCwd/OG pawWHCFty7jqAY5mxsddNx4xdwNF2BUir9reEc8ytE8oKojq7sY5Bh3mUXvPzRqArcFTt5kYwxN /2xcADNoBQjrwjKMwmPe06gYtu53cwSbd95bgYZlWUenCARUE/EyFTjW6pMgTYsTyhiHf3mputx IqqqSqH/ X-Google-Smtp-Source: AGHT+IHHXEDgr6REu1/UiEmWcihNjDhUHo43i90n1NWtN7yO5Bz8w417fbDj8Tgyg0Q2/o9Dcvfbpg== X-Received: by 2002:a17:902:ced0:b0:216:1ec6:9888 with SMTP id d9443c01a7336-21892a13eeemr124259335ad.33.1734310180693; Sun, 15 Dec 2024 16:49:40 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Peter Maydell , Andrey Smirnov , "Michael S. Tsirkin" , Marcel Apfelbaum , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-arm@nongnu.org (open list:MCIMX7D SABRE / i...), Jason Chien Subject: [RFC PATCH 1/6] include/hw/pci: Add a callback to set the downstream memory region of a pci bus Date: Mon, 16 Dec 2024 08:48:52 +0800 Message-ID: <20241216004857.9367-2-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20241216004857.9367-1-jason.chien@sifive.com> References: <20241216004857.9367-1-jason.chien@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=jason.chien@sifive.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1734310246488116600 Content-Type: text/plain; charset="utf-8" PCIIOMMUOps.set_memory_region() is introduced to set the downstream memory region of a pci bus. When PCIIOMMUOps.get_address_space() is already registered by the pci host(e.g. TYPE_DESIGNWARE_PCIE_HOST), PCIIOMMUOps.set_memory_region() should be registered as well, so an IOMMU can designate the downstream memory region for the pci bus. Signed-off-by: Jason Chien --- include/hw/pci/pci.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index c0717e3121..cb3039bce8 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -388,6 +388,19 @@ typedef struct PCIIOMMUOps { * @devfn: device and function number */ AddressSpace * (*get_address_space)(PCIBus *bus, void *opaque, int dev= fn); + /** + * @set_memory_region: set the downstream memory region for a set of + * devices on a PCI bus. + * + * Optional callback, which should be implemented when get_address_spa= ce() + * is registered by the PCI host(e.g. TYPE_DESIGNWARE_PCIE_HOST), which + * makes an IOMMU not able to register get_address_space() again. + * + * @opaque: the data passed to pci_setup_iommu(). + * + * @mr: the downsteam memory region + */ + void (*set_memory_region)(void *opaque, MemoryRegion *mr); /** * @set_iommu_device: attach a HostIOMMUDevice to a vIOMMU * --=20 2.43.2 From nobody Wed Apr 9 01:13:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1734310234; cv=none; d=zohomail.com; s=zohoarc; b=H7tvZ/faKb7sg3RkyAkzPmMgMftRFT4RmImwQkTaVQcm4wT2Ovi4cbCBx8N+ItXEWa8gAXDKzz6XvTXcgSdP8FBza8VhIS/y48bXNRs3L1b21zQPe65jOznj7S+yvZ2jJqukNYEQ3ewOmusplorZ8x68ITmXgOlagEHAvD8jM9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734310234; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VUe/CaMF1o3K5iHx+qDApgHKPoUWwGBc8t+UaT1YHyc=; b=LiQrfZTQreLBfRKvkBia1HD2GuyMZ1j/9moEYX4GKTco++0rUd1i9jy3VNBIumikQa5mZT3LGL3tPLNtd1dAoAENFCqCXGRX2n2T8g2F5/kEFQDHZyYwwNQNibMWdjBHuIfA5PJL3h3ihO9Tz6Vv8H/XStFJNqFDgQ4Sktgta1M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734310234235356.596118442436; Sun, 15 Dec 2024 16:50:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMzJ9-0001Hf-6R; Sun, 15 Dec 2024 19:49:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMzJ4-0001G1-LN for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:49:54 -0500 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMzIz-00073w-7a for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:49:53 -0500 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-728f1e66418so2885779b3a.2 for ; Sun, 15 Dec 2024 16:49:48 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5addbf9sm3059586a12.47.2024.12.15.16.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1734310187; x=1734914987; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VUe/CaMF1o3K5iHx+qDApgHKPoUWwGBc8t+UaT1YHyc=; b=asvH60svarZ7u3X3/heC9aA3cbPRY750IK32BoAJXakbmgbSdAd8D3htha1iQlx+wb 9fO5gCdVGamTIcN07QYgw6sQm7P0I8Anayvzw0hgsJBoXc/DC/YHzgpoDvW+UPXAWf1U USas5Gcf4chngOqEC/4KRMdWyrcV8UfO516BJXMaOmwRBCl7yzK20AkDcrxUm8QzbO3r /xjaXzTemjOcpAtlrnWEtDnhH6hBBNjonKiqn7ucYMNBAnsYgSV7nVTEYwjdfzGc9UCL fHRSH7FaNJCiATx+qSnhXCsfI/7bI1A4RMp7286G18BCLuiQ8R8ka/iMDJ6MwlMpkHKQ Y9Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734310187; x=1734914987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VUe/CaMF1o3K5iHx+qDApgHKPoUWwGBc8t+UaT1YHyc=; b=bN+cQTZ0F8dznL6blUyaT8Wzj05O39ebeSKoinpM2YUJXF/OTe7+2j+XvfdttXw/lh TuMUTfjepPTaP8joPj8qJ/O/U5LoLYU1NWI1meEPx4nsPO20yrvhnGr2dKNMRbh3nJ0e 9UuhTGTX+gFTlLKPQFuuh187zrX5MfNn/djpVC39En4t1HwJ1vxzkngn9ickUmCbiGYd gt0JNcB5k2tJI6cQOaMIWcVWHqXQiTnd+URdSAsubq/dX6zFr9Wa4J5YjMAeIsu+6egI 9OyDsq9JkAV+yJBahnqqGCfCHByg8bu1kLtSjQLfh++h4rwKLPdwy3KQKR0sY2Gy4qZM TrWQ== X-Gm-Message-State: AOJu0YxYKDbe0VQSc//ezgS/6qqNnXsVJ+vBBVni4k6dSWuqKQinZdKA QWe9h304ppQ+nq+2Q7YG2Ce8n3OifqdojFvszNJNVOXI7f1hRmvijRwCpF//3rSdd8OQUmfcuni knMPsiCpDPJ4e/JEsFWA5xqh413CVKAw0VDDyBNknIIlG39BhCelS5wHO14cbR18rW8Q6Wfx1Nz LYM4GGXNDwpP7iWsygbBxxXQb5FTAihuJe3oxgCZpCFikStnI= X-Gm-Gg: ASbGnctTG34FGE/g2m4j2g+PrdRhEoiG+yOnKA87O1wyf6kOEPWtwogeQyeRMKIlYTi gZ7rXgKpJ1s5MSSakbiwKQIrV8fUn74whdnKmZC53zAHXPIJnueW22OBPtIcrTpyjP0Pk4QBUWq /K5B1ihbrnU6Nx5aEAo/5oOTsia7yGKRRzA/H3DK6tMltpGwBUMdy9JXgKJLz0TgRwD2xLCRjSo yAA5aDevZ4vYdP5FLLy74FkkwuP21UHXF7I6LKnj1BcqVKTYTUbdLpePdGVuC1xeDLSXvgj5qvv hS3UtQ4j X-Google-Smtp-Source: AGHT+IHvj674NESG+JlkRqyelwD4AO0yabLxvdCxK9Ao7iPJigpu0Z94K/UWRLMXbhHs198KfQoQew== X-Received: by 2002:a05:6a20:728f:b0:1db:ec0f:5cf4 with SMTP id adf61e73a8af0-1e1dfe322a0mr16052201637.39.1734310186830; Sun, 15 Dec 2024 16:49:46 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Peter Maydell , Andrey Smirnov , "Michael S. Tsirkin" , Marcel Apfelbaum , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-arm@nongnu.org (open list:MCIMX7D SABRE / i...), Jason Chien Subject: [RFC PATCH 2/6] hw/pci: Add an API to set the downstream memory region of a PCI bus Date: Mon, 16 Dec 2024 08:48:53 +0800 Message-ID: <20241216004857.9367-3-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20241216004857.9367-1-jason.chien@sifive.com> References: <20241216004857.9367-1-jason.chien@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=jason.chien@sifive.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1734310236679116600 Content-Type: text/plain; charset="utf-8" pci_setup_iommu_downstream_mem() invokes PCIIOMMUOps.set_memory_region() to set the downstream memroy region of a PCI bus. Signed-off-by: Jason Chien --- hw/pci/pci.c | 6 ++++++ include/hw/pci/pci.h | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 1416ae202c..8703d75ac3 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2811,6 +2811,12 @@ void pci_setup_iommu(PCIBus *bus, const PCIIOMMUOps = *ops, void *opaque) bus->iommu_opaque =3D opaque; } =20 +void pci_setup_iommu_downstream_mem(PCIBus *bus, MemoryRegion *mr) +{ + assert(bus->iommu_ops && bus->iommu_ops->set_memory_region); + bus->iommu_ops->set_memory_region(bus->iommu_opaque, mr); +} + static void pci_dev_get_w64(PCIBus *b, PCIDevice *dev, void *opaque) { Range *range =3D opaque; diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index cb3039bce8..9ae2cc61f1 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -450,6 +450,13 @@ void pci_device_unset_iommu_device(PCIDevice *dev); * @opaque: passed to callbacks of the @ops structure. */ void pci_setup_iommu(PCIBus *bus, const PCIIOMMUOps *ops, void *opaque); +/** + * pci_setup_iommu_downstream_mem: Designate a memory region for a PCIBus + * + * @bus: the #PCIBus being updated. + * @mr: the designated memory region. + */ +void pci_setup_iommu_downstream_mem(PCIBus *bus, MemoryRegion *mr); =20 pcibus_t pci_bar_address(PCIDevice *d, int reg, uint8_t type, pcibus_t size); --=20 2.43.2 From nobody Wed Apr 9 01:13:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1734310290; cv=none; d=zohomail.com; s=zohoarc; b=BNWBNCZmvdm3mq2H65WKSesSk/V5/UfccOdMRHA8req3HiThTlRWVP8450T+c5NGT8J/Swai10m0AFtkVG2QJz9nU7RdO8XI8RSNN2giJrhVxBrhlNWd68GWp5CqEOWj7bKtwQGHXUummnJX5lh8NPj16QL9/yd+TsVBN09OHY0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734310290; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gMz5z1qtJxQUJErlLKkRHU3+t7ygQhiQ+P8RsAR7bug=; b=KGM4Hjf7pLSkhbt8YwWRrazbIgdyOYTDV8P5YP0eF4iwjIkUVnw52qWS0wYnBbKPafyXq299dqsKoBgbo27wc7Bn7VVQ7Gsyb+jWZ3Y5ype+Q0d/EOOK6gXwDOaYz1ITQlxHBTo7maT2k89h8UE4Pq+EEF2ERWRGuW58EOttuRc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734310290175456.3615877930847; Sun, 15 Dec 2024 16:51:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMzJG-0001Jk-HZ; Sun, 15 Dec 2024 19:50:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMzJA-0001IF-SQ for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:02 -0500 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMzJ6-000750-IY for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:49:59 -0500 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7fbd9be84bdso3301163a12.1 for ; Sun, 15 Dec 2024 16:49:55 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5addbf9sm3059586a12.47.2024.12.15.16.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1734310193; x=1734914993; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gMz5z1qtJxQUJErlLKkRHU3+t7ygQhiQ+P8RsAR7bug=; b=IxL8Ja5XX3u+LXmSva3zRNf2X3uv19ueFIxz/Ns72fh558qe5zcWpK86Xu8fu88vox OIBorXodUf/vwsAhpFHstBpXHdiMK0qs9E31CoaI7jzpr93d6/GhWKoVbjYp2P/pxIJT TrpSJaQz1dVUaLZJneUUPnqZ9GK+A8OFCvkdgNRF/J70p+VgdtUovLLL3PY35LkmQlc0 ohRZRi9ybDCo0t7NPpSPQN4uhzVh5wZY4JrJEvkQkWi0ftMa03eH3PQ0H82VMSVlRC+o 6P53oTLmqdSJKdGtnB0k3tRtqBbIc2wAFur/iV/wkwrVbQhKG3JMoC9MMaxX+nvIR8dc KkPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734310193; x=1734914993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gMz5z1qtJxQUJErlLKkRHU3+t7ygQhiQ+P8RsAR7bug=; b=epv0TGsjKbr4LOu85L8mnkQ5Jm7Ys1cSgnYX0p4UdpRTT6JGnC/9hzNx8/tzJXCi5Y 5hMalj6itkA6ubsTzZ2fkh2sSE8VzTYylpppXg0kj+3n3Xy1GdxbL5viGe/SwTjoYyoN vgwQpXTuxl1nmqZfIleJPqzu+wplpVvv4cX5yfgseBDfrf1cWgUq7D+epTBbA24sPHGs Oz9IyDHeir3WJSqoCU8x1tT10p5/kMSs3TIV6qxuwtYASAZ54tPesMJuTI26/ANjdANE wGQiCR0CvqdYxaNVKkhGWRWx4kEa68s+TeDgTGy9gY201E88lCZAGLJgBMv51e5lPzbl 3CAw== X-Gm-Message-State: AOJu0YwX1nJNO8n4V0I0bBnKeWdBM4IZG0W6Dz+Mss1VQlEfDSh2UpmP LERVJIY677bfkwfCGvJB3luutxC5LtC4jg3sEDZ3iE90ySWgFBVAQvdUt+/1T6BOL5lYwqUXUH5 izWagPAon0Sz2Ig0ZD7M7W9XzL8xb1DtFNq5oxzGMUAqXecc1wiIVffclA2d+r2nmc+eraGGK5Q Xdd+5D4G/ZuYwAsWBElLJqilIAAIgDhyosC3/i8Us4iUSWuOE= X-Gm-Gg: ASbGnct0ElNeRsVpwBGmzgvauXfarOMFYtMTUZVYnM6HjEEgNi6B52tiDQyjn/0YYKY 6OXp1tvJLaZ4QbrkK0oTD3glhzv1cWN+fKJ6gi1Pr/fHdFPLwzIByb0a5aOAEDmqBtDnZwN/xJ1 qskyOtp9cTMiUPxnOrQ/MyZeHRuqeaPjv6xbJe2nRuV1uUluUMUD5Q479Q45lWrnW/S1GrDO0ew 5Jx/AM9wd9jorHO8Yl7Z4Rtirm2Gw+8wf4dLCdcSQIsoHu+DTjUOx6wokq0RHRHC814kgfWoqdz bIUroEVY X-Google-Smtp-Source: AGHT+IEHMPO7YkCWAGkSD7eI5KSN8Gv9wkinIu6eD/GvMxdLAFbKpvB3We7N+j/JoyzyEAQJ1Z9X/Q== X-Received: by 2002:a05:6a20:9143:b0:1e1:9f77:da92 with SMTP id adf61e73a8af0-1e1dfde6d4dmr14073191637.33.1734310193247; Sun, 15 Dec 2024 16:49:53 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Peter Maydell , Andrey Smirnov , "Michael S. Tsirkin" , Marcel Apfelbaum , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-arm@nongnu.org (open list:MCIMX7D SABRE / i...), Jason Chien Subject: [RFC PATCH 3/6] hw/pci-host: Enable DW PCIe host to send memory transactions over specific mr Date: Mon, 16 Dec 2024 08:48:54 +0800 Message-ID: <20241216004857.9367-4-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20241216004857.9367-1-jason.chien@sifive.com> References: <20241216004857.9367-1-jason.chien@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=jason.chien@sifive.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1734310290463116600 Content-Type: text/plain; charset="utf-8" Current Designware PCIe host cannot connect to an IOMMU, since it has registered PCIIOMMUOps.get_address_space() and an IOMMU cannot overwrite PCIIOMMUOps.get_address_space() without breaking the PCIe translation rules. This commit implements designware_pcie_host_set_mem(), which is used to register PCIIOMMUOps.set_memory_region(), so an IOMMU can designate the downstream memory region for the PCIe devices. Signed-off-by: Jason Chien --- hw/pci-host/designware.c | 18 +++++++++++++++--- include/hw/pci-host/designware.h | 2 ++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index c3fc37b904..8afe447562 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -395,7 +395,6 @@ static void designware_pcie_root_realize(PCIDevice *dev= , Error **errp) { DesignwarePCIERoot *root =3D DESIGNWARE_PCIE_ROOT(dev); DesignwarePCIEHost *host =3D designware_pcie_root_to_host(root); - MemoryRegion *host_mem =3D get_system_memory(); MemoryRegion *address_space =3D &host->pci.memory; PCIBridge *br =3D PCI_BRIDGE(dev); DesignwarePCIEViewport *viewport; @@ -436,7 +435,7 @@ static void designware_pcie_root_realize(PCIDevice *dev= , Error **errp) viewport->cr[0] =3D DESIGNWARE_PCIE_ATU_TYPE_MEM; =20 source =3D &host->pci.address_space_root; - destination =3D host_mem; + destination =3D &host->bridge_mr; direction =3D "Inbound"; =20 /* @@ -461,7 +460,7 @@ static void designware_pcie_root_realize(PCIDevice *dev= , Error **errp) =20 destination =3D &host->pci.memory; direction =3D "Outbound"; - source =3D host_mem; + source =3D get_system_memory(); =20 /* * Configure MemoryRegion implementing CPU -> PCI memory @@ -666,8 +665,16 @@ static AddressSpace *designware_pcie_host_set_iommu(PC= IBus *bus, void *opaque, return &s->pci.address_space; } =20 +void designware_pcie_host_set_mem(void *opaque, MemoryRegion *mr) +{ + DesignwarePCIEHost *s =3D DESIGNWARE_PCIE_HOST(opaque); + + memory_region_add_subregion_overlap(&s->bridge_mr, 0, mr, INT32_MAX); +} + static const PCIIOMMUOps designware_iommu_ops =3D { .get_address_space =3D designware_pcie_host_set_iommu, + .set_memory_region =3D designware_pcie_host_set_mem, }; =20 static void designware_pcie_host_realize(DeviceState *dev, Error **errp) @@ -703,6 +710,11 @@ static void designware_pcie_host_realize(DeviceState *= dev, Error **errp) TYPE_PCIE_BUS); pci->bus->flags |=3D PCI_BUS_EXTENDED_CONFIG_SPACE; =20 + memory_region_init(&s->bridge_mr, OBJECT(s), + "pcie-bus-bridge-memory", UINT64_MAX); + memory_region_add_subregion(&s->bridge_mr, 0x0, get_system_memory()); + address_space_init(&s->bridge_as, &s->bridge_mr, "pcie-bus-bridge-spac= e"); + memory_region_init(&s->pci.address_space_root, OBJECT(s), "pcie-bus-address-space-root", diff --git a/include/hw/pci-host/designware.h b/include/hw/pci-host/designw= are.h index c484e377a8..9562a4ff96 100644 --- a/include/hw/pci-host/designware.h +++ b/include/hw/pci-host/designware.h @@ -89,6 +89,8 @@ struct DesignwarePCIEHost { } pci; =20 MemoryRegion mmio; + AddressSpace bridge_as; + MemoryRegion bridge_mr; }; =20 #endif /* DESIGNWARE_H */ --=20 2.43.2 From nobody Wed Apr 9 01:13:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1734310294; cv=none; d=zohomail.com; s=zohoarc; b=DiMMVPkUagEd0e2LySZnYWMCuxDlufPmafCHtiu8DbFfLsTQ66w0meOL9s/FGIo1kF/Cw+T/GPTFGe9dudvxXhrRad67PbkIp86aANQVq/ajyn1+aKOUMRPXPAsLj6PkCaCL4Qi1GFQnaNSGHAMRoh+xWZfdQnlju9o1K366UkM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734310294; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/txMo+Nnraz9AAcWBO+Ht1SEClLczXwE0l/xGp309E0=; b=XIEvQOoRn/D44WVZ00c7sjY/YICbnwiPJY6Zzr2F8mCjTY0oB0st65FYnATYYhvScEpwhBd/RYkvMQahGEbU98HexLNqq8728a9GZ+rXOmyZ0sgJ/a2WTSRtEoKsXwWrNFhQ+WJEgWeyZ4u1eHEbOq9Iocpn3/gKjU4vD8AW9N0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 173431029406193.76557804422828; Sun, 15 Dec 2024 16:51:34 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMzJJ-0001O0-F5; Sun, 15 Dec 2024 19:50:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMzJG-0001KI-Fq for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:06 -0500 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMzJA-00075b-Ne for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:03 -0500 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-725ed193c9eso2789831b3a.1 for ; Sun, 15 Dec 2024 16:49:59 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5addbf9sm3059586a12.47.2024.12.15.16.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1734310198; x=1734914998; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/txMo+Nnraz9AAcWBO+Ht1SEClLczXwE0l/xGp309E0=; b=ZQ79rw5yMoXteReU93aya5jSGkqUHK8c1CM55eWycUxoGivb/ogC47OWoNXa57fSyW r340yCGHSX3g0vPhdtXNPsrpiuLtJTPEpY7ljMAL1w0ARycHzkMdR+uH4FHTiMeECE2C ckwOR5ZiPaD7CB4axXb6UAX4SuwfuEUT0jToKFFsqxkQMxEi4djVVkUpQQdru64LDJ11 aRX6AiAE8bOFMvjLOvgHYpDyzUgt/vFpdMHhbzzGRYFSivJTlB7BtDwiLrhuJr9e67L0 YumdacWErYtx3+UoGRdQBiQjrmxXuWGg/eYCz7RWisFfYpvWBtsHRog+n9loLv9P1Z8P jouw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734310198; x=1734914998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/txMo+Nnraz9AAcWBO+Ht1SEClLczXwE0l/xGp309E0=; b=TxYlVTsR4rJLMza8+sL75Uhz6mSJvviZmX2LbThnp8AvkM83uKXHsCxyqO+b3xNNDZ UXA0+7wpKzPszXANgmCzk7A/1w+5Q2WBcbyg6Qv/gDAlDAZdDld/Tey/heU7w/8v0Gxq dlt8/mWXuFO/RZwpJH4Ci/k8b8WNB2+pJYh7JDw1NrB0RGpw41gB11WSYaoYiFI1k1qt aZdVZKXA1Jk90zL5A7hGPr3EVExUiEdRphhiA/JEEvEzevNxz+60ITK2PVG3s14ex90v 0vj3xXI5TcZJSsiYNujvltPk2fCthaCagKhSpPW8PbfUxNfiyGSLLvk+KteGDxhZqp80 BDJA== X-Gm-Message-State: AOJu0YyJITMtqfNDe+j8Ux1oh9Le6LqpKexKYz1BQ0BZ9YcHzJqxUWYl Ssr6bWJIPkdWLg9pznm5sZU8DdBBnHs15s7cy6NbfecMPwDu5WFKIdG0W933/NX+q2rfjfV2JEX vszcVSJUiHcB7I/okRPeZatmj/84L/wo8D9du/y0RgKwL6lBwSFO6n4/nWaKiEzmoJfnUrfcZS4 XpyJbCj93/cRGMApd0A+jw9n574EhSQoTgMlyn6zqW1Q5Kmjs= X-Gm-Gg: ASbGncvCCa7ohwFFJQqxf1XikiTCJfRqzIZazj7uJKTd9+4D1hk8omlQ/R7+ssvvmJk PMay7uwihuSMxj0CDqwokor8uVSP/HPhbiG7uby9te2asyK4kBeSuukfihoAAiRrDOfqNRBU2vS u5Q1BqOX25SwMSM4zAzRngWuTHKOXnnL4I2azUIgZ4buh4nt1EJNggLGBu58i0vRHkyXSqMg3I3 pO0d+3Q8kyqGBchOQ11Zt/+Yj1ISiVrDwloWJq6qkDroVLR47f23BEV/EEoyvaGhHmdlgBA54G9 AmwH7rNA X-Google-Smtp-Source: AGHT+IG7C/z9lqXQKhZELwgwHH6ev+PqxHmUpUtpuDtnyBnjuDPC1LlZ9b9OL21KR951RrunYjL69Q== X-Received: by 2002:a05:6a20:9f05:b0:1e0:cf9a:87b1 with SMTP id adf61e73a8af0-1e1dfbfbcbemr15265933637.6.1734310197718; Sun, 15 Dec 2024 16:49:57 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Peter Maydell , Andrey Smirnov , "Michael S. Tsirkin" , Marcel Apfelbaum , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-arm@nongnu.org (open list:MCIMX7D SABRE / i...), Jason Chien Subject: [RFC PATCH 4/6] hw/riscv/riscv-iommu: Allow PCI hosts with iommu_ops registered connecting to the IOMMU Date: Mon, 16 Dec 2024 08:48:55 +0800 Message-ID: <20241216004857.9367-5-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20241216004857.9367-1-jason.chien@sifive.com> References: <20241216004857.9367-1-jason.chien@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=jason.chien@sifive.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1734310294569116600 Content-Type: text/plain; charset="utf-8" pci_setup_iommu_downstream_mem() is called to set the downstream memory region of the PCIe devices. Signed-off-by: Jason Chien Reviewed-by: Daniel Henrique Barboza --- hw/riscv/riscv-iommu.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index e9a0775d6e..f5d53a36b2 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -2436,6 +2436,14 @@ void riscv_iommu_pci_setup_iommu(RISCVIOMMUState *io= mmu, PCIBus *bus, QLIST_INSERT_AFTER(last, iommu, iommus); } else if (!bus->iommu_ops && !bus->iommu_opaque) { pci_setup_iommu(bus, &riscv_iommu_ops, iommu); + } else if (bus->iommu_ops && bus->iommu_ops->set_memory_region) { + /* + * TODO: + * All memory transactions of this bus will be directed to this AS. + * We need to distinguish the source device dynamically. + */ + AddressSpace *as =3D riscv_iommu_space(iommu, 0); + pci_setup_iommu_downstream_mem(bus, as->root); } else { error_setg(errp, "can't register secondary IOMMU for PCI bus #%d", pci_bus_num(bus)); --=20 2.43.2 From nobody Wed Apr 9 01:13:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1734310287; cv=none; d=zohomail.com; s=zohoarc; b=K2BG5Fv4Y1uFqJEgj2o6JFLw9Rjvggr4Aq4kcXrUR1ruW7L3SmyVzwjTryT8gj1FdLbp4/OvHmVACV31ngZCTHWQhFkiS5QCuuBajvJrMa0O0Xh5e6cXbxwoX58ywS7NaMizkGx2LSU9jezw5ZmTSAsSRvxxiyjjpioJNZjKvZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734310287; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0oPxPHNXebmd2yYjjqR5HgsogRG7IAY4swP2rcEypRg=; b=jiRldVXFHRpBO97Hv4WDYgFSRhBm90JZjzxFRSBBXrTZl/CVnkZw5VE4P6FF03CwgSpEp3cIGHk3nh9EONahhrDNc6McF9GC2EcBR6ipQvDFhF4EO75u9OHNwCg0PENK5JWNPqbEyGMRKfZXA3a9W9opzvi3PqSASeQPibGPs0o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734310287334139.23764167373395; Sun, 15 Dec 2024 16:51:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMzJM-0001Ry-76; Sun, 15 Dec 2024 19:50:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMzJJ-0001OX-LZ for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:09 -0500 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMzJG-00078g-6f for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:09 -0500 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-725ea1e19f0so2910193b3a.3 for ; Sun, 15 Dec 2024 16:50:03 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5addbf9sm3059586a12.47.2024.12.15.16.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1734310202; x=1734915002; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0oPxPHNXebmd2yYjjqR5HgsogRG7IAY4swP2rcEypRg=; b=Y7ZlbFodL/B/qZgoU4q8J7NLqnVW809NykVvkjF8zL6JuHQQgfOAZeyz6SQPs+Ggrn gLhgOpub5AkwoY1XeFILSp15v8YS3kakXu5DdI79FPNTPoMVcTZSJBbgVaRDBMvZG/d4 en9WxvIq7cdafhNUTQRS49gLoeg7QN58nvnt/p+0s15a2SnciomInVFWOW+X1Z8czNCX KGF/4Xi4imP6LSb2Hxw1VJfJZEDb5fvwWJfXiaLNQGEUClwBdxi+bZYvY3PHEiNwShX2 4IXpJ/NhgPwlZdT1vzUUFaCFt4KDMBA68sv3rRxgOiuTkxlyYJTPKOrtY8nPsMNIJaRW CztQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734310202; x=1734915002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0oPxPHNXebmd2yYjjqR5HgsogRG7IAY4swP2rcEypRg=; b=Ml50Xz2btgpigEUwzUgrc4oK1lYLGrs30n/9ipommaWfDRu2hy2GtORhI1/4McpJIx 8jgN8o5Kp4JSJMefdWgUwhrQLxBJwjBK+RsKMWeMXiHdZ6+FdbtcIJR9wOIZi7QtJvQR s79ZMhJ556jd7QLkdaJBCK8NK1YHRGtUK9UuC+G7KHb+SbbURiQLAOgyCqYy21WuJ6IB JsL9GcL28+Aux41maAmnAF1X/5ojvwMUb9Vnd1pWc/71/lwc1FqY39lodFWPIdciirno TGQL2EwBdEPrnHbeQx1FlLYSBzJg/HjAmbCUrQiyFMBDJWNm/c1RNvfTMJcqnyC6X112 6lOg== X-Gm-Message-State: AOJu0Ywxjbw44GWUgcH7UniaSphi2pjTJmy9Z8pQjih6iwaChr0BAr1/ +RgsfWCOT1Yxqwb3QkJIC4QOuWZxVJJ3UaeesKETndbqEOtLhVWZhVmo1WymLhigtrohLZSzeX9 BAlXhW0iKC8d0za/j/iqzFugP6EmXPmXbcZsfWNBUzQ99OP8MSf+3T1aQr9CSr4W32EOz+FIEUv c4Xm9sFwx27TUcjwh02tsjtbkHeK/u0T+iaoViYV86WBvYJV8= X-Gm-Gg: ASbGncuTuaBgf1bpPjvQnvNzsYppJ6OcXV6emNfg3xFrZZ7G7tiyih4+6lmquBwPWcr opUjd2HVfgWunwm8PHSCeJAIgqH9FilNJd6JTE4VEuReeQAEU0Z9MVgQZktDimvivdL+YxkJHzJ C6l+2cZrjlToyFLoAABpwK1bq7Z9cN/5rH1GU1+PE3pMm1vQNucGdU6+s9xmIZuGrrZnaqzDsTS FLCUy9FouxJ1Oe6aGvow7BcazU3N38fh5sFzHChFUwDSbNn8SNnxmmQ6Sw7pIAL3x5HjPkWYqlc s0hLd52M X-Google-Smtp-Source: AGHT+IF8RC/+GZEDclJJCvf6VzrlYKa6blK5F29amI6V6WQnB5TzMJSe5092EESxCt6acxqa4ez+BQ== X-Received: by 2002:a05:6a21:47c1:b0:1e1:e2d8:fd3a with SMTP id adf61e73a8af0-1e1e2d8fd4cmr13975584637.35.1734310201680; Sun, 15 Dec 2024 16:50:01 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Peter Maydell , Andrey Smirnov , "Michael S. Tsirkin" , Marcel Apfelbaum , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-arm@nongnu.org (open list:MCIMX7D SABRE / i...), Jason Chien Subject: [RFC PATCH 5/6] hw/riscv/riscv-iommu: Acquire device IDs dynamically Date: Mon, 16 Dec 2024 08:48:56 +0800 Message-ID: <20241216004857.9367-6-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20241216004857.9367-1-jason.chien@sifive.com> References: <20241216004857.9367-1-jason.chien@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=jason.chien@sifive.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1734310288824116600 Content-Type: text/plain; charset="utf-8" When all memory transactions from a PCIe host write to the same IOMMU memory region, we need to distinguish the source device dynamically. Signed-off-by: Jason Chien Reviewed-by: Daniel Henrique Barboza --- hw/riscv/riscv-iommu.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c index f5d53a36b2..e4b7008306 100644 --- a/hw/riscv/riscv-iommu.c +++ b/hw/riscv/riscv-iommu.c @@ -48,6 +48,7 @@ struct RISCVIOMMUSpace { RISCVIOMMUState *iommu; /* Managing IOMMU device state */ uint32_t devid; /* Requester identifier, AKA device_id */ bool notifier; /* IOMMU unmap notifier enabled */ + bool dynamic_devid; /* Acquiring device_id dynamically */ QLIST_ENTRY(RISCVIOMMUSpace) list; }; =20 @@ -1184,7 +1185,8 @@ static void riscv_iommu_ctx_put(RISCVIOMMUState *s, v= oid *ref) } =20 /* Find or allocate address space for a given device */ -static AddressSpace *riscv_iommu_space(RISCVIOMMUState *s, uint32_t devid) +static AddressSpace *riscv_iommu_space(RISCVIOMMUState *s, uint32_t devid, + bool dynamic) { RISCVIOMMUSpace *as; =20 @@ -1203,6 +1205,7 @@ static AddressSpace *riscv_iommu_space(RISCVIOMMUStat= e *s, uint32_t devid) =20 as->iommu =3D s; as->devid =3D devid; + as->dynamic_devid =3D dynamic; =20 snprintf(name, sizeof(name), "riscv-iommu-%04x:%02x.%d-iova", PCI_BUS_NUM(as->devid), PCI_SLOT(as->devid), PCI_FUNC(as->devi= d)); @@ -2415,7 +2418,8 @@ static AddressSpace *riscv_iommu_find_as(PCIBus *bus,= void *opaque, int devfn) =20 /* Find first matching IOMMU */ while (s !=3D NULL && as =3D=3D NULL) { - as =3D riscv_iommu_space(s, PCI_BUILD_BDF(pci_bus_num(bus), devfn)= ); + as =3D riscv_iommu_space(s, PCI_BUILD_BDF(pci_bus_num(bus), devfn), + false); s =3D s->iommus.le_next; } =20 @@ -2438,11 +2442,10 @@ void riscv_iommu_pci_setup_iommu(RISCVIOMMUState *i= ommu, PCIBus *bus, pci_setup_iommu(bus, &riscv_iommu_ops, iommu); } else if (bus->iommu_ops && bus->iommu_ops->set_memory_region) { /* - * TODO: * All memory transactions of this bus will be directed to this AS. * We need to distinguish the source device dynamically. */ - AddressSpace *as =3D riscv_iommu_space(iommu, 0); + AddressSpace *as =3D riscv_iommu_space(iommu, 0, true); pci_setup_iommu_downstream_mem(bus, as->root); } else { error_setg(errp, "can't register secondary IOMMU for PCI bus #%d", @@ -2453,6 +2456,12 @@ void riscv_iommu_pci_setup_iommu(RISCVIOMMUState *io= mmu, PCIBus *bus, static int riscv_iommu_memory_region_index(IOMMUMemoryRegion *iommu_mr, MemTxAttrs attrs) { + RISCVIOMMUSpace *as =3D container_of(iommu_mr, RISCVIOMMUSpace, iova_m= r); + + if (as->dynamic_devid) { + as->devid =3D attrs.requester_id; + } + return attrs.unspecified ? RISCV_IOMMU_NOPROCID : (int)attrs.pid; } =20 --=20 2.43.2 From nobody Wed Apr 9 01:13:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=sifive.com ARC-Seal: i=1; a=rsa-sha256; t=1734310290; cv=none; d=zohomail.com; s=zohoarc; b=Z8BveJMwG8q3VsYLFxBiAB6JGzErvqqFjvMohPotCI4ig5l99XMHjd5EAF7vwbwIa4itdjGWtxP0fKk/EYIGC+pWycW/LOkv9/aLKCKFwmB2Gnw2HZJC4ZJlZn1Bi8GeTrUbyqOgdpiJfOxGG2xiagL+cE+GO/r7WSQcpgSE6mA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734310290; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FWmGdfs7I/39bU6vTy0i46WBke+O98sxD/aRcDZSQXA=; b=BcqbJB71qNVU+kWd0p8Wrj6m/nBqD0EpwquynrEgzEPtiqTtwrFEGlIKgiAOM/4J8srf8ut4FxFuQsn4oelLdu+4YK04alf5dfdNoWSHPZwtG05Fw4F9zgK/QFLH3ozpIxOoFmLQOFfkIn0V6TqiLxOgpPbY2dJYH5AB+nij+lQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1734310290886546.6084941050119; Sun, 15 Dec 2024 16:51:30 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMzJO-0001TY-9W; Sun, 15 Dec 2024 19:50:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMzJM-0001S2-BI for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:12 -0500 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMzJK-0007JZ-7y for qemu-devel@nongnu.org; Sun, 15 Dec 2024 19:50:12 -0500 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-728f1e66418so2885876b3a.2 for ; Sun, 15 Dec 2024 16:50:09 -0800 (PST) Received: from hsinchu16.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-801d5addbf9sm3059586a12.47.2024.12.15.16.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2024 16:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1734310208; x=1734915008; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FWmGdfs7I/39bU6vTy0i46WBke+O98sxD/aRcDZSQXA=; b=BEtw417p0hbGy2kmGzuSeU97E0qDM6CoKLm5ZZUe6/GsGhtHD6yWVRoIIgfW+JqQkW qEdUIcATUmN3gHqbXIA13AXG4Ln3zwExn4lxKq/LgUwMsdNVlCrJouGvcU5nQD/iOXQC EBtkdzwEryWQfnBMaLTQFPi8TTXlwhT66nv2YerUd3zXcD71uhbCn/jzK2DRbffqP+Hn x8taTB3HysBOtjZleMrzoauCbmj/t0hLJkNXlBDmJlYcqSntGp5iKd8QKeqmUyjZbiJQ fHxRcybq3TMbcDB9w3E9VLNUBxDbImvzYwF0I/4+rM44OOYap5w/AAH2r2NCcFYFrajN UFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734310208; x=1734915008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FWmGdfs7I/39bU6vTy0i46WBke+O98sxD/aRcDZSQXA=; b=mr1Q0icLqPw81LqHrD497dYGcyWttw8TK3YqZoGpvbG3CONk+nhKefZfeD1zIhVfTv xK66R+UiM70bDm2kD2HsQeEJd9OlUrCvBZTPCqccLUY1PRkGs+PSVfyNk+MLO7wq8UBB HLwkQI5VhMZz0hK8Jbwu5SdzfWHKNFLl/hBybrrypYmvFpugUO2dsd2TKo3lbnqHYwGU XU2Fg66WbM2SYfcmycXyXIvErx4TcL/GjRXxhtnyhSiK/SkwXGUThvHxB+wxfxe01ZVT 8/m3D+zfPn3sFQ7lKiWzFCPdx+35ihcgb+FMYY936vgBDq9Pgcd4dslJIMTRIvU6Gfds mXvw== X-Gm-Message-State: AOJu0Yz3z3ZenQmh5Pqyhx3Ygz8UzR5wOd9cGZgnpNIIs+aeoLJqQs7d i5ypITCVaSxdq8xbq0Pii2P5k0bPsRBWtsvwNUPnlVzMP7zBEUji4HIoi9pKmZaI5vEahg5Ohvp 9ebUMt5zZWOMoygumk2pi6BuLPTRF/w+nmJ5NgdHzolJQ97MtVnsnYf6T3qZM+0FqRiBFBm1xKz 7UgWE9/lwj8NGpQYi8fQIY2B/jAZu3K7Nax36+oWF5wPgdik4= X-Gm-Gg: ASbGncvS0qxYjePezCS3cTGmEnbmzZ3Pws+XccW2fy9yAK4qAUGv+9YJfOiWc4Rt/oa HSSWp/oKrh3JbxVSbd1m4YMoeMIaQf/4saa025fR2/NMgDb+rvc+2A+4IID8UY4fBvAfFo9X6As KZTCQ4GlgpSkBjU6GKqQAqrr7Qj63ek7okDEY6vyqUbGZLIG8q7BmPGrUmfeP6b10xQ1xd4DzuM CHfxtNRAoL/opY69Nt/uCI8dN28Qezn9cOTRzOpoLCjohQliPsTGlE7G4725WepYHgeCWKNql3w NWsMzc3W X-Google-Smtp-Source: AGHT+IEUS1j5PJe2vcxu53unoG7gkVeDB2mRvah5pKoextxKD6OEt13xB3poaEE9+1mKa223oiQq8g== X-Received: by 2002:a05:6a21:7185:b0:1e1:f281:8cfd with SMTP id adf61e73a8af0-1e1f281925dmr8531798637.15.1734310207905; Sun, 15 Dec 2024 16:50:07 -0800 (PST) From: Jason Chien To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Peter Maydell , Andrey Smirnov , "Michael S. Tsirkin" , Marcel Apfelbaum , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , qemu-arm@nongnu.org (open list:MCIMX7D SABRE / i...), Jason Chien Subject: [RFC PATCH 6/6] include/hw/pci: Send PCI dma requests with memory attributes containing BDF Date: Mon, 16 Dec 2024 08:48:57 +0800 Message-ID: <20241216004857.9367-7-jason.chien@sifive.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20241216004857.9367-1-jason.chien@sifive.com> References: <20241216004857.9367-1-jason.chien@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=jason.chien@sifive.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @sifive.com) X-ZM-MESSAGEID: 1734310292477116600 Content-Type: text/plain; charset="utf-8" In order to distinguish which PCIe device sends the request over the IOMMU, the requester_id must be set with the BDF of the device. Signed-off-by: Jason Chien --- include/hw/pci/pci_device.h | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/pci_device.h b/include/hw/pci/pci_device.h index 8eaf0d58bb..e22d05dae8 100644 --- a/include/hw/pci/pci_device.h +++ b/include/hw/pci/pci_device.h @@ -263,8 +263,11 @@ static inline MemTxResult pci_dma_rw(PCIDevice *dev, d= ma_addr_t addr, static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr, void *buf, dma_addr_t len) { + MemTxAttrs attrs =3D {}; + attrs.requester_id =3D pci_requester_id(dev); + return pci_dma_rw(dev, addr, buf, len, - DMA_DIRECTION_TO_DEVICE, MEMTXATTRS_UNSPECIFIED); + DMA_DIRECTION_TO_DEVICE, attrs); } =20 /** @@ -282,8 +285,11 @@ static inline MemTxResult pci_dma_read(PCIDevice *dev,= dma_addr_t addr, static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr, const void *buf, dma_addr_t len) { + MemTxAttrs attrs =3D {}; + attrs.requester_id =3D pci_requester_id(dev); + return pci_dma_rw(dev, addr, (void *) buf, len, - DMA_DIRECTION_FROM_DEVICE, MEMTXATTRS_UNSPECIFIED); + DMA_DIRECTION_FROM_DEVICE, attrs); } =20 #define PCI_DMA_DEFINE_LDST(_l, _s, _bits) \ @@ -327,8 +333,11 @@ PCI_DMA_DEFINE_LDST(q_be, q_be, 64); static inline void *pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t *plen, DMADirection dir) { + MemTxAttrs attrs =3D {}; + attrs.requester_id =3D pci_requester_id(dev); + return dma_memory_map(pci_get_address_space(dev), addr, plen, dir, - MEMTXATTRS_UNSPECIFIED); + attrs); } =20 static inline void pci_dma_unmap(PCIDevice *dev, void *buffer, dma_addr_t = len, --=20 2.43.2