From nobody Sun May 11 21:18:48 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=linaro.org
ARC-Seal: i=1; a=rsa-sha256; t=1734114287; cv=none;
d=zohomail.com; s=zohoarc;
b=QfOso7IWmUWyDNHDUOK2bBQNxaFeE5kEjzaLpKbR33ExvpRAzkcHs57JefO9M0hVr7vFkvadsRJmRfXoj0+P5ubqzLXhjgIsHwNp1+h1bWT9EYe4UsTFU4BqO1fGszgzYk/wXmJdx0Rtu8QdEQt3nROIEZuF1ARS/9flRNj00DI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1734114287;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To;
bh=BIp3bm7eaOQPJUGY0JTu0QvOZnZ5ww3rT8F41d6Hrko=;
b=QB2CqJnGFTra5Q7iwxXGxDdl3iyJc3F/wiPPjHUAlVwu6Ywsh1ekhfl8lmhKqhUevwX3RKOrZ5g0K8MA8W5+wg+U82GlLstgoQDE7ONdEP+34YL1S4hZJKrwg2ilRR5JEXcasYXGtaH+OQC3Sg1XOJqPqh4Tk33pnDPwhPcwWi8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<peter.maydell@linaro.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1734114287303380.80987997017337;
Fri, 13 Dec 2024 10:24:47 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tMAKO-0007o5-RE; Fri, 13 Dec 2024 13:23:53 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
id 1tMAKG-0007mi-Kx
for qemu-devel@nongnu.org; Fri, 13 Dec 2024 13:23:44 -0500
Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
id 1tMAKD-0004A1-16
for qemu-devel@nongnu.org; Fri, 13 Dec 2024 13:23:44 -0500
Received: by mail-wm1-x32d.google.com with SMTP id
5b1f17b1804b1-4361e89b6daso14610285e9.3
for <qemu-devel@nongnu.org>; Fri, 13 Dec 2024 10:23:40 -0800 (PST)
Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-388c801acf2sm196531f8f.52.2024.12.13.10.23.38
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 13 Dec 2024 10:23:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1734114219; x=1734719019; darn=nongnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=BIp3bm7eaOQPJUGY0JTu0QvOZnZ5ww3rT8F41d6Hrko=;
b=vMCUjCH6OKsZx20ECTg2hlquG//ss6+lISVzIeIDlj+fwv2dUd5L0b0IgLXIiKcrNm
6rrd3UfFumi8v/vu8fViE+T27X/MPIF2ExpcOVSh/4jv0p8/0vPypUrE5eyFNx0k81kh
sZKrGzUxS8Ld1TIdSPoPuFPUOaPMW/+JenBUU3pUqpjw3nUp0Vj7owS71FbLHhpYei5C
5azvuBuyrXdEQDb4HQunkeDY+hJT8qV6LLl+4oYoVOypHn1p8ryL1FkrrPknNkfksi2I
+Mx/kHripbu8oh7iP5l1Yz+kavTOyceQ1QLCR+szc3Sa248S+4B6z7tRj8kXV3tMR2Lk
u7ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1734114219; x=1734719019;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=BIp3bm7eaOQPJUGY0JTu0QvOZnZ5ww3rT8F41d6Hrko=;
b=kF16+afbUcPrkZVqVzG+7SLX5K9F8lgZnjU2k5YmpJZbcmoc/toLPdPaZpVQz1VzoV
Tgf2qY7SqWcPXn3i+a0rbO9PyseBZw6EXX0LXPbjCm8/F1JJ7BPQ1Y/DqM+TunWf/sQ7
/10EpU/dA2YCfNjKgWMWttW71qIA39E4gNR4RhtTFeRXbVvQn23c9wJ57pGMRYB9rTsz
MZWhsY4Fd4fuA4A0Zm2cA/VOMkSgibAL9eNk5XfiTfgnocQN6lXVntEZnn/fwGgzdTM9
xVXl4pFZGVHJhTYQ5+hpKDDuPwei+dTv+CZLaIifCmibgxYLU5PY4WYVDWEi6iEkTzY4
EGLw==
X-Forwarded-Encrypted: i=1;
AJvYcCUzcsLzeAjOpnvQlBDRY7Re+7tNc5RFAILZNiw/n7MxsL9t8KpWvdbc5MF7bURUZ94ugjsd86Of/Cim@nongnu.org
X-Gm-Message-State: AOJu0Ywnh0BY01YYdsFgpq1JTwf45n/Z4lSZ9apB9UMGrDzCydyJW2oh
NXYrFMRgnzIAGciAd3cTWqvmpMm9kEoO1XT3cGXlghNK4MHuzV6kz5Kj73lcWjo=
X-Gm-Gg: ASbGncsNvVtLwUXQPy73sEwbc3cUAY480su8PCzDI/CWWFHBHYTXn6yCUoId5dw4kBv
Xcepd+VuNUHucxOxPlWg1XGZ6A6JzaNkN2l6K/Htr3szF8ERmWOvqC6Ow42dn5OAQEib93HEvKy
GJoqM/hWPYG3xsaQP8lcU61hcIYHSIIUUCaQe72baADgTQBOQ7GN61m/5z1zAIGa5aH8B1T4/NT
P0H5jsqWYJ9JwU/rcX+9sTj+p66Bx2Dq1RvZ0uyZagPlUDTBrBnWRo6/P7h4TM=
X-Google-Smtp-Source:
AGHT+IHOpnXiCIFfHd19bKQVPC270WIz2O318CRA5AAS/Ye/PEB1NfjZ87v5IScvp2P9Gvufq1gFIQ==
X-Received: by 2002:a05:6000:1864:b0:385:df73:2f24 with SMTP id
ffacd0b85a97d-3888e0f2d5bmr3125859f8f.39.1734114219068;
Fri, 13 Dec 2024 10:23:39 -0800 (PST)
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: [PATCH] hw/intc/arm_gicv3_its: Zero initialize local DTEntry etc
structs
Date: Fri, 13 Dec 2024 18:23:37 +0000
Message-Id: <20241213182337.3343068-1-peter.maydell@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2a00:1450:4864:20::32d;
envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: pass (identity @linaro.org)
X-ZM-MESSAGEID: 1734114289460116600
Content-Type: text/plain; charset="utf-8"
In the GICv3 ITS model, we have a common coding pattern which has a
local C struct like "DTEntry dte", which is a C representation of an
in-guest-memory data structure, and we call a function such as
get_dte() to read guest memory and fill in the C struct. These
functions to read in the struct sometimes have cases where they will
leave early and not fill in the whole struct (for instance get_dte()
will set "dte->valid =3D false" and nothing else for the case where it
is passed an entry_addr implying that there is no L2 table entry for
the DTE). This then causes potential use of uninitialized memory
later, for instance when we call a trace event which prints all the
fields of the struct. Sufficiently advanced compilers may produce
-Wmaybe-uninitialized warnings about this, especially if LTO is
enabled.
Rather than trying to carefully separate out these trace events into
"only the 'valid' field is initialized" and "all fields can be
printed", zero-init all the structs when we define them. None of
these structs are large (the biggest is 24 bytes) and having
consistent behaviour is less likely to be buggy.
Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2718
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daud=C3=A9 <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/intc/arm_gicv3_its.c | 44 ++++++++++++++++++++---------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index bf31158470e..752322a3e7e 100644
--- a/hw/intc/arm_gicv3_its.c
+++ b/hw/intc/arm_gicv3_its.c
@@ -465,7 +465,7 @@ static ItsCmdResult lookup_vte(GICv3ITSState *s, const =
char *who,
static ItsCmdResult process_its_cmd_phys(GICv3ITSState *s, const ITEntry *=
ite,
int irqlevel)
{
- CTEntry cte;
+ CTEntry cte =3D {};
ItsCmdResult cmdres;
=20
cmdres =3D lookup_cte(s, __func__, ite->icid, &cte);
@@ -479,7 +479,7 @@ static ItsCmdResult process_its_cmd_phys(GICv3ITSState =
*s, const ITEntry *ite,
static ItsCmdResult process_its_cmd_virt(GICv3ITSState *s, const ITEntry *=
ite,
int irqlevel)
{
- VTEntry vte;
+ VTEntry vte =3D {};
ItsCmdResult cmdres;
=20
cmdres =3D lookup_vte(s, __func__, ite->vpeid, &vte);
@@ -514,8 +514,8 @@ static ItsCmdResult process_its_cmd_virt(GICv3ITSState =
*s, const ITEntry *ite,
static ItsCmdResult do_process_its_cmd(GICv3ITSState *s, uint32_t devid,
uint32_t eventid, ItsCmdType cmd)
{
- DTEntry dte;
- ITEntry ite;
+ DTEntry dte =3D {};
+ ITEntry ite =3D {};
ItsCmdResult cmdres;
int irqlevel;
=20
@@ -583,8 +583,8 @@ static ItsCmdResult process_mapti(GICv3ITSState *s, con=
st uint64_t *cmdpkt,
uint32_t pIntid =3D 0;
uint64_t num_eventids;
uint16_t icid =3D 0;
- DTEntry dte;
- ITEntry ite;
+ DTEntry dte =3D {};
+ ITEntry ite =3D {};
=20
devid =3D (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT;
eventid =3D cmdpkt[1] & EVENTID_MASK;
@@ -651,8 +651,8 @@ static ItsCmdResult process_vmapti(GICv3ITSState *s, co=
nst uint64_t *cmdpkt,
{
uint32_t devid, eventid, vintid, doorbell, vpeid;
uint32_t num_eventids;
- DTEntry dte;
- ITEntry ite;
+ DTEntry dte =3D {};
+ ITEntry ite =3D {};
=20
if (!its_feature_virtual(s)) {
return CMD_CONTINUE;
@@ -761,7 +761,7 @@ static bool update_cte(GICv3ITSState *s, uint16_t icid,=
const CTEntry *cte)
static ItsCmdResult process_mapc(GICv3ITSState *s, const uint64_t *cmdpkt)
{
uint16_t icid;
- CTEntry cte;
+ CTEntry cte =3D {};
=20
icid =3D cmdpkt[2] & ICID_MASK;
cte.valid =3D cmdpkt[2] & CMD_FIELD_VALID_MASK;
@@ -822,7 +822,7 @@ static bool update_dte(GICv3ITSState *s, uint32_t devid=
, const DTEntry *dte)
static ItsCmdResult process_mapd(GICv3ITSState *s, const uint64_t *cmdpkt)
{
uint32_t devid;
- DTEntry dte;
+ DTEntry dte =3D {};
=20
devid =3D (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT;
dte.size =3D cmdpkt[1] & SIZE_MASK;
@@ -886,9 +886,9 @@ static ItsCmdResult process_movi(GICv3ITSState *s, cons=
t uint64_t *cmdpkt)
{
uint32_t devid, eventid;
uint16_t new_icid;
- DTEntry dte;
- CTEntry old_cte, new_cte;
- ITEntry old_ite;
+ DTEntry dte =3D {};
+ CTEntry old_cte =3D {}, new_cte =3D {};
+ ITEntry old_ite =3D {};
ItsCmdResult cmdres;
=20
devid =3D FIELD_EX64(cmdpkt[0], MOVI_0, DEVICEID);
@@ -965,7 +965,7 @@ static bool update_vte(GICv3ITSState *s, uint32_t vpeid=
, const VTEntry *vte)
=20
static ItsCmdResult process_vmapp(GICv3ITSState *s, const uint64_t *cmdpkt)
{
- VTEntry vte;
+ VTEntry vte =3D {};
uint32_t vpeid;
=20
if (!its_feature_virtual(s)) {
@@ -1030,7 +1030,7 @@ static void vmovp_callback(gpointer data, gpointer op=
aque)
*/
GICv3ITSState *s =3D data;
VmovpCallbackData *cbdata =3D opaque;
- VTEntry vte;
+ VTEntry vte =3D {};
ItsCmdResult cmdres;
=20
cmdres =3D lookup_vte(s, __func__, cbdata->vpeid, &vte);
@@ -1085,9 +1085,9 @@ static ItsCmdResult process_vmovi(GICv3ITSState *s, c=
onst uint64_t *cmdpkt)
{
uint32_t devid, eventid, vpeid, doorbell;
bool doorbell_valid;
- DTEntry dte;
- ITEntry ite;
- VTEntry old_vte, new_vte;
+ DTEntry dte =3D {};
+ ITEntry ite =3D {};
+ VTEntry old_vte =3D {}, new_vte =3D {};
ItsCmdResult cmdres;
=20
if (!its_feature_virtual(s)) {
@@ -1186,10 +1186,10 @@ static ItsCmdResult process_vinvall(GICv3ITSState *=
s, const uint64_t *cmdpkt)
static ItsCmdResult process_inv(GICv3ITSState *s, const uint64_t *cmdpkt)
{
uint32_t devid, eventid;
- ITEntry ite;
- DTEntry dte;
- CTEntry cte;
- VTEntry vte;
+ ITEntry ite =3D {};
+ DTEntry dte =3D {};
+ CTEntry cte =3D {};
+ VTEntry vte =3D {};
ItsCmdResult cmdres;
=20
devid =3D FIELD_EX64(cmdpkt[0], INV_0, DEVICEID);
--=20
2.34.1