From nobody Thu Dec 18 22:21:55 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1733907885; cv=none; d=zohomail.com; s=zohoarc; b=TDBRhAsENgm/A+DBXubTx1bdz3xUemklcoaYst5LwRQUucPPfk1AL0+ZYCfCcYkAunWUCkIAsVjcqLMpxxy07Z/2DRUTMLGDs+NvhOMVHvhH500DkIN8VRZpTkfSmVB4IUQtYScHca/vnxv2TNpL3QfPLxsU9vMc2gzoqNvxwpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1733907885; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7mlVIiG13/tbUMo21z0k+/O6LtbmPJ2rEbOCtEO40y0=; b=F5xhR557t1N1cE/s1m6051w+qO08XlT1xiHp1xslQQF+mJqz7ju0TxI439NE4tN4iQiUqh2Q5ecW0BMhE/8BMaeoSUizgzsFe4qjw2EGjAuIDUUdSrmGI/6w9RDv7H5R5ZtG1HEZTyqCRiJ9EXNPm4vjS2T/R7PyLVy3wxl15Gs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1733907885382885.972252927795; Wed, 11 Dec 2024 01:04:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLIbw-0008RK-5h; Wed, 11 Dec 2024 04:02:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLIbV-0006kb-9e for qemu-devel@nongnu.org; Wed, 11 Dec 2024 04:01:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLIbP-0007wZ-Aj for qemu-devel@nongnu.org; Wed, 11 Dec 2024 04:01:55 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-de-KsTdDMrqq47YAaPaLmg-1; Wed, 11 Dec 2024 04:01:47 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9354C1955F45; Wed, 11 Dec 2024 09:01:46 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.186]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D80421956089; Wed, 11 Dec 2024 09:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733907710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7mlVIiG13/tbUMo21z0k+/O6LtbmPJ2rEbOCtEO40y0=; b=TNpXhdtI9lezXB/dNYPTlPoITuLRu2hdvdtTbiS0zHDTSBcNd0BQpblweCRy3UVZ/zs8CW 64tqM5/EPIcnIcLoJjnLkYfoKt4oWhiYHju+Skaw0FVAiivD5hLDqpZy7yKu5DJT2QtTW+ 7u7EEPTlS02YJYHDHEUZhPYTy5xdsw0= X-MC-Unique: de-KsTdDMrqq47YAaPaLmg-1 X-Mimecast-MFC-AGG-ID: de-KsTdDMrqq47YAaPaLmg From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Richard Henderson , Stefan Hajnoczi , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 26/26] tests/functional: remove pointless with statement Date: Wed, 11 Dec 2024 10:00:10 +0100 Message-ID: <20241211090014.619351-27-thuth@redhat.com> In-Reply-To: <20241211090014.619351-1-thuth@redhat.com> References: <20241211090014.619351-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.52, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1733907885971116600 From: Daniel P. Berrang=C3=A9 The xorriso command directly writes to 'filename', so the surrounding 'with' statement is pointless. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20241129173120.761728-5-berrange@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/test_ppc64_hv.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/functional/test_ppc64_hv.py b/tests/functional/test_ppc6= 4_hv.py index 312248bbfe..d97b62e364 100755 --- a/tests/functional/test_ppc64_hv.py +++ b/tests/functional/test_ppc64_hv.py @@ -72,10 +72,9 @@ def extract_from_iso(self, iso, path): cwd =3D os.getcwd() os.chdir(self.workdir) =20 - with open(filename, "w") as outfile: - cmd =3D "xorriso -osirrox on -indev %s -cpx %s %s" % (iso, pat= h, filename) - subprocess.run(cmd.split(), - stdout=3Dsubprocess.DEVNULL, stderr=3Dsubproces= s.DEVNULL) + cmd =3D "xorriso -osirrox on -indev %s -cpx %s %s" % (iso, path, f= ilename) + subprocess.run(cmd.split(), + stdout=3Dsubprocess.DEVNULL, stderr=3Dsubprocess.DE= VNULL) =20 os.chmod(filename, 0o600) os.chdir(cwd) --=20 2.47.1