From nobody Mon May 12 17:14:39 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=fail;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=nongnu.org
ARC-Seal: i=1; a=rsa-sha256; t=1733500710; cv=none;
d=zohomail.com; s=zohoarc;
b=TAOuWce1LjRFJRlFxGEk3pc31Z38/KOWsGU6TUaa6oAe7+ilwkGy4EfIl2vQtWNheLptSWukn5no72FojBbmKDysh0tSZ20yc9UrznzApdEmrCRD7voS0ujpKH49QmutwOl1vL3MUmzhXgov/RCAcK+zlRJSSUZxFORLfINw3NY=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1733500710;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id;
bh=KcRrFCO4r/Yewot09j0MuLn8OUsl3XwyWAh3NQkRkJ8=;
b=CeIhMiyLPb7q72fgaIOgYZW4yp1K8rpbjufTpA8XIt1pQ0JV1iJ2VEuF8lo/oRz6p/p3XfM2Q8dZPommDx/H1v1hS57tRbhV7supO8dzjcgc8sBQhZZkxYCJahvYrUp8w+bq50Dg0zh3qQfvXsX+n6P92yKx2ldk5ObI8iCR/zw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=fail;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<qemu-devel@nongnu.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1733500710327320.9074077294466;
Fri, 6 Dec 2024 07:58:30 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tJaiW-0005CE-Ng; Fri, 06 Dec 2024 10:58:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <anjo@rev.ng>) id 1tJaiU-0005Bm-Lm
for qemu-devel@nongnu.org; Fri, 06 Dec 2024 10:58:06 -0500
Received: from rev.ng ([94.130.142.21])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <anjo@rev.ng>) id 1tJaiS-0005vB-8o
for qemu-devel@nongnu.org; Fri, 06 Dec 2024 10:58:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng;
s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post:
List-Help; bh=KcRrFCO4r/Yewot09j0MuLn8OUsl3XwyWAh3NQkRkJ8=; b=S2doNi9O3UI8woa
bfYG1s1r9Db2+pQESGh9FaZv2gOI4RApkSmUibMjUs9D8TBMnH/X6rfr92lTGaD2UM4Da8Bzb/FyK
98AGRSIWq7l1qiNqNGxXbnrc+O9QJmxrqPsqjXkEdhTWhkUj1mDNtT5vHrEoSbVzOguUsPokd/c5Z
lQ=;
To: qemu-devel@nongnu.org
Cc: ale@rev.ng,
ltaylorsimpson@gmail.com,
brian.cain@oss.qualcomm.com
Subject: [PATCH 1/2] target/hexagon: Use argparse in all python scripts
Date: Fri, 6 Dec 2024 17:01:02 +0100
Message-ID: <20241206160103.24988-2-anjo@rev.ng>
In-Reply-To: <20241206160103.24988-1-anjo@rev.ng>
References: <20241206160103.24988-1-anjo@rev.ng>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=94.130.142.21; envelope-from=anjo@rev.ng;
helo=rev.ng
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Reply-to: Anton Johansson <anjo@rev.ng>
From: Anton Johansson via <qemu-devel@nongnu.org>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: fail (Header signature does not verify)
X-ZM-MESSAGEID: 1733500712514116600
Content-Type: text/plain; charset="utf-8"
QOL commit, all the various gen_* python scripts take a large set
arguments where order is implicit. Using argparse we also get decent
error messages if a field is missing or too many are added.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
target/hexagon/gen_analyze_funcs.py | 6 +++--
target/hexagon/gen_decodetree.py | 19 +++++++++++---
target/hexagon/gen_helper_funcs.py | 7 +++---
target/hexagon/gen_helper_protos.py | 7 +++---
target/hexagon/gen_idef_parser_funcs.py | 11 +++++++--
target/hexagon/gen_op_attribs.py | 11 +++++++--
target/hexagon/gen_opcodes_def.py | 11 +++++++--
target/hexagon/gen_printinsn.py | 11 +++++++--
target/hexagon/gen_tcg_func_table.py | 11 +++++++--
target/hexagon/gen_tcg_funcs.py | 9 ++++---
target/hexagon/gen_trans_funcs.py | 18 +++++++++++---
target/hexagon/hex_common.py | 33 ++++++++++++-------------
target/hexagon/meson.build | 2 +-
13 files changed, 109 insertions(+), 47 deletions(-)
diff --git a/target/hexagon/gen_analyze_funcs.py b/target/hexagon/gen_analy=
ze_funcs.py
index 54bac19724..3ac7cc2cfe 100755
--- a/target/hexagon/gen_analyze_funcs.py
+++ b/target/hexagon/gen_analyze_funcs.py
@@ -78,11 +78,13 @@ def gen_analyze_func(f, tag, regs, imms):
=20
=20
def main():
- hex_common.read_common_files()
+ args =3D hex_common.parse_common_args(
+ "Emit functions analyzing register accesses"
+ )
tagregs =3D hex_common.get_tagregs()
tagimms =3D hex_common.get_tagimms()
=20
- with open(sys.argv[-1], "w") as f:
+ with open(args.out, "w") as f:
f.write("#ifndef HEXAGON_ANALYZE_FUNCS_C_INC\n")
f.write("#define HEXAGON_ANALYZE_FUNCS_C_INC\n\n")
=20
diff --git a/target/hexagon/gen_decodetree.py b/target/hexagon/gen_decodetr=
ee.py
index a4fcd622c5..ce703af41d 100755
--- a/target/hexagon/gen_decodetree.py
+++ b/target/hexagon/gen_decodetree.py
@@ -24,6 +24,7 @@
import textwrap
import iset
import hex_common
+import argparse
=20
encs =3D {
tag: "".join(reversed(iset.iset[tag]["enc"].replace(" ", "")))
@@ -191,8 +192,18 @@ def gen_decodetree_file(f, class_to_decode):
f.write(f"{tag}\t{enc_str} @{tag}\n")
=20
=20
+def main():
+ parser =3D argparse.ArgumentParser(
+ description=3D"Emit opaque macro calls with instruction semantics"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("class_to_decode", help=3D"instruction class to de=
code")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+
+ hex_common.read_semantics_file(args.semantics)
+ with open(args.out, "w") as f:
+ gen_decodetree_file(f, args.class_to_decode)
+
if __name__ =3D=3D "__main__":
- hex_common.read_semantics_file(sys.argv[1])
- class_to_decode =3D sys.argv[2]
- with open(sys.argv[3], "w") as f:
- gen_decodetree_file(f, class_to_decode)
+ main()
diff --git a/target/hexagon/gen_helper_funcs.py b/target/hexagon/gen_helper=
_funcs.py
index e9685bff2f..c1f806ac4b 100755
--- a/target/hexagon/gen_helper_funcs.py
+++ b/target/hexagon/gen_helper_funcs.py
@@ -102,12 +102,13 @@ def gen_helper_function(f, tag, tagregs, tagimms):
=20
=20
def main():
- hex_common.read_common_files()
+ args =3D hex_common.parse_common_args(
+ "Emit helper function definitions for each instruction"
+ )
tagregs =3D hex_common.get_tagregs()
tagimms =3D hex_common.get_tagimms()
=20
- output_file =3D sys.argv[-1]
- with open(output_file, "w") as f:
+ with open(args.out, "w") as f:
for tag in hex_common.tags:
## Skip the priv instructions
if "A_PRIV" in hex_common.attribdict[tag]:
diff --git a/target/hexagon/gen_helper_protos.py b/target/hexagon/gen_helpe=
r_protos.py
index fd2bfd0f36..77f8e0a6a3 100755
--- a/target/hexagon/gen_helper_protos.py
+++ b/target/hexagon/gen_helper_protos.py
@@ -52,12 +52,13 @@ def gen_helper_prototype(f, tag, tagregs, tagimms):
=20
=20
def main():
- hex_common.read_common_files()
+ args =3D hex_common.parse_common_args(
+ "Emit helper function prototypes for each instruction"
+ )
tagregs =3D hex_common.get_tagregs()
tagimms =3D hex_common.get_tagimms()
=20
- output_file =3D sys.argv[-1]
- with open(output_file, "w") as f:
+ with open(args.out, "w") as f:
for tag in hex_common.tags:
## Skip the priv instructions
if "A_PRIV" in hex_common.attribdict[tag]:
diff --git a/target/hexagon/gen_idef_parser_funcs.py b/target/hexagon/gen_i=
def_parser_funcs.py
index 72f11c68ca..2f6e826f76 100644
--- a/target/hexagon/gen_idef_parser_funcs.py
+++ b/target/hexagon/gen_idef_parser_funcs.py
@@ -20,6 +20,7 @@
import sys
import re
import string
+import argparse
from io import StringIO
=20
import hex_common
@@ -43,13 +44,19 @@
## them are inputs ("in" prefix), while some others are outputs.
##
def main():
- hex_common.read_semantics_file(sys.argv[1])
+ parser =3D argparse.ArgumentParser(
+ "Emit instruction implementations that can be fed to idef-parser"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+ hex_common.read_semantics_file(args.semantics)
hex_common.calculate_attribs()
hex_common.init_registers()
tagregs =3D hex_common.get_tagregs()
tagimms =3D hex_common.get_tagimms()
=20
- with open(sys.argv[-1], "w") as f:
+ with open(args.out, "w") as f:
f.write('#include "macros.h.inc"\n\n')
=20
for tag in hex_common.tags:
diff --git a/target/hexagon/gen_op_attribs.py b/target/hexagon/gen_op_attri=
bs.py
index 99448220da..bbbb02df3a 100755
--- a/target/hexagon/gen_op_attribs.py
+++ b/target/hexagon/gen_op_attribs.py
@@ -21,16 +21,23 @@
import re
import string
import hex_common
+import argparse
=20
=20
def main():
- hex_common.read_semantics_file(sys.argv[1])
+ parser =3D argparse.ArgumentParser(
+ "Emit opaque macro calls containing instruction attributes"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+ hex_common.read_semantics_file(args.semantics)
hex_common.calculate_attribs()
=20
##
## Generate all the attributes associated with each instruction
##
- with open(sys.argv[-1], "w") as f:
+ with open(args.out, "w") as f:
for tag in hex_common.tags:
f.write(
f"OP_ATTRIB({tag},ATTRIBS("
diff --git a/target/hexagon/gen_opcodes_def.py b/target/hexagon/gen_opcodes=
_def.py
index 536f0eb68a..94a19ff412 100755
--- a/target/hexagon/gen_opcodes_def.py
+++ b/target/hexagon/gen_opcodes_def.py
@@ -21,15 +21,22 @@
import re
import string
import hex_common
+import argparse
=20
=20
def main():
- hex_common.read_semantics_file(sys.argv[1])
+ parser =3D argparse.ArgumentParser(
+ description=3D"Emit opaque macro calls with instruction names"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+ hex_common.read_semantics_file(args.semantics)
=20
##
## Generate a list of all the opcodes
##
- with open(sys.argv[-1], "w") as f:
+ with open(args.out, "w") as f:
for tag in hex_common.tags:
f.write(f"OPCODE({tag}),\n")
=20
diff --git a/target/hexagon/gen_printinsn.py b/target/hexagon/gen_printinsn=
.py
index 8bf4d0985c..d5f969960a 100755
--- a/target/hexagon/gen_printinsn.py
+++ b/target/hexagon/gen_printinsn.py
@@ -21,6 +21,7 @@
import re
import string
import hex_common
+import argparse
=20
=20
##
@@ -96,11 +97,17 @@ def spacify(s):
=20
=20
def main():
- hex_common.read_semantics_file(sys.argv[1])
+ parser =3D argparse.ArgumentParser(
+ "Emit opaque macro calls with information for printing string repr=
esentations of instrucions"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+ hex_common.read_semantics_file(args.semantics)
=20
immext_casere =3D re.compile(r"IMMEXT\(([A-Za-z])")
=20
- with open(sys.argv[-1], "w") as f:
+ with open(args.out, "w") as f:
for tag in hex_common.tags:
if not hex_common.behdict[tag]:
continue
diff --git a/target/hexagon/gen_tcg_func_table.py b/target/hexagon/gen_tcg_=
func_table.py
index 978ac1819b..299a39b1aa 100755
--- a/target/hexagon/gen_tcg_func_table.py
+++ b/target/hexagon/gen_tcg_func_table.py
@@ -21,15 +21,22 @@
import re
import string
import hex_common
+import argparse
=20
=20
def main():
- hex_common.read_semantics_file(sys.argv[1])
+ parser =3D argparse.ArgumentParser(
+ "Emit opaque macro calls with instruction semantics"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+ hex_common.read_semantics_file(args.semantics)
hex_common.calculate_attribs()
tagregs =3D hex_common.get_tagregs()
tagimms =3D hex_common.get_tagimms()
=20
- with open(sys.argv[-1], "w") as f:
+ with open(args.out, "w") as f:
f.write("#ifndef HEXAGON_FUNC_TABLE_H\n")
f.write("#define HEXAGON_FUNC_TABLE_H\n\n")
=20
diff --git a/target/hexagon/gen_tcg_funcs.py b/target/hexagon/gen_tcg_funcs=
.py
index 05aa0a7855..c2ba91ddc0 100755
--- a/target/hexagon/gen_tcg_funcs.py
+++ b/target/hexagon/gen_tcg_funcs.py
@@ -108,15 +108,16 @@ def gen_def_tcg_func(f, tag, tagregs, tagimms):
=20
=20
def main():
- is_idef_parser_enabled =3D hex_common.read_common_files()
+ args =3D hex_common.parse_common_args(
+ "Emit functions calling generated code implementing instruction se=
mantics (helpers, idef-parser)"
+ )
tagregs =3D hex_common.get_tagregs()
tagimms =3D hex_common.get_tagimms()
=20
- output_file =3D sys.argv[-1]
- with open(output_file, "w") as f:
+ with open(args.out, "w") as f:
f.write("#ifndef HEXAGON_TCG_FUNCS_H\n")
f.write("#define HEXAGON_TCG_FUNCS_H\n\n")
- if is_idef_parser_enabled:
+ if args.idef_parser:
f.write('#include "idef-generated-emitter.h.inc"\n\n')
=20
for tag in hex_common.tags:
diff --git a/target/hexagon/gen_trans_funcs.py b/target/hexagon/gen_trans_f=
uncs.py
index 30f0c73e0c..45da1b7b5d 100755
--- a/target/hexagon/gen_trans_funcs.py
+++ b/target/hexagon/gen_trans_funcs.py
@@ -24,6 +24,7 @@
import textwrap
import iset
import hex_common
+import argparse
=20
encs =3D {
tag: "".join(reversed(iset.iset[tag]["enc"].replace(" ", "")))
@@ -136,8 +137,19 @@ def gen_trans_funcs(f):
"""))
=20
=20
-if __name__ =3D=3D "__main__":
- hex_common.read_semantics_file(sys.argv[1])
+def main():
+ parser =3D argparse.ArgumentParser(
+ description=3D"Emit trans_*() functions to be called by " \
+ "instruction decoder"
+ )
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("out", help=3D"output file")
+ args =3D parser.parse_args()
+ hex_common.read_semantics_file(args.semantics)
hex_common.init_registers()
- with open(sys.argv[2], "w") as f:
+ with open(args.out, "w") as f:
gen_trans_funcs(f)
+
+
+if __name__ =3D=3D "__main__":
+ main()
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index 15ed4980e4..758e5fd12d 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -21,6 +21,7 @@
import re
import string
import textwrap
+import argparse
=20
behdict =3D {} # tag ->behavior
semdict =3D {} # tag -> semantics
@@ -1181,22 +1182,20 @@ def helper_args(tag, regs, imms):
return args
=20
=20
-def read_common_files():
- read_semantics_file(sys.argv[1])
- read_overrides_file(sys.argv[2])
- read_overrides_file(sys.argv[3])
- ## Whether or not idef-parser is enabled is
- ## determined by the number of arguments to
- ## this script:
- ##
- ## 4 args. -> not enabled,
- ## 5 args. -> idef-parser enabled.
- ##
- ## The 5:th arg. then holds a list of the successfully
- ## parsed instructions.
- is_idef_parser_enabled =3D len(sys.argv) > 5
- if is_idef_parser_enabled:
- read_idef_parser_enabled_file(sys.argv[4])
+def parse_common_args(desc):
+ parser =3D argparse.ArgumentParser(desc)
+ parser.add_argument("semantics", help=3D"semantics file")
+ parser.add_argument("overrides", help=3D"overrides file")
+ parser.add_argument("overrides_vec", help=3D"vector overrides file")
+ parser.add_argument("out", help=3D"output file")
+ parser.add_argument("--idef-parser",
+ help=3D"file of instructions translated by idef-pa=
rser")
+ args =3D parser.parse_args()
+ read_semantics_file(args.semantics)
+ read_overrides_file(args.overrides)
+ read_overrides_file(args.overrides_vec)
+ if args.idef_parser:
+ read_idef_parser_enabled_file(args.idef_parser)
calculate_attribs()
init_registers()
- return is_idef_parser_enabled
+ return args
diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
index f1723778a6..bb4ebaae81 100644
--- a/target/hexagon/meson.build
+++ b/target/hexagon/meson.build
@@ -346,7 +346,7 @@ if idef_parser_enabled and 'hexagon-linux-user' in targ=
et_dirs
# Setup input and dependencies for the next step, this depends on whet=
her or
# not idef-parser is enabled
helper_dep =3D [semantics_generated, idef_generated_tcg_c, idef_genera=
ted_tcg]
- helper_in =3D [semantics_generated, gen_tcg_h, gen_tcg_hvx_h, idef_gen=
erated_list]
+ helper_in =3D [semantics_generated, gen_tcg_h, gen_tcg_hvx_h, '--idef-=
parser', idef_generated_list]
else
# Setup input and dependencies for the next step, this depends on whet=
her or
# not idef-parser is enabled
--=20
2.45.2
From nobody Mon May 12 17:14:39 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=fail;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=nongnu.org
ARC-Seal: i=1; a=rsa-sha256; t=1733500710; cv=none;
d=zohomail.com; s=zohoarc;
b=WbykSzXUMYn72/09721eqD3W4VElKRT2VInwAkW5zYw49SI9gLRGl7S0uJvTgB7wWobK9fGM06Tqpz61mTVS7IEGfqgCDHQsDAQH3WKnbY9OfN2MpzH/Zexaolq+VmoWJqCDzeukK1HLM+xgt1kU+Yi4wJC24U2fWd2vl49N4/0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1733500710;
h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id;
bh=+GyrpFav48lhtU23ViGd/fwW1Zc6BT+vEHvB6lQunNs=;
b=D0fcMBHJPv+vmzk2ddWbAXH+DC8ddj8aixUKJ00vSetV5hs1dqPt/gQb++8SDs+nL/9BhrTQo9h8Yn8iAiMgMIEJJg2e7YfPIKnEkwcVq7Wb4Bjbbe/Cq+xSctnrO8guFDkQbsb9vuGdkQBO1ZyfD5T0JGhamWsGdVSzsVyOr9Q=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=fail;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<qemu-devel@nongnu.org> (p=none dis=none)
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1733500710378778.1786021792011;
Fri, 6 Dec 2024 07:58:30 -0800 (PST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces@nongnu.org>)
id 1tJaiY-0005Co-E5; Fri, 06 Dec 2024 10:58:10 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <anjo@rev.ng>) id 1tJaiU-0005By-U9
for qemu-devel@nongnu.org; Fri, 06 Dec 2024 10:58:06 -0500
Received: from rev.ng ([94.130.142.21])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <anjo@rev.ng>) id 1tJaiS-0005vE-NM
for qemu-devel@nongnu.org; Fri, 06 Dec 2024 10:58:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng;
s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:
Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post:
List-Help; bh=+GyrpFav48lhtU23ViGd/fwW1Zc6BT+vEHvB6lQunNs=; b=NqflWYutYc2IeAK
MJCb+Ngs4gbXwr7bS8rT3+sA4MMRA902OVI+cEA28SHhU07o40OD+ZdPs9DtZJ6aCQcBdylKzNNrN
s2NTRsxZmZ1ZHS6b6+ZzwyfkSJh0xwf0itiLbYqGbvMHVPVthtczwem6T4n/EflEQXRmpkDJNDOWv
x8=;
To: qemu-devel@nongnu.org
Cc: ale@rev.ng,
ltaylorsimpson@gmail.com,
brian.cain@oss.qualcomm.com
Subject: [PATCH 2/2] target/hexagon: Make HVX vector args. restrict *
Date: Fri, 6 Dec 2024 17:01:03 +0100
Message-ID: <20241206160103.24988-3-anjo@rev.ng>
In-Reply-To: <20241206160103.24988-1-anjo@rev.ng>
References: <20241206160103.24988-1-anjo@rev.ng>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=94.130.142.21; envelope-from=anjo@rev.ng;
helo=rev.ng
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Reply-to: Anton Johansson <anjo@rev.ng>
From: Anton Johansson via <qemu-devel@nongnu.org>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org
X-ZohoMail-DKIM: fail (Header signature does not verify)
X-ZM-MESSAGEID: 1733500712111116600
Content-Type: text/plain; charset="utf-8"
Adds restrict qualifier to HVX pointer arguments. This will allow the
compiler to produce better optimized code, as input vectors are now
assumed not to alias, and no runtime aliasing checks will be required.
Signed-off-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
target/hexagon/mmvec/macros.h | 36 +++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/target/hexagon/mmvec/macros.h b/target/hexagon/mmvec/macros.h
index 1ceb9453ee..bcd4a1e897 100644
--- a/target/hexagon/mmvec/macros.h
+++ b/target/hexagon/mmvec/macros.h
@@ -23,26 +23,26 @@
#include "mmvec/system_ext_mmvec.h"
=20
#ifndef QEMU_GENERATE
-#define VdV (*(MMVector *)(VdV_void))
-#define VsV (*(MMVector *)(VsV_void))
-#define VuV (*(MMVector *)(VuV_void))
-#define VvV (*(MMVector *)(VvV_void))
-#define VwV (*(MMVector *)(VwV_void))
-#define VxV (*(MMVector *)(VxV_void))
-#define VyV (*(MMVector *)(VyV_void))
+#define VdV (*(MMVector *restrict)(VdV_void))
+#define VsV (*(MMVector *restrict)(VsV_void))
+#define VuV (*(MMVector *restrict)(VuV_void))
+#define VvV (*(MMVector *restrict)(VvV_void))
+#define VwV (*(MMVector *restrict)(VwV_void))
+#define VxV (*(MMVector *restrict)(VxV_void))
+#define VyV (*(MMVector *restrict)(VyV_void))
=20
-#define VddV (*(MMVectorPair *)(VddV_void))
-#define VuuV (*(MMVectorPair *)(VuuV_void))
-#define VvvV (*(MMVectorPair *)(VvvV_void))
-#define VxxV (*(MMVectorPair *)(VxxV_void))
+#define VddV (*(MMVectorPair *restrict)(VddV_void))
+#define VuuV (*(MMVectorPair *restrict)(VuuV_void))
+#define VvvV (*(MMVectorPair *restrict)(VvvV_void))
+#define VxxV (*(MMVectorPair *restrict)(VxxV_void))
=20
-#define QeV (*(MMQReg *)(QeV_void))
-#define QdV (*(MMQReg *)(QdV_void))
-#define QsV (*(MMQReg *)(QsV_void))
-#define QtV (*(MMQReg *)(QtV_void))
-#define QuV (*(MMQReg *)(QuV_void))
-#define QvV (*(MMQReg *)(QvV_void))
-#define QxV (*(MMQReg *)(QxV_void))
+#define QeV (*(MMQReg *restrict)(QeV_void))
+#define QdV (*(MMQReg *restrict)(QdV_void))
+#define QsV (*(MMQReg *restrict)(QsV_void))
+#define QtV (*(MMQReg *restrict)(QtV_void))
+#define QuV (*(MMQReg *restrict)(QuV_void))
+#define QvV (*(MMQReg *restrict)(QvV_void))
+#define QxV (*(MMQReg *restrict)(QxV_void))
#endif
=20
#define LOG_VTCM_BYTE(VA, MASK, VAL, IDX) \
--=20
2.45.2