From nobody Thu Dec 18 13:15:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1733218990; cv=none; d=zohomail.com; s=zohoarc; b=CCaP0DUdvz3c5nJuSBZy+1peFw+SNTihHiwdSmXuMO5PQcBOCT6Cvjm2PUjFjgZf0KuQb5pZGXXKmFx2JPk1qRUTbgdYFN+Wio1zfFSZWCX27bTuU9pxmoChLTd+hMTqWCcgtiIm4ApnOrpSptvraM2Su2yKxetQhLLJhY4+CF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1733218990; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5s5PWLTfQVptCG3HIJElGI4YVuaTaoJWIlnXWhqF62c=; b=VP/RiXnpMCxBAi4CyasJXCLVOustEODBdBDqJQMGt7Ap2NuOBu0nK1tVnwAMbho7PsMiwSNwTnD46QA8pObpj56vYMgMR8+HO7uPGPJFFeRGuROCQ6ahEc1zT05qWBZWN8jk+57uNORU8WsU61C5T+PloO/c/aZ1ljiRreYR8x0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1733218990493866.8480490263325; Tue, 3 Dec 2024 01:43:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIPQY-0001kI-0i; Tue, 03 Dec 2024 04:42:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIPQV-0001jm-NI for qemu-devel@nongnu.org; Tue, 03 Dec 2024 04:42:39 -0500 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIPQT-00052c-QV for qemu-devel@nongnu.org; Tue, 03 Dec 2024 04:42:39 -0500 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-434b3e32e9dso45190855e9.2 for ; Tue, 03 Dec 2024 01:42:36 -0800 (PST) Received: from localhost.localdomain ([176.187.209.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0f70cbfsm187271615e9.36.2024.12.03.01.42.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 03 Dec 2024 01:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733218955; x=1733823755; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5s5PWLTfQVptCG3HIJElGI4YVuaTaoJWIlnXWhqF62c=; b=b7pK5sVY6iUkJTPO/sLN5ddDJnI4h+xXEQVd2fp0GKDkpGsPsj24oF61JJAeKcv+H2 Fdi3VSgRgH2dfbucvknsnOgZVE9GMRBI0uDZIpgIGNmg34HHsbz+tXIwRwuV/pamCUz8 uLeJbT5CvxQsE4ufAwSJp+8m5v3f0ByApkL0ILMXFwoK82GwBPr8pH43WOnlyT05yllH TGqVLCq+UIVeB4ddg21Og+34RPyp+X6G3rwafBjymzTOzRzIMI+Y+NKcg4KPZAJazzu2 yCBrp5DAhwafuKfVLZAuYEi/yr3ucyDytRiOPadHPtBvg3uu2V236npNsNMnCYc2O4G0 o/qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733218955; x=1733823755; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5s5PWLTfQVptCG3HIJElGI4YVuaTaoJWIlnXWhqF62c=; b=YSMWowdw00Hi31xcjZvM227eEo5MlScB2vHewY8mXcqYuAlpKeckGaLsE775gsQ0cB ngMruuY1Z2YYkf9tBaVjpjDmO6Gc1L2zyad5dA8xYHL5QkQ4Uzv5i5vZTH8GeM8tyU+p DPLLMyo6lQo8jjbHpCEBtO6K6C+rQMVhRiKgHyHKnswVToKnUqg5Jc/RCA4AfXnEyhmU xXwGj4OW5w4G1H4rdGV6s3kG2MtSmdB9bpwGLRxDrJD9KcRY30poH/l0MH8B8ojK6dSn uqggtG8LMYGwqgDEUEeOBX/WJAGHuadBEcUyKy+0Pktljk26OadgN7ICzOGinq2lOnkv 1+Aw== X-Gm-Message-State: AOJu0Yyb/0PEs2TFrqhXusyDBqSuRyEyxundYq9uSABVp3lfnRh4Z59p DqFEE9XhAJWAFG7HXIcRMiYvdp6ezoieIpFUTZ6u00BRQTabED/kOCFKi0SsVVkKU/PY3aAapXZ SQos= X-Gm-Gg: ASbGncs1bGv/OPx8pVmFLCob3TaU6rvZ5WgwScTVx7Qq8p26/0cBUt6bRKVMyUCjnd3 23gkMYxo0ogm+ZTDnTCRJNViHJ+WMh5N4MoQDbAIfozE6zvfqvvd8vKuEPfx5IkuJ0XrU7lN4B6 QASmCiGXi+7ZieGJUiXEkmh49z8fR+zFJGcaFQQlkStCFaSjHJenGswO4wdbGAp7rTbagsDq9Go FUxcroStyV3FOup4KCNYjYCsnQaNhG540ae+dAuVyWP8G/Ag5R4/N6AjRjk7EZZ9AdpXlJ+ X-Google-Smtp-Source: AGHT+IEVPISI1ZFOfrRgtzc89rAqXipHXQphkO4uBsEBlho56ggw85qDUahodeSFm3OyEB4S7IXeqw== X-Received: by 2002:a05:600c:3ba0:b0:434:a160:3682 with SMTP id 5b1f17b1804b1-434d09c36d4mr17543485e9.17.1733218955385; Tue, 03 Dec 2024 01:42:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Thomas Huth , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3] system: Select HVF by default when no other accelerator is available Date: Tue, 3 Dec 2024 10:42:32 +0100 Message-ID: <20241203094232.62232-1-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1733218992598116600 When testing with a HVF-only binary, we get: 3/12 qemu:func-quick+func-aarch64 / func-aarch64-version = ERROR 0.29s exit status 1 stderr: Traceback (most recent call last): File "tests/functional/test_version.py", line 22, in test_qmp_human_inf= o_version self.vm.launch() File "machine/machine.py", line 461, in launch raise VMLaunchFailure( qemu.machine.machine.VMLaunchFailure: ConnectError: Failed to establish s= ession: EOFError Exit code: 1 Command: build/qemu-system-aarch64 -display none -vga none -chardev s= ocket,id=3Dmon,fd=3D5 -mon chardev=3Dmon,mode=3Dcontrol -machine none -node= faults Output: qemu-system-aarch64: No accelerator selected and no default a= ccelerator available Fix by checking for HVF in configure_accelerators() and using it by default when no other accelerator is available. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- v2 was https://lore.kernel.org/qemu-devel/20241203091036.59898-1-philmd@lin= aro.org/ --- system/vl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/system/vl.c b/system/vl.c index 54998fdbc7e..2f855d83fbb 100644 --- a/system/vl.c +++ b/system/vl.c @@ -2362,6 +2362,7 @@ static void configure_accelerators(const char *progna= me) /* Select the default accelerator */ bool have_tcg =3D accel_find("tcg"); bool have_kvm =3D accel_find("kvm"); + bool have_hvf =3D accel_find("hvf"); =20 if (have_tcg && have_kvm) { if (g_str_has_suffix(progname, "kvm")) { @@ -2374,6 +2375,8 @@ static void configure_accelerators(const char *progna= me) accelerators =3D "kvm"; } else if (have_tcg) { accelerators =3D "tcg"; + } else if (have_hvf) { + accelerators =3D "hvf"; } else { error_report("No accelerator selected and" " no default accelerator available"); --=20 2.45.2