From nobody Mon Feb 9 07:42:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1732703739; cv=none; d=zohomail.com; s=zohoarc; b=Tqm3pAPFVPotl8OTRIdkqXqtKy0UJJtK1rKt/4+ist6BvlGe02Ap6ILv1UrROSNxZwhCu+EqcGCn+qkZkc0YK7eZHRBJ7E2KyXA6VOH4P5HLMEfK+EHB2SCzz6cb5KgEFKvb+zh0bwVnIM1wqAVXPfBKHZk1hruhN2MFUzw7R7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732703739; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vw8IBeqUQXp39Kdvkmv0bVNgL1DF1cMLWAsiQ1kJL5k=; b=PUWUpLCYsmtkWag+91TfLzKVyjTBcz7ozZzYo+4BrwZK60y9n67qVimXQcD0aVuVHcUC7+J34tqgNu1DcJEW/c1Ni5DmMLQ4zVyrAimiXjM3/ZdOGgX3MPdK/H3P0r29vm/uMw4dvFTw9KzW4HOOS15NDfh1NZ0uU+zto9sWSpE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1732703739538111.74382380044085; Wed, 27 Nov 2024 02:35:39 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tGFNl-0004nV-OS; Wed, 27 Nov 2024 05:34:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGFNj-0004my-TD for qemu-devel@nongnu.org; Wed, 27 Nov 2024 05:34:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tGFNf-0000fz-BO for qemu-devel@nongnu.org; Wed, 27 Nov 2024 05:34:51 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-Mzvg6r_NPdmJ_GshGK8qRg-1; Wed, 27 Nov 2024 05:34:42 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9018D1955F41; Wed, 27 Nov 2024 10:34:41 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.82]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 012B81955F40; Wed, 27 Nov 2024 10:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732703686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vw8IBeqUQXp39Kdvkmv0bVNgL1DF1cMLWAsiQ1kJL5k=; b=L+Flci+qtP1akHktVhAHTqRv4WZhBUid+5GTErZwlFgZDA/HqId6utXHP2x6FoDi18nDXe qtGekDOlSIdGDU/IEGi4OmNZpHRNwTx9VwSJ3kIWhFe9XjaClMI9DfwaKJ7OxgnNAHX2Rw UBC1CekqgwtA4ULrgnxkMMgq1J4K25w= X-MC-Unique: Mzvg6r_NPdmJ_GshGK8qRg-1 X-Mimecast-MFC-AGG-ID: Mzvg6r_NPdmJ_GshGK8qRg From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 6/7] tests/functional: Remove sleep workarounds from sh4 test Date: Wed, 27 Nov 2024 11:34:24 +0100 Message-ID: <20241127103425.378289-7-thuth@redhat.com> In-Reply-To: <20241127103425.378289-1-thuth@redhat.com> References: <20241127103425.378289-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.931, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1732703741792019100 From: C=C3=A9dric Le Goater These were introduced in the avocado tests to workaround read issues when interacting with console. They are no longer necessary and we can use the expected login string instead. Test always passes now. Remove skipUnless test on QEMU_TEST_FLAKY_TESTS. Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Thomas Huth Message-ID: <20241122141827.2039984-1-clg@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/test_sh4_tuxrun.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/functional/test_sh4_tuxrun.py b/tests/functional/test_sh= 4_tuxrun.py index 352cb360ef..b33533fc7e 100755 --- a/tests/functional/test_sh4_tuxrun.py +++ b/tests/functional/test_sh4_tuxrun.py @@ -15,7 +15,7 @@ import time =20 from unittest import skipUnless -from qemu_test import Asset, exec_command_and_wait_for_pattern, exec_comma= nd +from qemu_test import Asset, exec_command_and_wait_for_pattern from qemu_test.tuxruntest import TuxRunBaselineTest =20 class TuxRunSh4Test(TuxRunBaselineTest): @@ -27,8 +27,6 @@ class TuxRunSh4Test(TuxRunBaselineTest): 'https://storage.tuxboot.com/20230331/sh4/rootfs.ext4.zst', '3592a7a3d5a641e8b9821449e77bc43c9904a56c30d45da0694349cfd86743fd') =20 - # Note: some segfaults caused by unaligned userspace access - @skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is unstable') def test_sh4(self): self.set_machine('r2d') self.cpu=3D'sh7785' @@ -46,10 +44,8 @@ def test_sh4(self): console_index=3D1) self.vm.launch() =20 - self.wait_for_console_pattern("Welcome to TuxTest") - time.sleep(0.1) - exec_command(self, 'root') - time.sleep(0.1) + self.wait_for_console_pattern("tuxtest login:") + exec_command_and_wait_for_pattern(self, 'root', 'root@tuxtest:~#') exec_command_and_wait_for_pattern(self, 'halt', "reboot: System halted") =20 --=20 2.47.0