tests/functional: Fix the running test case causes loongarch64 to hang

[PATCH] tests/functional: Fix the running test case causes loongarch64 to hang

Posted by Xianglai Li 1 week, 3 days ago

There is a bug in the process of resolving the serial port base address
in the fdt of the loongarch VM UEFI. When both serial port information
and rng-seed information are chosen in the fdt, there is a probability
that the serial port base address cannot be resolved correctly.
This problem can be fixed by updating UEFI.

issue link:
https://gitlab.com/qemu-project/qemu/-/issues/2686

Signed-off-by: Xianglai Li <lixianglai@loongson.cn>
---
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: Song Gao <gaosong@loongson.cn>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: <peter.maydell@linaro.org>
Cc: Xianglai Li <lixianglai@loongson.cn>

 tests/functional/test_loongarch64_virt.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/functional/test_loongarch64_virt.py b/tests/functional/test_loongarch64_virt.py
index 2b8baa2c2a..b7d9abf933 100755
--- a/tests/functional/test_loongarch64_virt.py
+++ b/tests/functional/test_loongarch64_virt.py
@@ -18,16 +18,16 @@ class LoongArchMachine(QemuSystemTest):
 
     ASSET_KERNEL = Asset(
         ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
-         'releases/download/2024-05-30/vmlinuz.efi'),
+         'releases/download/2024-11-26/vmlinuz.efi'),
         '08b88a45f48a5fd92260bae895be4e5175be2397481a6f7821b9f39b2965b79e')
     ASSET_INITRD = Asset(
         ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
-         'releases/download/2024-05-30/ramdisk'),
+         'releases/download/2024-11-26/ramdisk'),
         '03d6fb6f8ee64ecac961120a0bdacf741f17b3bee2141f17fa01908c8baf176a')
     ASSET_BIOS = Asset(
         ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
-         'releases/download/2024-05-30/QEMU_EFI.fd'),
-        '937c1e7815e2340150c194a9f8f0474259038a3d7b8845ed62cc08163c46bea1')
+         'releases/download/2024-11-26/QEMU_EFI.fd'),
+        'f55fbf5d92e885844631ae9bfa8887f659bbb4f6ef2beea9e9ff8bc0603b6697')
 
     def wait_for_console_pattern(self, success_message, vm=None):
         wait_for_console_pattern(self, success_message,
-- 
2.39.1

Re: [PATCH] tests/functional: Fix the running test case causes loongarch64 to hang

Posted by bibo mao 1 week, 2 days ago

Hi Thomas and Philippe,

Could you do me a favor to merge this bugfix?

Gao Song is offline and cannot work on computer. I have no merge 
permission and I am applying maintainer permission.

Regards
Bibo Mao

On 2024/11/27 上午9:34, Xianglai Li wrote:
> There is a bug in the process of resolving the serial port base address
> in the fdt of the loongarch VM UEFI. When both serial port information
> and rng-seed information are chosen in the fdt, there is a probability
> that the serial port base address cannot be resolved correctly.
> This problem can be fixed by updating UEFI.
> 
> issue link:
> https://gitlab.com/qemu-project/qemu/-/issues/2686
> 
> Signed-off-by: Xianglai Li <lixianglai@loongson.cn>
> ---
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Song Gao <gaosong@loongson.cn>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: <peter.maydell@linaro.org>
> Cc: Xianglai Li <lixianglai@loongson.cn>
> 
>   tests/functional/test_loongarch64_virt.py | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/functional/test_loongarch64_virt.py b/tests/functional/test_loongarch64_virt.py
> index 2b8baa2c2a..b7d9abf933 100755
> --- a/tests/functional/test_loongarch64_virt.py
> +++ b/tests/functional/test_loongarch64_virt.py
> @@ -18,16 +18,16 @@ class LoongArchMachine(QemuSystemTest):
>   
>       ASSET_KERNEL = Asset(
>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
> -         'releases/download/2024-05-30/vmlinuz.efi'),
> +         'releases/download/2024-11-26/vmlinuz.efi'),
>           '08b88a45f48a5fd92260bae895be4e5175be2397481a6f7821b9f39b2965b79e')
>       ASSET_INITRD = Asset(
>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
> -         'releases/download/2024-05-30/ramdisk'),
> +         'releases/download/2024-11-26/ramdisk'),
>           '03d6fb6f8ee64ecac961120a0bdacf741f17b3bee2141f17fa01908c8baf176a')
>       ASSET_BIOS = Asset(
>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
> -         'releases/download/2024-05-30/QEMU_EFI.fd'),
> -        '937c1e7815e2340150c194a9f8f0474259038a3d7b8845ed62cc08163c46bea1')
> +         'releases/download/2024-11-26/QEMU_EFI.fd'),
> +        'f55fbf5d92e885844631ae9bfa8887f659bbb4f6ef2beea9e9ff8bc0603b6697')
>   
>       def wait_for_console_pattern(self, success_message, vm=None):
>           wait_for_console_pattern(self, success_message,
>

Re: [PATCH] tests/functional: Fix the running test case causes loongarch64 to hang

Posted by Thomas Huth 1 week, 1 day ago

On 28/11/2024 02.35, bibo mao wrote:
> Hi Thomas and Philippe,
> 
> Could you do me a favor to merge this bugfix?
> 
> Gao Song is offline and cannot work on computer. I have no merge permission 
> and I am applying maintainer permission.

Sure, I've put it in my current pull request!

  Regards,
   Thomas


> 
> On 2024/11/27 上午9:34, Xianglai Li wrote:
>> There is a bug in the process of resolving the serial port base address
>> in the fdt of the loongarch VM UEFI. When both serial port information
>> and rng-seed information are chosen in the fdt, there is a probability
>> that the serial port base address cannot be resolved correctly.
>> This problem can be fixed by updating UEFI.
>>
>> issue link:
>> https://gitlab.com/qemu-project/qemu/-/issues/2686
>>
>> Signed-off-by: Xianglai Li <lixianglai@loongson.cn>
>> ---
>> Cc: Bibo Mao <maobibo@loongson.cn>
>> Cc: Daniel P. Berrangé <berrange@redhat.com>
>> Cc: Song Gao <gaosong@loongson.cn>
>> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
>> Cc: <peter.maydell@linaro.org>
>> Cc: Xianglai Li <lixianglai@loongson.cn>
>>
>>   tests/functional/test_loongarch64_virt.py | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/functional/test_loongarch64_virt.py b/tests/functional/ 
>> test_loongarch64_virt.py
>> index 2b8baa2c2a..b7d9abf933 100755
>> --- a/tests/functional/test_loongarch64_virt.py
>> +++ b/tests/functional/test_loongarch64_virt.py
>> @@ -18,16 +18,16 @@ class LoongArchMachine(QemuSystemTest):
>>       ASSET_KERNEL = Asset(
>>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
>> -         'releases/download/2024-05-30/vmlinuz.efi'),
>> +         'releases/download/2024-11-26/vmlinuz.efi'),
>>           '08b88a45f48a5fd92260bae895be4e5175be2397481a6f7821b9f39b2965b79e')
>>       ASSET_INITRD = Asset(
>>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
>> -         'releases/download/2024-05-30/ramdisk'),
>> +         'releases/download/2024-11-26/ramdisk'),
>>           '03d6fb6f8ee64ecac961120a0bdacf741f17b3bee2141f17fa01908c8baf176a')
>>       ASSET_BIOS = Asset(
>>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
>> -         'releases/download/2024-05-30/QEMU_EFI.fd'),
>> -        '937c1e7815e2340150c194a9f8f0474259038a3d7b8845ed62cc08163c46bea1')
>> +         'releases/download/2024-11-26/QEMU_EFI.fd'),
>> +        'f55fbf5d92e885844631ae9bfa8887f659bbb4f6ef2beea9e9ff8bc0603b6697')
>>       def wait_for_console_pattern(self, success_message, vm=None):
>>           wait_for_console_pattern(self, success_message,
>>
> 
>

Re: [PATCH] tests/functional: Fix the running test case causes loongarch64 to hang

Posted by Philippe Mathieu-Daudé 1 week, 2 days ago

On 27/11/24 02:34, Xianglai Li wrote:
> There is a bug in the process of resolving the serial port base address
> in the fdt of the loongarch VM UEFI. When both serial port information
> and rng-seed information are chosen in the fdt, there is a probability
> that the serial port base address cannot be resolved correctly.

> This problem can be fixed by updating UEFI.
> 
> issue link:

s/issue link/Resolves/

> https://gitlab.com/qemu-project/qemu/-/issues/2686
> 
> Signed-off-by: Xianglai Li <lixianglai@loongson.cn>
> ---
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Song Gao <gaosong@loongson.cn>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: <peter.maydell@linaro.org>
> Cc: Xianglai Li <lixianglai@loongson.cn>
> 
>   tests/functional/test_loongarch64_virt.py | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/functional/test_loongarch64_virt.py b/tests/functional/test_loongarch64_virt.py
> index 2b8baa2c2a..b7d9abf933 100755
> --- a/tests/functional/test_loongarch64_virt.py
> +++ b/tests/functional/test_loongarch64_virt.py
> @@ -18,16 +18,16 @@ class LoongArchMachine(QemuSystemTest):
>   
>       ASSET_KERNEL = Asset(
>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
> -         'releases/download/2024-05-30/vmlinuz.efi'),
> +         'releases/download/2024-11-26/vmlinuz.efi'),
>           '08b88a45f48a5fd92260bae895be4e5175be2397481a6f7821b9f39b2965b79e')
>       ASSET_INITRD = Asset(
>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
> -         'releases/download/2024-05-30/ramdisk'),
> +         'releases/download/2024-11-26/ramdisk'),
>           '03d6fb6f8ee64ecac961120a0bdacf741f17b3bee2141f17fa01908c8baf176a')
>       ASSET_BIOS = Asset(
>           ('https://github.com/yangxiaojuan-loongson/qemu-binary/'
> -         'releases/download/2024-05-30/QEMU_EFI.fd'),
> -        '937c1e7815e2340150c194a9f8f0474259038a3d7b8845ed62cc08163c46bea1')
> +         'releases/download/2024-11-26/QEMU_EFI.fd'),
> +        'f55fbf5d92e885844631ae9bfa8887f659bbb4f6ef2beea9e9ff8bc0603b6697')
>   
>       def wait_for_console_pattern(self, success_message, vm=None):
>           wait_for_console_pattern(self, success_message,

Re: [PATCH] tests/functional: Fix the running test case causes loongarch64 to hang

Posted by Thomas Huth 1 week, 2 days ago

On 27/11/2024 02.34, Xianglai Li wrote:
> There is a bug in the process of resolving the serial port base address
> in the fdt of the loongarch VM UEFI. When both serial port information
> and rng-seed information are chosen in the fdt, there is a probability
> that the serial port base address cannot be resolved correctly.
> This problem can be fixed by updating UEFI.
> 
> issue link:
> https://gitlab.com/qemu-project/qemu/-/issues/2686
> 
> Signed-off-by: Xianglai Li <lixianglai@loongson.cn>
> ---
> Cc: Bibo Mao <maobibo@loongson.cn>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Song Gao <gaosong@loongson.cn>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: <peter.maydell@linaro.org>
> Cc: Xianglai Li <lixianglai@loongson.cn>
> 
>   tests/functional/test_loongarch64_virt.py | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Thanks, this seems to fix the issue, indeed!

Tested-by: Thomas Huth <thuth@redhat.com>