From nobody Mon Nov 17 06:56:44 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1732637621; cv=none; d=zohomail.com; s=zohoarc; b=h18cikHtzp0s5MJm99WM+L/6LtfnLvYJ1PjWVYhiRJOMMA6ktZW4HwBaHFmaJAUClqs6aSajGuDEPfFdfN2dBQOIGWdh2FRw2MuB4ER2mQz2hdNGzXbpF6nOpJcy3808x+bmwt5DfOEIUiE2pj2aFkHCgh1e5S7VHzc5nL0voqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732637621; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3Vet2yBGrohjmo4+eMPo1FW5W5EQK04nhQQbYGwG6no=; b=jWkcI/Dibvt7oz6nH5LubGinlgww3Fla1n/lo1Mbov9a71gFjCJVMxWJ/WGotenl/d2wwhjGsjTnuF17z+jfn/iZcFWGzlmgJyq88BhFWqQWlfoXaI6nIZrQFFLwLsw+IKDH9Ug6YwWo3jDeCUM68P2wq6/UBM4t0WLwVVmHKro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17326376211291000.8536121469016; Tue, 26 Nov 2024 08:13:41 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFyBP-0006sa-Vj; Tue, 26 Nov 2024 11:13:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFyBC-0006mX-2M; Tue, 26 Nov 2024 11:12:47 -0500 Received: from mgamail.intel.com ([192.198.163.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFyBA-0000fl-6T; Tue, 26 Nov 2024 11:12:45 -0500 Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2024 08:12:42 -0800 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.36]) by fmviesa006.fm.intel.com with ESMTP; 26 Nov 2024 08:12:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732637564; x=1764173564; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wTYR6sEj7FpEEgZC6d2tvMR+RRZObWL5PjGhWIrCUt8=; b=h6hnXYzX2IsLR4iUzgZzVdZuWvuWQeFdS8/3I1LwXukUITKCgnbQ3/Yr 5NGHMLyXzLYZS/8t4aiPlUQGDd50BAcyTHmCN3rr5nkp3gd8wDUBrlfLo j+WN8xX7xj0iCc/WDcmZ+hxVm5/03+OPCI0E8pjQQVER2lsZaqGoAKkSl euFu2TvxdhNUZbQtSfCnSRHElsbXIkCnEXFF5ByGctRJqKXWw6MaHdWZp I8IXgdBmdqkW328Pc8tzOwM6FrelQwdzDvAngDU7D5U2qkhFzPcsmNqBx Lp61rlDbtjUxvVIjMc041kbUj7arSjioglc/BfZ6/wvUpYMsyNwg8RGyB g==; X-CSE-ConnectionGUID: f7Awuw6WRFGGZEBrVVlScw== X-CSE-MsgGUID: ZjOBy3F7Qhm6/HtoowB0vg== X-IronPort-AV: E=McAfee;i="6700,10204,11268"; a="20399391" X-IronPort-AV: E=Sophos;i="6.12,186,1728975600"; d="scan'208";a="20399391" X-CSE-ConnectionGUID: YyO1dzIaRN6giLhVDvrs8Q== X-CSE-MsgGUID: OWDh59O8S1OjuQo/xA8a3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,186,1728975600"; d="scan'208";a="91277668" From: Zhao Liu To: Paolo Bonzini , "Michael S . Tsirkin" Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Zhao Liu Subject: [PATCH 1/2] hw/timer/hpet: Fix comment about capabilities register Date: Wed, 27 Nov 2024 00:30:45 +0800 Message-Id: <20241126163046.3344931-2-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241126163046.3344931-1-zhao1.liu@intel.com> References: <20241126163046.3344931-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.16; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1732637622046019100 Content-Type: text/plain; charset="utf-8" HPETState.capability stores the emulated value for "general capabilities and id register" instead of "main counter register". Fix the comment to accurately reflect this. Signed-off-by: Zhao Liu --- hw/timer/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 5399f1b2a3f7..0f3dfe9f945b 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -736,7 +736,7 @@ static void hpet_realize(DeviceState *dev, Error **errp) timer->state =3D s; } =20 - /* 64-bit main counter; LegacyReplacementRoute. */ + /* 64-bit General Capabilities and ID Register; LegacyReplacementRoute= . */ s->capability =3D 0x8086a001ULL; s->capability |=3D (s->num_timers - 1) << HPET_ID_NUM_TIM_SHIFT; s->capability |=3D ((uint64_t)(HPET_CLK_PERIOD * FS_PER_NS) << 32); --=20 2.34.1 From nobody Mon Nov 17 06:56:44 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1732637590; cv=none; d=zohomail.com; s=zohoarc; b=mCXzlxf2/iznoZPIEmnwKX+zgrIRXJdaaIEHTJOvOc/PFtJZSJH7YJXTk1x1V1ozHeRy7u5fNR5wUlDYSDl2r25WWVLdfMlDNuacbT2RBNHWSCiXUvjl/26SdR4kutSpPbjnJgP1FGjGJQdWcDtCUoE5TuxVB9iEoU81+AmMs2E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732637590; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UpGXxcPOAvT69+ulqssKEkkqHvVc1H6s0GPLo31XjgU=; b=mpndKjaAKlEUDLhaq1azyH4NsBKNhH3IhhSJ7zd2i00znrhw1c1k5p5H1fx/nxEoiITUCeg9MEkDb7gB0JEpnaGbizzXFuc1xBcrqwXhX4UNE8ZFgxmmUbM8ewdZpIxvVDYtikfXFWq/uq/vETmGZ77xPWHysv6B6BlIPLp0SA0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1732637590076388.0000803052436; Tue, 26 Nov 2024 08:13:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFyBO-0006rK-Qc; Tue, 26 Nov 2024 11:12:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFyBD-0006mc-0g; Tue, 26 Nov 2024 11:12:47 -0500 Received: from mgamail.intel.com ([192.198.163.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFyBB-0000g2-Fu; Tue, 26 Nov 2024 11:12:46 -0500 Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2024 08:12:44 -0800 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.36]) by fmviesa006.fm.intel.com with ESMTP; 26 Nov 2024 08:12:43 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732637566; x=1764173566; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0oaJEibH+FOP2hyVlMA0xFu8KZX3CJL3iZrEw7r/6/A=; b=mBrV4MOapO+fbS5PG5yobu47fv9v4nR0FGp3psqLec6fVLnp2XVonUDn zjzFsUW1soBTTnDYSPv0uYPTLR9lieKSfSAgoJNHJqMP2qr0YsLh9SIed +7oqPI8lhezWmuuUawYsNlKIIG5BPdNV8h6JtKnT7QPyS5XJesZCsGL1v XUFfo8kqQ6AFzrdxSZ3rWiXLilRPaNrA29aOv7e7CJngRdDq35NMR4S5g FIDjFJjljoPhVLEF8ASC3ImXUJ9YqstoQAwwn9cHMPUS0rGz2DUd+Jj6U Nw9rSrZ7zTsxDfWNeG4kq8D4lUN2l53aJYP7RF65XVcMU4/TFUhYb8SeS g==; X-CSE-ConnectionGUID: eSJ/AjKQTaec6aGlO6FuiQ== X-CSE-MsgGUID: woKecO4dSVe8fMrQMXvMDw== X-IronPort-AV: E=McAfee;i="6700,10204,11268"; a="20399395" X-IronPort-AV: E=Sophos;i="6.12,186,1728975600"; d="scan'208";a="20399395" X-CSE-ConnectionGUID: 0dwSVV9BTJua9o0puNA80Q== X-CSE-MsgGUID: Q2eu35jvQRyaxEmQR9L0aA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,186,1728975600"; d="scan'208";a="91277672" From: Zhao Liu To: Paolo Bonzini , "Michael S . Tsirkin" Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Zhao Liu Subject: [PATCH 2/2] hw/timer/hpet: Drop the unused macro Date: Wed, 27 Nov 2024 00:30:46 +0800 Message-Id: <20241126163046.3344931-3-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241126163046.3344931-1-zhao1.liu@intel.com> References: <20241126163046.3344931-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.16; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1732637594085019100 Content-Type: text/plain; charset="utf-8" HPET_TN_CFG_BITS_READONLY_OR_RESERVED is not used in any place since HPET_TN_CFG_WRITE_MASK has been already used to check and fix the writable bits in hpet_ram_write(). Drop this unused macro. Signed-off-by: Zhao Liu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/timer/hpet.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index d17a8d43199e..71e8c62453d1 100644 --- a/include/hw/timer/hpet.h +++ b/include/hw/timer/hpet.h @@ -58,7 +58,6 @@ #define HPET_TN_CFG_WRITE_MASK 0x7f4e #define HPET_TN_INT_ROUTE_SHIFT 9 #define HPET_TN_INT_ROUTE_CAP_SHIFT 32 -#define HPET_TN_CFG_BITS_READONLY_OR_RESERVED 0xffff80b1U =20 struct hpet_fw_entry { --=20 2.34.1