From nobody Sat Nov 23 16:02:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1732280952; cv=none; d=zohomail.com; s=zohoarc; b=ne9RSHnbQUBOhGvg7BcCD5nwka79cFmXHfzCcVDABBcbqYJOotkcR7XwsCpptvrJ3MBhmpb+iBdbRXM6SMlKG4OTza8YciYCdSG3Q+j/ghr+n7fCCHr4/TtfpXBqSLHabNv1npZop+ZQZKxJHd/CSle5xA+hew7BAzSJNCrySuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732280952; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KMbkOBfXpVZ3mB0PN2E9ff15VE0qy5k7LepvJsOdWSM=; b=X4kfy2UjHJkJkFeoRR6NevgxRKE7SMqTProbjAiteNhQzN+GAD4NPXAsIIvMJaJacVtfjbIE3Mx86iA4o+5mZdlml3a3rD7jkmQ8V8WJ4GMQPfbtsUXo5PsdlUQhCcvrTPw2atbThio7adL0DbwdPPkEy0DSHu/oAvMQUNzlRzA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1732280952100246.55734008849618; Fri, 22 Nov 2024 05:09:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tETOZ-0001iY-5I; Fri, 22 Nov 2024 08:08:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tETOV-0001d9-W9 for qemu-devel@nongnu.org; Fri, 22 Nov 2024 08:08:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tETOR-0005RQ-Km for qemu-devel@nongnu.org; Fri, 22 Nov 2024 08:08:18 -0500 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-PkO1ECYhNEq-f4iM8aGgYA-1; Fri, 22 Nov 2024 08:08:11 -0500 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2B1E919560B5; Fri, 22 Nov 2024 13:08:10 +0000 (UTC) Received: from corto.redhat.com (unknown [10.39.193.92]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C7DA81956086; Fri, 22 Nov 2024 13:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732280894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KMbkOBfXpVZ3mB0PN2E9ff15VE0qy5k7LepvJsOdWSM=; b=c8xwAgIBOyO+W/Nvbq5QbL2SkLA8Q5UCowDOOsLjlLMe3Ms2cLVFWPPl6aLCnRhfAdrqu4 jFe1Z202XzBaXT5KsTtzKFd01U7JzB5UXFWhvsKjnuDidAeLK0sydAORKsGna7wludeGne Loy2ybXwcvAmwFi+N+pXsRVPvZ5ayHU= X-MC-Unique: PkO1ECYhNEq-f4iM8aGgYA-1 X-Mimecast-MFC-AGG-ID: PkO1ECYhNEq-f4iM8aGgYA From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Yoshinori Sato , Magnus Damm , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH] tests/functional: Remove sleep workarounds from sh4 test Date: Fri, 22 Nov 2024 14:08:04 +0100 Message-ID: <20241122130804.2013662-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1732280955819116600 These were introduced in the avocado tests to workaround read issues when interacting with console. They are no longer necessary and we can use the expected login string instead. Signed-off-by: C=C3=A9dric Le Goater --- tests/functional/test_sh4_tuxrun.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/functional/test_sh4_tuxrun.py b/tests/functional/test_sh= 4_tuxrun.py index 352cb360ef74..dcb49f28b9aa 100755 --- a/tests/functional/test_sh4_tuxrun.py +++ b/tests/functional/test_sh4_tuxrun.py @@ -15,7 +15,7 @@ import time =20 from unittest import skipUnless -from qemu_test import Asset, exec_command_and_wait_for_pattern, exec_comma= nd +from qemu_test import Asset, exec_command_and_wait_for_pattern from qemu_test.tuxruntest import TuxRunBaselineTest =20 class TuxRunSh4Test(TuxRunBaselineTest): @@ -46,10 +46,8 @@ def test_sh4(self): console_index=3D1) self.vm.launch() =20 - self.wait_for_console_pattern("Welcome to TuxTest") - time.sleep(0.1) - exec_command(self, 'root') - time.sleep(0.1) + self.wait_for_console_pattern("tuxtest login:") + exec_command_and_wait_for_pattern(self, 'root', 'root@tuxtest:~#') exec_command_and_wait_for_pattern(self, 'halt', "reboot: System halted") =20 --=20 2.47.0