From nobody Sat Nov 23 21:22:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1730889747; cv=none; d=zohomail.com; s=zohoarc; b=W9Uw4J7R3efZyH8t1mIUkb9KBDgz/id8/ARCYmfhB7QBpubkmUPdZANBsv35kw8gJkOoIqF8EeYoGvnjK4yM8R/VkDkAc5vc9GJkle6Frg+PEirS1xht0zQV9WhHOxhkY38FynGOrrs6CVYSaW4oruc2dzdzsUVBYyBVfCGW58M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730889747; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oKjUBnxlbBFllc87xvu3z24Wo3btdntOSXybJW/yajA=; b=GNLgg9vgOKVNFqm4ox+t1co4mfgPYYGmikVgblOFQOb7vqxkVb/jgL7L1ZvhRzmMBoEFGJ84rC8WHGPXJbvkJOca+Za1cAEHgxoxvtLdpzWX2qPAy7egBOnghaqz02HJGMS4fPFZMeaO54SMWc/jv4HsXrt9gf3xLiuzapcdkHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1730889747381779.546863337233; Wed, 6 Nov 2024 02:42:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8dTp-0003gT-MV; Wed, 06 Nov 2024 05:41:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dTl-0003ee-Kj for qemu-devel@nongnu.org; Wed, 06 Nov 2024 05:41:37 -0500 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8dTi-0005QF-FP for qemu-devel@nongnu.org; Wed, 06 Nov 2024 05:41:37 -0500 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1730889687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oKjUBnxlbBFllc87xvu3z24Wo3btdntOSXybJW/yajA=; b=wyWITOeOkxetO450o4vmy0p/NtMNsBjvvbfxVs5RvN6wxURUf0y8+6VLqopvRZ5oaJXh6M +c6hZdAgPyD9F4WVwQ5ENZRsDuNf7WA4pHAkbTH7Zkn/hLRjXbXg4SxnJdaVyx2y5IRxEE K5nKa2T2qEvMbQ6rtWeIPnaJNZTmQMo= To: peter.maydell@linaro.org Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, Dmitry Frolov Subject: [PATCH] hw/timer: fix int underflow Date: Wed, 6 Nov 2024 13:40:39 +0300 Message-ID: <20241106104041.624806-2-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1730889750467116600 Content-Type: text/plain; charset="utf-8" Both timeout and return value of imx_gpt_update_count() are unsigned. Thus "limit" can not be negative, but obviously it was implied. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- hw/timer/imx_gpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c index 23b3d79bdb..06e4837fed 100644 --- a/hw/timer/imx_gpt.c +++ b/hw/timer/imx_gpt.c @@ -238,7 +238,7 @@ static void imx_gpt_compute_next_timeout(IMXGPTState *s= , bool event) } =20 /* the new range to count down from */ - limit =3D timeout - imx_gpt_update_count(s); + limit =3D (long long)timeout - imx_gpt_update_count(s); =20 if (limit < 0) { /* --=20 2.43.0