From nobody Sat Nov 23 20:19:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1730882379; cv=none; d=zohomail.com; s=zohoarc; b=k6sDx06fKjYbN+2P6P6R+q/+D+Z3kxj9BqvFl2Ym3CXDeR699sCLDzk4+uUWnLSWuVGeiAqGmpb+Q2jHtKeIPwYF3R65JOFvPK2+uNf4iDp8qVQu8UjJBCr1ackmKTii5X1AMFtir40YRLtit1nQxf2zMaclK7Zn/wVWelaxh/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730882379; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QRlqq8gCfrYmq/1HymWMdqBXT9eh491T9x3yzteXYdg=; b=cB0c0HnOHxgV0CuaXNDNifAZmVErg7hIFM2115AIVl/hHwNRk77NUIZrmZoCfdq0E556bQ3pebAlg/iQ1UvLoMu8SNsaosR7LOdf1R+dQYWpzkblO5qBewIt7HV0iNtv2j4IvqkxFJ7PGqKVlP1/amEHgOPvESzqXsthsaeiONA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1730882378848384.89767771677054; Wed, 6 Nov 2024 00:39:38 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8bYu-0003yW-3V; Wed, 06 Nov 2024 03:38:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8bYn-0003y8-BC for qemu-devel@nongnu.org; Wed, 06 Nov 2024 03:38:42 -0500 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8bYl-0005ya-8L for qemu-devel@nongnu.org; Wed, 06 Nov 2024 03:38:41 -0500 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1730882314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QRlqq8gCfrYmq/1HymWMdqBXT9eh491T9x3yzteXYdg=; b=kSRpaaVhQ8x1PBrBE4QdwidMAQAuKbIZGzZalmdd8Y4Pb1IyXVZjLgQQ1FdEEXU7k6jMLN bXE8zYKrKIb0Ug+B+yxGF/wxJyM3efOMz6FQ9PUk0dbKnDv1EO750EBTZz/+uVHWVFIbi6 pAsScxKDEhmrobIwlRimwqRxBISvNkU= To: i.mitsyanko@gmail.com, peter.maydell@linaro.org Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, Dmitry Frolov Subject: [PATCH] hw/timer: fix possible int overflow Date: Wed, 6 Nov 2024 11:37:54 +0300 Message-ID: <20241106083801.219578-2-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1730882381809116600 Content-Type: text/plain; charset="utf-8" The product "icnto * s->tcntb" may overflow uint32_t. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- hw/timer/exynos4210_mct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index e807fe2de9..5c6e139b20 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -815,7 +815,7 @@ static uint32_t exynos4210_ltick_cnt_get_cnto(struct ti= ck_timer *s) /* Both are counting */ icnto =3D remain / s->tcntb; if (icnto) { - tcnto =3D remain % (icnto * s->tcntb); + tcnto =3D remain % ((uint64_t)icnto * s->tcntb); } else { tcnto =3D remain % s->tcntb; } --=20 2.43.0