From nobody Sat Nov 23 20:30:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1730795583; cv=none; d=zohomail.com; s=zohoarc; b=baOVSIRjDn1dudqeublSaT0hO6SicYVHzobKElGv0ESXeS7xiXUkW5xZ1Lh2ou42qxWOxgVjQwGMdZb6tuLTxUhLqRjAK1W0C9yg7TXlcHqrBKieHHJaaqGqAxWSzad181EniGn9WQoFFO5udZ6L8lqh360Pb/YN1sNKvnH4yrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730795583; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XlpeZu8PQNVmBeZ7e1W+G4VWHpOwVNux592PqTOuuho=; b=WepzeFO0hgS0hPDSE+cg9dmrlFiPQIyroGDOd4mx2xSPds/ljuREA6svVvYQ7nY1ilbwNkU/SoJXFX4f+QxR4x8HKfbss/CvXzrYlcMELm+STYmsJYP1ykUCHsWHwymGVLLvwoWKQ2d6LmR7CN4zPn+hGtOiTZ2QtAssypTQ89U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1730795583130500.9634895476996; Tue, 5 Nov 2024 00:33:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8EzM-00042u-32; Tue, 05 Nov 2024 03:32:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8Ez6-0003yw-Af for qemu-devel@nongnu.org; Tue, 05 Nov 2024 03:32:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8Ez4-0006lb-DW for qemu-devel@nongnu.org; Tue, 05 Nov 2024 03:32:20 -0500 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-olKn2pRLNr-z-LlALsP9EQ-1; Tue, 05 Nov 2024 03:32:11 -0500 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 010CE1955F37; Tue, 5 Nov 2024 08:32:09 +0000 (UTC) Received: from localhost (unknown [10.39.208.8]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E122D19560AA; Tue, 5 Nov 2024 08:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730795535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XlpeZu8PQNVmBeZ7e1W+G4VWHpOwVNux592PqTOuuho=; b=H+BveNQsMfwI+uN+mnVJ51a3Y5MRXpk8TpeFL1Napartv8MnSY7WhKzaDJwrI+jHOcvPWn wWHalexCZ8LXLRWCkrRuS08rHSP7dPFtwNiYk8vx7vm4r/N6WoWgbpAVG2cwIHxFV8kXtW Gt3vl+dVMTNgsGHolfKLWjDO75K+ZZs= X-MC-Unique: olKn2pRLNr-z-LlALsP9EQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: mjt@tls.msk.ru, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Subject: [PATCH] hw/audio/hda: avoid unnecessary re-open stream on reconfiguration Date: Tue, 5 Nov 2024 12:32:03 +0400 Message-ID: <20241105083203.2230983-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1730795584182116600 From: Marc-Andr=C3=A9 Lureau Closing and opening a stream too quickly during reconfiguration create issues with Spice. Note: the issue with Spice has been there before and still is. When the audio stream is recreated, for example when using `out.mixing-engine=3Dfalse`. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2639 Fixes: 6d6e23361f ("hw/audio/hda: fix memory leak on audio setup") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/audio/hda-codec.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c index bc661504cf..b734a5c718 100644 --- a/hw/audio/hda-codec.c +++ b/hw/audio/hda-codec.c @@ -502,7 +502,15 @@ static void hda_audio_setup(HDAAudioStream *st) trace_hda_audio_format(st->node->name, st->as.nchannels, fmt2name[st->as.fmt], st->as.freq); =20 - hda_close_stream(st->state, st); + /* + * Do not hda_close_stream(st->state, st), AUD_open_() handles the log= ic for + * fixed_settings, and same format. This helps prevent race issues in = Spice + * server & client code too. (see #2639) + */ + if (use_timer) { + timer_free(st->buft); + st->buft =3D NULL; + } if (st->output) { if (use_timer) { cb =3D hda_audio_output_cb; --=20 2.47.0