From nobody Sat Nov 23 22:27:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1730482747; cv=none; d=zohomail.com; s=zohoarc; b=jD6kZeTacZJke+lgwEzoU/2ToOlqRzU3oxffOUS1HVNQMa6ysWWsxzHYBx8Kxv4QXQ5Io2aIzngJ3c1g3NjnN9eijHTYxOkidOA2m1n/K/QYDUHa1LdsPlhA4IfPfIlUmnwMLhmpjJZBhYDsZmEhPKaz57WZuLo8YSeQ1itMd00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1730482747; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2Yg1Q57DcbFeabiuV5L4Gu/UUPB4Q5NsjF4Jfzl6XqM=; b=NzbWmsdR5TachNFQ2PN4LKyFQeL2093V6fdLHwyitRHgfkkiiX+c97dYCEDsAvHuVGxdQ/HmxM3EPThHus3OddkTF/facwcs86kQuMBOe5LIE7cF2jDbn2NlUNbiGVlpTYUF93i5tNF8d6Nel8AsuuTQByWwwIkvDLFlvUVAeY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1730482747475982.9857044692208; Fri, 1 Nov 2024 10:39:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6vaP-00014y-Gh; Fri, 01 Nov 2024 13:37:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6vaJ-00012l-PH for qemu-devel@nongnu.org; Fri, 01 Nov 2024 13:37:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6vaI-0000uX-DZ for qemu-devel@nongnu.org; Fri, 01 Nov 2024 13:37:19 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-aRa-NtRzMba_9MmTrvaiNA-1; Fri, 01 Nov 2024 13:37:16 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9634719560AB; Fri, 1 Nov 2024 17:37:15 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.82.62]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AC98C19560A2; Fri, 1 Nov 2024 17:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730482637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Yg1Q57DcbFeabiuV5L4Gu/UUPB4Q5NsjF4Jfzl6XqM=; b=U8J3fIQ0G+UthC59FWGLgg3k+6YaR5pcSAtF3gRDGSKyfrMB7KTmcynUQwIbTwRz1bdYmH qYA+x0o/AdHJi8OEDu4muv9q/Y1yz4ZEJG4WAP8hKGDl9dfkShXHrqwQgQdQNGU/m+hAby +RSaR58nmPzQS4lj1ZbYIuGkzqSbODk= X-MC-Unique: aRa-NtRzMba_9MmTrvaiNA-1 From: John Snow To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Cleber Rosa , Hanna Reitz , John Snow Subject: [PATCH 4/4] python: silence pylint raising-non-exception error Date: Fri, 1 Nov 2024 13:37:00 -0400 Message-ID: <20241101173700.965776-5-jsnow@redhat.com> In-Reply-To: <20241101173700.965776-1-jsnow@redhat.com> References: <20241101173700.965776-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1730482748031116600 Content-Type: text/plain; charset="utf-8" As of (at least) pylint 3.3.1, this code trips pylint up into believing we are raising something other than an Exception. We are not: the first two values may indeed be "None", but the last and final value must by definition be a SystemExit exception. Signed-off-by: John Snow --- python/scripts/mkvenv.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/scripts/mkvenv.py b/python/scripts/mkvenv.py index f2526af0a04..8ac5b0b2a05 100644 --- a/python/scripts/mkvenv.py +++ b/python/scripts/mkvenv.py @@ -379,6 +379,9 @@ def make_venv( # pylint: disable=3Dtoo-many-arguments try: builder.create(str(env_dir)) except SystemExit as exc: + # pylint 3.3 bug: + # pylint: disable=3Draising-non-exception, raise-missing-from + # Some versions of the venv module raise SystemExit; *nasty*! # We want the exception that prompted it. It might be a subpro= cess # error that has output we *really* want to see. --=20 2.47.0