From nobody Sat Nov 23 20:45:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1729929715; cv=none; d=zohomail.com; s=zohoarc; b=REJ80cmBxguZVot3V0L/wjPj+Z5dRKaN3JRTHEppoWaub1l4DmB6OL21rdo8B58xCTXI7hJeTYuQvSWxfSsverya+YFouSX1Agm08WFmo2ESVl24EdRi7Q6WejRxuPqpIZqtmyf4ABLC26sU+oqNfYoeuPbOGbt42vJNjWrvY3o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729929715; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ffucPo4rILqxVbsa3TwhxlnE5gtEFDYiQYy5A7qhXqw=; b=Gl+zqtaxZKdJimrZ4wAghrv43F72RXxCZ6xMatz1KqYcggt+MFTuSs5+lAIkMc9id8BPWc6DH0Ny60fkcKIxJX4wsqMoyLONhqFrCut+NfCCqRmY0bmynIpGETrh0TauDow3cd3rR3c3qALxX98vllyQBQ42QmVyCOO4nzba8LI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1729929715104608.120439541412; Sat, 26 Oct 2024 01:01:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4bju-0003t3-Mp; Sat, 26 Oct 2024 04:01:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4bjt-0003ss-9o for qemu-devel@nongnu.org; Sat, 26 Oct 2024 04:01:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4bjr-0000iG-Ug for qemu-devel@nongnu.org; Sat, 26 Oct 2024 04:01:37 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-_4zbh9h6Op-jjDxf3tTyRw-1; Sat, 26 Oct 2024 04:01:33 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 563E71955EE7 for ; Sat, 26 Oct 2024 08:01:31 +0000 (UTC) Received: from server.redhat.com (unknown [10.72.112.45]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7747319560A3; Sat, 26 Oct 2024 08:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729929694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffucPo4rILqxVbsa3TwhxlnE5gtEFDYiQYy5A7qhXqw=; b=XmBO+sD0nKa2jWGhc/Cq2C35apF807I9paNWX6srq/n3AWx4pzHhhimRVYwm58cKzbN1s9 cOKSge9yVth157gWhj8LGbIJOb9WBlvBcNLf5EESZyn5JFKcuyM4ACYhwAtCSoIzGFi0yz hNqOMC70CZAgosWkCsr68yQyu2ILtdA= X-MC-Unique: _4zbh9h6Op-jjDxf3tTyRw-1 From: Cindy Lu To: lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v3 1/4] vhost_vdpa : Add a new parameter to enable check mac address Date: Sat, 26 Oct 2024 15:59:59 +0800 Message-ID: <20241026080121.461781-2-lulu@redhat.com> In-Reply-To: <20241026080121.461781-1-lulu@redhat.com> References: <20241026080121.461781-1-lulu@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lulu@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.454, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1729929715826116600 Content-Type: text/plain; charset="utf-8" When using a VDPA device, it's important to ensure that the MAC address is correctly set. Add a new parameter in qemu cmdline to enable this check, default value is false The usage is: .... -netdev type=3Dvhost-vdpa,vhostdev=3D/dev/vhost-vdpa-0,id=3Dvhost-vdpa0,mac= strickcheck=3Dtrue\ -device virtio-net-pci,netdev=3Dvhost-vdpa0\ .... Signed-off-by: Cindy Lu --- include/net/net.h | 1 + net/vhost-vdpa.c | 4 ++++ qapi/net.json | 5 +++++ 3 files changed, 10 insertions(+) diff --git a/include/net/net.h b/include/net/net.h index c8f679761b..e00651a97b 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -112,6 +112,7 @@ struct NetClientState { bool is_netdev; bool do_not_pad; /* do not pad to the minimum ethernet frame length */ bool is_datapath; + bool check_mac; QTAILQ_HEAD(, NetFilterState) filters; }; =20 diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 46b02c50be..071c3ff065 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -1860,6 +1860,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const c= har *name, iova_range, features, shared, errp); if (!ncs[i]) goto err; + + ncs[i]->check_mac =3D opts->macstrickcheck; } =20 if (has_cvq) { @@ -1872,6 +1874,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const c= har *name, errp); if (!nc) goto err; + + nc->check_mac =3D opts->macstrickcheck; } =20 return 0; diff --git a/qapi/net.json b/qapi/net.json index 87fc0d0b28..7d75119858 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -510,6 +510,10 @@ # @queues: number of queues to be created for multiqueue vhost-vdpa # (default: 1) # +# @macstrickcheck: Enable the check for whether the device's MAC address +# and the MAC in QEMU command line are acceptable for booting. +# (default: false) +# # @x-svq: Start device with (experimental) shadow virtqueue. (Since # 7.1) (default: false) # @@ -524,6 +528,7 @@ '*vhostdev': 'str', '*vhostfd': 'str', '*queues': 'int', + '*macstrickcheck': 'bool', '*x-svq': {'type': 'bool', 'features' : [ 'unstable'] } } } =20 ## --=20 2.45.0