From nobody Wed Oct 23 00:40:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1729607465; cv=none; d=zohomail.com; s=zohoarc; b=LcWJss1DTzrloHqpG8prfRPfixHThKOOkuYKr5vd7UNK69Bh7x7eNBI14MFdXAkLMbYxYo7BUb/uaachgjnPTUZfTSOBTXRj9kGo3dVCZcskISX5k8zVuMeMUT/dk7CxpxduL7Rq0JT1YFH9Rw8A70WAE3/ZLAedBxqH11UV/FA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729607465; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S70GhYB7laEL2fnTCNmkV4yqr3u8YRvyEUuIY22drcU=; b=SznNdfrt14wKg51XnUkcfbPtAW6TJYNmKtOk9g8xk14E2fb2X29xzMg/0qn0KX4Wcd1g2TQvPcl8bGssnPPg11BFrV1UBAzTZ8LgsQNHHuMGq+f7PeobT2PC4g5n9iwPFTmxOY9rwk/VDMxgkVx7feTMyPQHKQoyJX8nL+dYtWM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1729607465960320.5606698522372; Tue, 22 Oct 2024 07:31:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3FuO-0001oB-4Q; Tue, 22 Oct 2024 10:30:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Ftt-0001ab-4v for qemu-devel@nongnu.org; Tue, 22 Oct 2024 10:30:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3Ftq-0007Fp-Vb for qemu-devel@nongnu.org; Tue, 22 Oct 2024 10:30:20 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-w2NRoPHROc-4vH9Is8SCCQ-1; Tue, 22 Oct 2024 10:30:14 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6732819560AD; Tue, 22 Oct 2024 14:30:13 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.116.80]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D05391955F42; Tue, 22 Oct 2024 14:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729607417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S70GhYB7laEL2fnTCNmkV4yqr3u8YRvyEUuIY22drcU=; b=Xnk6PrwSwdGNp2mw4Ci37rnG5UNSJuPTapSWyrOa6zsm9BAvFoAJ+adRYxJ2ANZZQbFjqD lbcOI+yH5+XHKlAYDJ4UA8eUPElC/Bn0QnBvu+sS81RZyG7ZoPXOeeUdCdCmsqifsPkO3W 8deVkLGUrA6VO3xj7YscUjgShlACEkw= X-MC-Unique: w2NRoPHROc-4vH9Is8SCCQ-1 From: Dehan Meng To: qemu-devel@nongnu.org Cc: demeng@redhat.com, kkostiuk@redhat.com, michael.roth@amd.com, peter.maydell@linaro.org, berrange@redhat.com Subject: [PATCH v4 3/5] qemu-ga: Avoiding freeing line prematurely Date: Tue, 22 Oct 2024 22:29:46 +0800 Message-Id: <20241022142948.531325-4-demeng@redhat.com> In-Reply-To: <20241022142948.531325-1-demeng@redhat.com> References: <20241022142948.531325-1-demeng@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=demeng@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.519, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.697, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1729607466728116600 Content-Type: text/plain; charset="utf-8" It's now only freed at the end of the function. Signed-off-by: Dehan Meng --- qga/commands-linux.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qga/commands-linux.c b/qga/commands-linux.c index 32bf1b8ce7..c6bda78de6 100644 --- a/qga/commands-linux.c +++ b/qga/commands-linux.c @@ -2137,8 +2137,7 @@ GuestNetworkRouteList *qmp_guest_network_get_route(Er= ror **errp) is_ipv6 =3D (i =3D=3D 1); fp =3D fopen(routeFiles[i], "r"); if (fp =3D=3D NULL) { - error_setg_errno(errp, errno, "open(\"%s\")", routeFiles[i]); - free(line); + error_setg_errno(errp, errno, "open(\"%s\")", route_files[i]); continue; } =20 @@ -2226,9 +2225,8 @@ GuestNetworkRouteList *qmp_guest_network_get_route(Er= ror **errp) QAPI_LIST_APPEND(tail, route); } =20 - free(line); fclose(fp); } - + free(line); return head; } --=20 2.40.1