From nobody Wed Oct 23 01:35:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1729590432; cv=none; d=zohomail.com; s=zohoarc; b=CuNSzB8MQqsK+SjLWItmvt2giZYe3EzyKvDZZjrHkUTTcECKw70fCoac27w1Qjgnnw5WPQTVNhZPo71lOoI5Nk+H9/UlM9trGx5wenoKta8uv322wTuADW2IgtbW5tlrPMiO5CbbHZlrJLyIgspsJALg0gHD6OSBkW+OIIq/elE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729590432; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=CBir2CRWMoEZ6Bj0A9uNBqzW/Nug/HzuOMLeZPVJt5Y=; b=aBt0EQQdngYMu2/h17EiQBudscCbSfIHL7u1bnEOstNrS/QiYiil9t3jtrs2HwXoGzp5EoqV3a+bBLjYEAka6VJGx+Bty9yeKggcNOUgEx/1T3JVRzAcSwOmXEiB9/QK8T60oEXajQlUqW2SLwJUWg78/lqe6QsrTF1v19JBz0M= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1729590432547452.01820493852847; Tue, 22 Oct 2024 02:47:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3BOz-0003Rv-4G; Tue, 22 Oct 2024 05:42:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3BOw-0003Ph-KI; Tue, 22 Oct 2024 05:42:06 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3BOu-00019W-UW; Tue, 22 Oct 2024 05:42:06 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 22 Oct 2024 17:41:15 +0800 Received: from localhost.localdomain (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Tue, 22 Oct 2024 17:41:15 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Andrew Jeffery , "Joel Stanley" , Alistair Francis , "Kevin Wolf" , Hanna Reitz , Thomas Huth , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" , "open list:Block layer core" CC: , , Subject: [PATCH v2 12/18] test/qtest/aspeed_smc-test: Introducing a "page_addr" data field Date: Tue, 22 Oct 2024 17:41:04 +0800 Message-ID: <20241022094110.1574011-13-jamin_lin@aspeedtech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241022094110.1574011-1-jamin_lin@aspeedtech.com> References: <20241022094110.1574011-1-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=jamin_lin@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jamin Lin From: Jamin Lin via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1729590433352116600 Content-Type: text/plain; charset="utf-8" Currently, these test cases used the hardcode offset 0x1400000 (0x14000 * 2= 56) which was beyond the 16MB flash size for flash page read/write command test= ing. However, the default fmc flash model of ast1030-a1 EVB is "w25q80bl" whose = size is 1MB. To test all flash models, introduces a new page_addr member in Test= Data structure, so users can set the offset for flash parge read/write command testing. Signed-off-by: Jamin Lin Reviewed-by: C=C3=A9dric Le Goater --- tests/qtest/aspeed_smc-test.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tests/qtest/aspeed_smc-test.c b/tests/qtest/aspeed_smc-test.c index b8ab20b43d..6db18451d2 100644 --- a/tests/qtest/aspeed_smc-test.c +++ b/tests/qtest/aspeed_smc-test.c @@ -72,6 +72,7 @@ typedef struct TestData { char *tmp_path; uint8_t cs; const char *node; + uint32_t page_addr; } TestData; =20 /* @@ -256,7 +257,7 @@ static void assert_page_mem(const TestData *data, uint3= 2_t addr, static void test_erase_sector(const void *data) { const TestData *test_data =3D (const TestData *)data; - uint32_t some_page_addr =3D 0x600 * FLASH_PAGE_SIZE; + uint32_t some_page_addr =3D test_data->page_addr; uint32_t page[FLASH_PAGE_SIZE / 4]; int i; =20 @@ -308,7 +309,7 @@ static void test_erase_sector(const void *data) static void test_erase_all(const void *data) { const TestData *test_data =3D (const TestData *)data; - uint32_t some_page_addr =3D 0x15000 * FLASH_PAGE_SIZE; + uint32_t some_page_addr =3D test_data->page_addr; uint32_t page[FLASH_PAGE_SIZE / 4]; int i; =20 @@ -358,8 +359,8 @@ static void test_erase_all(const void *data) static void test_write_page(const void *data) { const TestData *test_data =3D (const TestData *)data; - uint32_t my_page_addr =3D 0x14000 * FLASH_PAGE_SIZE; /* beyond 16MB */ - uint32_t some_page_addr =3D 0x15000 * FLASH_PAGE_SIZE; + uint32_t my_page_addr =3D test_data->page_addr; + uint32_t some_page_addr =3D my_page_addr + FLASH_PAGE_SIZE; uint32_t page[FLASH_PAGE_SIZE / 4]; int i; =20 @@ -395,8 +396,8 @@ static void test_write_page(const void *data) static void test_read_page_mem(const void *data) { const TestData *test_data =3D (const TestData *)data; - uint32_t my_page_addr =3D 0x14000 * FLASH_PAGE_SIZE; /* beyond 16MB */ - uint32_t some_page_addr =3D 0x15000 * FLASH_PAGE_SIZE; + uint32_t my_page_addr =3D test_data->page_addr; + uint32_t some_page_addr =3D my_page_addr + FLASH_PAGE_SIZE; uint32_t page[FLASH_PAGE_SIZE / 4]; int i; =20 @@ -438,7 +439,7 @@ static void test_read_page_mem(const void *data) static void test_write_page_mem(const void *data) { const TestData *test_data =3D (const TestData *)data; - uint32_t my_page_addr =3D 0x15000 * FLASH_PAGE_SIZE; + uint32_t my_page_addr =3D test_data->page_addr; uint32_t page[FLASH_PAGE_SIZE / 4]; int i; =20 @@ -679,6 +680,8 @@ static void test_palmetto_bmc(TestData *data) data->jedec_id =3D 0x20ba19; data->cs =3D 0; data->node =3D "/machine/soc/fmc/ssi.0/child[0]"; + /* beyond 16MB */ + data->page_addr =3D 0x14000 * FLASH_PAGE_SIZE; =20 qtest_add_data_func("/ast2400/smc/read_jedec", data, test_read_jedec); qtest_add_data_func("/ast2400/smc/erase_sector", data, test_erase_sect= or); --=20 2.34.1