From nobody Wed Oct 23 00:26:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1729517477; cv=none; d=zohomail.com; s=zohoarc; b=WEMeOKnzYbUH6L334k08Qho1GQbJRRCIHas1R7tWglnaKSpaBEJPdCvngfPOO4azDIf8a6MXwEaNNfAYCjF3OUZ79TMHeA5w+XloVCO163xUhr2c72vFjltaeOl1EBEo7CFNjuIkQqMl041MyMiL43mHbZAH29ymLVHMdD07MNM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1729517477; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=S70GhYB7laEL2fnTCNmkV4yqr3u8YRvyEUuIY22drcU=; b=B0WHZXCxSpjvStYdsbWWlJHqVOe/NIKSvk8roWcgJXg3/qQ+RuGHM3cYAKXEVVDFpTJ8fkBdGlw6c94B3fkPurduIevUwPjX9/JFq/z9NnnVaVXLqVLVy3sLq+Ce2Y37cLkz+VHbT4FzDvCta/7KCUMyBQZA/pUjjxXZDdTsNTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1729517477859807.3776855000821; Mon, 21 Oct 2024 06:31:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2sTc-0006V6-6f; Mon, 21 Oct 2024 09:29:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2sTX-0006ND-FU for qemu-devel@nongnu.org; Mon, 21 Oct 2024 09:29:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2sTV-0000ie-8h for qemu-devel@nongnu.org; Mon, 21 Oct 2024 09:29:34 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-fH6WnoLZOgGCFlOyS_A4hw-1; Mon, 21 Oct 2024 09:29:29 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 26FA41955D64; Mon, 21 Oct 2024 13:29:28 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.116.80]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 72C0B1955E83; Mon, 21 Oct 2024 13:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729517372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S70GhYB7laEL2fnTCNmkV4yqr3u8YRvyEUuIY22drcU=; b=W0PffRVo29fnNH+cFTzYSqgSaJP6jtQ8Lg9s17Zmxc6hKErt3x+ErS9ehUXqEyMF5cxuu1 izeAu21hapVnZNnSnFL8y3ew4nlObw+gDGxOtNBTt8RZTm1IchusTDFG6ThsjBdeMFQZMH UOAVhMgqbDFEQGmKn8gL3tTaUDQWWBQ= X-MC-Unique: fH6WnoLZOgGCFlOyS_A4hw-1 From: Dehan Meng To: qemu-devel@nongnu.org Cc: demeng@redhat.com, kkostiuk@redhat.com, michael.roth@amd.com, peter.maydell@linaro.org, berrange@redhat.com Subject: [PATCH v3 3/4] qemu-ga: Avoiding freeing line prematurely Date: Mon, 21 Oct 2024 21:28:38 +0800 Message-Id: <20241021132839.463255-9-demeng@redhat.com> In-Reply-To: <20241021132839.463255-1-demeng@redhat.com> References: <20241021132839.463255-1-demeng@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=demeng@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.421, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.699, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1729517478251116600 Content-Type: text/plain; charset="utf-8" It's now only freed at the end of the function. Signed-off-by: Dehan Meng Reviewed-by: Daniel P. Berrang=C3=A9 --- qga/commands-linux.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qga/commands-linux.c b/qga/commands-linux.c index 32bf1b8ce7..c6bda78de6 100644 --- a/qga/commands-linux.c +++ b/qga/commands-linux.c @@ -2137,8 +2137,7 @@ GuestNetworkRouteList *qmp_guest_network_get_route(Er= ror **errp) is_ipv6 =3D (i =3D=3D 1); fp =3D fopen(routeFiles[i], "r"); if (fp =3D=3D NULL) { - error_setg_errno(errp, errno, "open(\"%s\")", routeFiles[i]); - free(line); + error_setg_errno(errp, errno, "open(\"%s\")", route_files[i]); continue; } =20 @@ -2226,9 +2225,8 @@ GuestNetworkRouteList *qmp_guest_network_get_route(Er= ror **errp) QAPI_LIST_APPEND(tail, route); } =20 - free(line); fclose(fp); } - + free(line); return head; } --=20 2.40.1