From nobody Sat Nov 23 22:23:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1728913339; cv=none; d=zohomail.com; s=zohoarc; b=fL3oYBVWCA1y8XhCcddUF5xr3wTGz+OajssTQy/1Dd+UZod07iSdZhBkG6vjJ7FHJuzmL8ZvnSDHqexMuO3FX1pF5Zl918xlSbf/PYJLNRqCdiOlzrEzqRrIZoUS8SVNIX7fPjwgfI5NvUMmvyqtmV1foCE986wg86ASNsZxX+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728913339; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PLmITopFk2zUiE8c+xSyuqffBNGuPwWylJE8zBAV1Ic=; b=GHrq2icIkx9MDBjXRCjeeONQrC+mcDEERaGxM8zR4UNWDqGE6xBaIkP0SVwDv/Jl0xud2AJ3/AOM5g4vIpV7idan+jNQS2g7/JGr2YohYkf7CyTwYJhAZDNsnBB8NlIaJZ5YU1eZeWPV+PLYhVTH4WEgrO7Z5/naSXa1lt1+/IU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728913339711384.7213967377212; Mon, 14 Oct 2024 06:42:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0LKC-00034X-0Q; Mon, 14 Oct 2024 09:41:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0LJo-0002i8-8K for qemu-devel@nongnu.org; Mon, 14 Oct 2024 09:41:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0LJl-000432-PE for qemu-devel@nongnu.org; Mon, 14 Oct 2024 09:41:03 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-eD5V0Y_wPUG4KSzCbE02GQ-1; Mon, 14 Oct 2024 09:40:59 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B52351955BD2; Mon, 14 Oct 2024 13:40:58 +0000 (UTC) Received: from localhost (unknown [10.39.208.12]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9470A1956088; Mon, 14 Oct 2024 13:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728913260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PLmITopFk2zUiE8c+xSyuqffBNGuPwWylJE8zBAV1Ic=; b=b591/Mn0L2ddbjecN5Ag38OBS0eoe2i0dRVfJ/Uz+wCtlwf2Dh986yb8DzhcphhW6NjIA3 aAWaF6Ot0ivTf2K/zBh/s+7PMccGql75C5ssX0U9oy24/YUb9pnOLjBXUQ4z5DUOHWUGXO HYROa8cYtowjCRXIqfDnfHqr3JA4caw= X-MC-Unique: eD5V0Y_wPUG4KSzCbE02GQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PULL 16/20] ui/dbus: implement Unix.Map Date: Mon, 14 Oct 2024 17:39:31 +0400 Message-ID: <20241014133935.470709-17-marcandre.lureau@redhat.com> In-Reply-To: <20241014133935.470709-1-marcandre.lureau@redhat.com> References: <20241014133935.470709-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.076, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1728913340957116600 From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Akihiko Odaki Message-ID: <20241008125028.1177932-17-marcandre.lureau@redhat.com> --- ui/dbus-listener.c | 78 +++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 73 insertions(+), 5 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 7142afcddb..ec47946282 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -83,6 +83,8 @@ struct _DBusDisplayListener { #ifdef CONFIG_OPENGL egl_fb fb; #endif +#else /* !WIN32 */ + QemuDBusDisplay1ListenerUnixMap *map_proxy; #endif =20 guint dbus_filter; @@ -441,6 +443,51 @@ dbus_scanout_share_d3d_texture( return true; } #endif /* CONFIG_OPENGL */ +#else /* !WIN32 */ +static bool dbus_scanout_map(DBusDisplayListener *ddl) +{ + g_autoptr(GError) err =3D NULL; + g_autoptr(GUnixFDList) fd_list =3D NULL; + + if (ddl->ds_share =3D=3D SHARE_KIND_MAPPED) { + return true; + } + + if (!ddl->can_share_map || ddl->ds->shmfd =3D=3D -1) { + return false; + } + + ddl_discard_display_messages(ddl); + fd_list =3D g_unix_fd_list_new(); + if (g_unix_fd_list_append(fd_list, ddl->ds->shmfd, &err) !=3D 0) { + g_debug("Failed to setup scanout map fdlist: %s", err->message); + ddl->can_share_map =3D false; + return false; + } + + if (!qemu_dbus_display1_listener_unix_map_call_scanout_map_sync( + ddl->map_proxy, + g_variant_new_handle(0), + ddl->ds->shmfd_offset, + surface_width(ddl->ds), + surface_height(ddl->ds), + surface_stride(ddl->ds), + surface_format(ddl->ds), + G_DBUS_CALL_FLAGS_NONE, + DBUS_DEFAULT_TIMEOUT, + fd_list, + NULL, + NULL, + &err)) { + g_debug("Failed to call ScanoutMap: %s", err->message); + ddl->can_share_map =3D false; + return false; + } + + ddl->ds_share =3D SHARE_KIND_MAPPED; + + return true; +} #endif /* WIN32 */ =20 #ifdef CONFIG_OPENGL @@ -693,16 +740,22 @@ static void dbus_gfx_update(DisplayChangeListener *dc= l, =20 trace_dbus_update(x, y, w, h); =20 -#ifdef WIN32 if (dbus_scanout_map(ddl)) { +#ifdef WIN32 qemu_dbus_display1_listener_win32_map_call_update_map( ddl->map_proxy, x, y, w, h, G_DBUS_CALL_FLAGS_NONE, DBUS_DEFAULT_TIMEOUT, NULL, NULL, NULL); +#else + qemu_dbus_display1_listener_unix_map_call_update_map( + ddl->map_proxy, + x, y, w, h, + G_DBUS_CALL_FLAGS_NONE, + DBUS_DEFAULT_TIMEOUT, NULL, NULL, NULL); +#endif return; } -#endif =20 if (x =3D=3D 0 && y =3D=3D 0 && w =3D=3D surface_width(ddl->ds) && h = =3D=3D surface_height(ddl->ds)) { return ddl_scanout(ddl); @@ -879,7 +932,6 @@ dbus_display_listener_get_console(DBusDisplayListener *= ddl) return ddl->console; } =20 -#ifdef WIN32 static bool dbus_display_listener_implements(DBusDisplayListener *ddl, const char *ifa= ce) { @@ -894,6 +946,7 @@ dbus_display_listener_implements(DBusDisplayListener *d= dl, const char *iface) return implements; } =20 +#ifdef WIN32 static bool dbus_display_listener_setup_peer_process(DBusDisplayListener *ddl) { @@ -976,10 +1029,11 @@ dbus_display_listener_setup_d3d11(DBusDisplayListene= r *ddl) static void dbus_display_listener_setup_shared_map(DBusDisplayListener *ddl) { -#ifdef WIN32 g_autoptr(GError) err =3D NULL; =20 - if (!dbus_display_listener_implements(ddl, "org.qemu.Display1.Listener= .Win32.Map")) { +#ifdef WIN32 + if (!dbus_display_listener_implements( + ddl, "org.qemu.Display1.Listener.Win32.Map")) { return; } =20 @@ -999,6 +1053,20 @@ dbus_display_listener_setup_shared_map(DBusDisplayLis= tener *ddl) return; } =20 + ddl->can_share_map =3D true; +#else /* !WIN32 */ + if (!dbus_display_listener_implements( + ddl, "org.qemu.Display1.Listener.Unix.Map")) { + return; + } + ddl->map_proxy =3D qemu_dbus_display1_listener_unix_map_proxy_new_sync( + ddl->conn, G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START, NULL, + "/org/qemu/Display1/Listener", NULL, &err); + if (!ddl->map_proxy) { + g_debug("Failed to setup Unix map proxy: %s", err->message); + return; + } + ddl->can_share_map =3D true; #endif } --=20 2.47.0