From nobody Sat Nov 23 23:16:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1728857772; cv=none; d=zohomail.com; s=zohoarc; b=GfjJcHKUDos1JSJIY7n44R0PlnM3ZD7L1a+qnnXIMeIH7pVPmVoLL/jKt5qxOkRwnlqqcxZpHV7RoAV31WM1oaPCot2ZLud3zyQKDCXD1eEGxoaBXZR980xKdPlU9ya0raEhU+3TqDLzqXiKYkQUW7qkYr8WV+Unq+ZaS8623gY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728857772; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5sM2rASXzZfAaByCSG4X7yOvvA/fFZaOvGmejFsljDo=; b=eBVVpVRGMuEAIA3/VFe8k7FLoaYT8rfAI7JjhoksU19YWzAYa5FMtzGeFUW25p4tLkTTsLjVAKp3UOMDJVg+kAf45W9RUK/I9kmjDeWKR+7t7M84raGooeI3ofdH00l2lamnZYxSKUZPNW6GUMm3zZDDxER99bVww/dgR/lL+Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728857772325352.5539649682579; Sun, 13 Oct 2024 15:16:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t06pa-0007AH-Mq; Sun, 13 Oct 2024 18:12:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t06pT-00078Q-HR for qemu-devel@nongnu.org; Sun, 13 Oct 2024 18:12:47 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t06pS-0000uZ-1t for qemu-devel@nongnu.org; Sun, 13 Oct 2024 18:12:47 -0400 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2e2ed59a35eso2377336a91.0 for ; Sun, 13 Oct 2024 15:12:45 -0700 (PDT) Received: from stoup.. (174-21-81-121.tukw.qwest.net. [174.21.81.121]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2d5df1eebsm7271958a91.17.2024.10.13.15.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Oct 2024 15:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728857565; x=1729462365; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5sM2rASXzZfAaByCSG4X7yOvvA/fFZaOvGmejFsljDo=; b=bHUh/ahtyWr/9PjKNFVAJETPLg3uykNiwvNVeJlL1t958/vxKuLEnYXNG8WjEDh+Y2 SbC1mcsBMJammrPg2jHVHWwWIXMzJZXgAAKFM82Pgd1l7azeuK6hSRXFFg6d/RkCI6n1 eWuQipNKk9FCdEPO6gOm9MxKxPTSptXQZWYEBgmizmz05uaQ/oaeTm8VPUp7n6U4lHph J9lfLnhW72zWIFXnXhtSpKtGg69VSY3muMV1HxUw1oKDCjVUIrp9S+y6EvGPWD63nKGb 2WHGqfj0orADKPW10F3PKIuzpdXsIaVgeH9u0WZJj6qtclQ3YIYKlROpRYSpXO1l/2/n rnRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728857565; x=1729462365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5sM2rASXzZfAaByCSG4X7yOvvA/fFZaOvGmejFsljDo=; b=lYbOgK2B4mPZQywvJxJ6drgE5kWHlhScRDiUfvlqbskK7VTQ6yaKChWZkeGRJTZad7 KmDFC40yMjRFBMWIWZhVW5SolQy4a9tqpUzHCBA91VQbzrpYICTSAelrBnV+pVWBgdyJ du+7Ti2uZG1zL+M8v4pMrOBwfKoQPnJyPQAqxVEsD00LkUmXR9XFfBegqhBd6QP0NtXG mmW8+qQpl7HD/kpBBJdH2/2MrCqvvyG40Xqw1yEvgaoZdbMfgsM43epCA3R7NQWSN4sj 26kMWFKXfQw/RbTeA1wZ5iG6NDXHplVMPEtCCRpweRkLNJXbU7xSveaC7N78anLefTcM 5XpA== X-Gm-Message-State: AOJu0YyIqxjgf47RERqrW+wYDwtOkd3kTcDzC/J/GUaFdpZQF0KWMQaf 7lcyOdOKrCZsy42Z5vJsYZMDdN33QXpdmqExcKw0C5eUklLKlGUYnHEfiiKfeH+rjCBr0KmKVhi I X-Google-Smtp-Source: AGHT+IEhdVIv1IYvBtZa8N/hMCtkNnq/cd3OO14Urwgh/PkgCabwXsG2+Phzfp1rNratvIdtJJ2xpg== X-Received: by 2002:a17:90a:68cb:b0:2e2:d74f:65b6 with SMTP id 98e67ed59e1d1-2e2f0a6838bmr13199352a91.10.1728857564810; Sun, 13 Oct 2024 15:12:44 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Helge Deller , Peter Maydell Subject: [PULL 08/27] accel/tcg: Assert noreturn from write-only page for atomics Date: Sun, 13 Oct 2024 15:12:16 -0700 Message-ID: <20241013221235.1585193-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241013221235.1585193-1-richard.henderson@linaro.org> References: <20241013221235.1585193-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1728857774132116600 Content-Type: text/plain; charset="utf-8" There should be no "just in case"; the page is already in the tlb, and known to be not readable. Reviewed-by: Helge Deller Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 117b516739..fd6459b695 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1852,10 +1852,9 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr = addr, MemOpIdx oi, /* * Since we don't support reads and writes to different * addresses, and we do have the proper page loaded for - * write, this shouldn't ever return. But just in case, - * handle via stop-the-world. + * write, this shouldn't ever return. */ - goto stop_the_world; + g_assert_not_reached(); } /* Collect tlb flags for read. */ tlb_addr |=3D tlbe->addr_read; --=20 2.43.0