From nobody Sat Nov 23 23:21:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1728444540; cv=none; d=zohomail.com; s=zohoarc; b=e1TTwckPawEL4fDXKZy7dSXEEj01mS5iL8UwDIBAJgbKxcN2NUTdepaRsNi5RtVpyEn2EhFyNIczps9Kxo48FRo6opr4Fr/JRqcdWNtkf383HWyjvYMgnC+ZH4uzeHT4macnBDUWsZGfx1rfpJ0zUxG/s8+jO6zBR8LpIpob2Zg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728444540; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=RlqgnZBYHb161FI85jYOQtg7EwDnfhHunQC9Bbrsmso=; b=Q9gu+Lk4sOamyTmTm6/3wLGfyM+zjmGakgooqBzjd9AGuYKz+Lxa0pSuhLw/JjYLKK492BkzWLgDkUmCiOD0clm9M9nN7dSQonbOGifMuqIaNheLpVpV9bnMUvMf+64NgmAQqlTtduykH+R16K1/dMRTOZuaCdimX0dD0HHf4n8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728444540246151.5046672362928; Tue, 8 Oct 2024 20:29:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1syNNd-0003bI-6B; Tue, 08 Oct 2024 23:28:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syNNY-0003TW-OS; Tue, 08 Oct 2024 23:28:49 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syNNX-00058h-1n; Tue, 08 Oct 2024 23:28:48 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XNdcJ5BX2z6K63T; Wed, 9 Oct 2024 11:27:28 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id 2AD6D140114; Wed, 9 Oct 2024 11:28:45 +0800 (CST) Received: from 00293818-MRGF.huawei.com (10.126.173.89) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 9 Oct 2024 05:28:26 +0200 To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RFC V4 28/33] tcg/mttcg: Introduce MTTCG thread unregistration leg Date: Wed, 9 Oct 2024 04:18:10 +0100 Message-ID: <20241009031815.250096-29-salil.mehta@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241009031815.250096-1-salil.mehta@huawei.com> References: <20241009031815.250096-1-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.126.173.89] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To frapeml500007.china.huawei.com (7.182.85.172) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta From: Salil Mehta via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1728444541358116600 Content-Type: text/plain; charset="utf-8" From: Miguel Luis Introduce the TCG thread unregistration leg which shall be called in contex= t to TCG/vCPU unrealize. Reported-by: Salil Mehta Signed-off-by: Miguel Luis Signed-off-by: Salil Mehta --- accel/tcg/tcg-accel-ops-mttcg.c | 1 + include/tcg/startup.h | 7 +++++++ tcg/tcg.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+) diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttc= g.c index ab2f79d2c7..4b26164ffd 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -122,6 +122,7 @@ static void *mttcg_cpu_thread_fn(void *arg) bql_unlock(); rcu_remove_force_rcu_notifier(&force_rcu.notifier); rcu_unregister_thread(); + tcg_unregister_thread(); return NULL; } =20 diff --git a/include/tcg/startup.h b/include/tcg/startup.h index a565071516..c035d03f7e 100644 --- a/include/tcg/startup.h +++ b/include/tcg/startup.h @@ -51,6 +51,13 @@ void tcg_register_thread(void); void tcg_register_thread(CPUState *cpu); #endif =20 +/** + * tcg_unregister_thread: Unregister this thread with the TCG runtime + * + * This leg shall be called whenever TCG vCPU is hot-unplugged + */ +void tcg_unregister_thread(void); + /** * tcg_prologue_init(): Generate the code for the TCG prologue * diff --git a/tcg/tcg.c b/tcg/tcg.c index 5e9c6b2b4b..3bdebdb332 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -811,6 +811,39 @@ void tcg_register_thread(CPUState *cpu) =20 tcg_ctx =3D s; } + +static void tcg_free_plugin_context(TCGContext *s) +{ +#ifdef CONFIG_PLUGIN + unsigned i; + + if (s->plugin_tb) { + for (i =3D 0; i < s->plugin_tb->insns->len; i++) { + g_free(g_ptr_array_index(s->plugin_tb->insns, i)); + } + g_ptr_array_free(s->plugin_tb->insns, TRUE); + + if (!s->plugin_tb->insns) { + g_free(s->plugin_tb); + } + } +#endif +} + +void tcg_unregister_thread(void) +{ + TCGContext *s =3D tcg_ctx; + unsigned int n; + + /* unclaim an entry in tcg_ctxs */ + n =3D qatomic_fetch_dec(&tcg_cur_ctxs); + g_assert(n > 1); + qatomic_store_release(&tcg_ctxs[n - 1], 0); + + tcg_free_plugin_context(s); + + g_free(s); +} #endif /* !CONFIG_USER_ONLY */ =20 /* pool based memory allocation */ --=20 2.34.1