From nobody Sun Nov 24 01:36:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1728315973; cv=none; d=zohomail.com; s=zohoarc; b=Y3eTVgfkBzy0miBUCnKi6IaHbXdrowR8BT48wNJDv3ahakXkDpO1L2fAQaqvGDOocMGztZTZQhD/uMPLqkcNsATFZReSk8RYzW4NWJTwhgEuOhXrBqnngZ4BgGVnlLHlL9169zN/TYTHGh1xQyhqNEE7hnQAYd5K/nKMrhE6muY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728315973; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oWdSJqNTu1f2aCVErVpBxq7bLKJEcOtDRM7rNUFeIe4=; b=AcwcdtaaloKg5leqzowbJDjNQkvMC/Ph4WliSlB+9AUKWxS9rsZN5eFdCSJgERTYJ5XcGzDxD+Sz3rfv7K1FU6cCj5B1yklqOW3hkSiJMTDO90cAAjlVqs4h5hqWe+BSW9z2pE7PQxOa+XObAzweuBiU8MBVJWQp1zOqA4KKVNk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728315973011798.4988732163334; Mon, 7 Oct 2024 08:46:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxpvz-0005Nd-4d; Mon, 07 Oct 2024 11:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxpvu-0005Al-1N for qemu-devel@nongnu.org; Mon, 07 Oct 2024 11:46:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxpvs-0002ZX-Gb for qemu-devel@nongnu.org; Mon, 07 Oct 2024 11:46:01 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-hIrEPruWPMezXKwrd_ZquA-1; Mon, 07 Oct 2024 11:45:56 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AEE02196C40B for ; Mon, 7 Oct 2024 15:45:55 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.61]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D0BD530001A0; Mon, 7 Oct 2024 15:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728315958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWdSJqNTu1f2aCVErVpBxq7bLKJEcOtDRM7rNUFeIe4=; b=NkaRg+6yiv6wrS3AoXeaGTDCZRkHxThb7Ud+Alb663B3Elz0nyvPRFafQjmCoLVLZdkJte fcD0Civno63twb+NF0jokUDRcJZ3RRYQ9aAaUhD81cD9+rNeeywJS9GiccHrMO0u/ggpAz yCh0jdYJ4Jyz7ZgRGmUoV1iaHmFsI4M= X-MC-Unique: hIrEPruWPMezXKwrd_ZquA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 3/3] scripts: forbid use of arbitrary SPDX tags besides license identifiers Date: Mon, 7 Oct 2024 16:45:48 +0100 Message-ID: <20241007154548.1144961-4-berrange@redhat.com> In-Reply-To: <20241007154548.1144961-1-berrange@redhat.com> References: <20241007154548.1144961-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.153, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1728315974810116600 While SPDX-License-Identifier is a well known SPDX tag, there are a great many more besides that[1]. This are around making machine readable metadata available to the 'reuse' tool and similar for things like author names, copyright owners, and much more. It is even possible to define source file line groups and apply different SPDX tags to just that region of code. At this time we're only interested in adopting SPDX for recording the licensing info, so detect & reject any other SPDX metadata. If we want to explicitly collect extra data in SPDX format, we can evaluate each case on its merits. [1] https://spdx.github.io/spdx-spec/v2.2.2/file-tags/ https://spdx.github.io/spdx-spec/v2.2.2/file-information/ Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/checkpatch.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index cd1ed90f4c..5ad2d4ca2e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1707,6 +1707,18 @@ sub process { &checkspdx($realfile, $1); } =20 + if ($rawline =3D~ m,(SPDX-[a-zA-Z0-9-_]+):,) { + my $tag =3D $1; + my @permitted =3D qw( + SPDX-License-Identifier + ); + + unless (grep { /^$tag$/ } @permitted) { + ERROR("Tag $tag not permitted in QEMU code, valid " . + "choices are: " . join(", ", @permitted)); + } + } + # Check for wrappage within a valid hunk of the file if ($realcnt !=3D 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("patch seems to be corrupt (line wrapped?)\n" . --=20 2.46.0