From nobody Sun Nov 24 00:36:56 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1728316009; cv=none; d=zohomail.com; s=zohoarc; b=byaEMwwkdSLbQYt7/92DsDz8FyOeLLDTIz6VfQMSI6bhSvZSwk4XfYwwOSj0GWtTCdpDzivGjSYdbmJW5h03ncZ3cr/eD8UEexSVSoLlhrVGHjkpLiJiUykgx8h/QtzcdLP+dHFYTZdt3P/g8sIG/Ku56Z4n5769RqNMRIVHH4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728316009; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZTX+6cRA+/ltHCjvlFktg7Y59mCZ2nEaRmncVeNd1ko=; b=gVdzX8QEz6U79QGS7VaAs8pn60GhuF9rS5Low9DTF6OnOHvQ0pTM2Y4SHr2MPYsg/7ypZI1+QGwI+3LnlaLhHpCGIgDQnFnaGh9WEQnuU3Hw4W0dvhnllpWzvj811LrNzEZoYzXA65FOHIRK2zJXwfC2SZkQl/nRzC4H9HefmmE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728316009622575.6278621478954; Mon, 7 Oct 2024 08:46:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxpvt-0005AC-0B; Mon, 07 Oct 2024 11:46:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxpvp-00058o-Fy for qemu-devel@nongnu.org; Mon, 07 Oct 2024 11:45:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxpvo-0002Xe-1p for qemu-devel@nongnu.org; Mon, 07 Oct 2024 11:45:57 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-AbbImbsWNQSWd0oDYgUtlg-1; Mon, 07 Oct 2024 11:45:53 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DB2D1955EAB for ; Mon, 7 Oct 2024 15:45:52 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.61]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6224A300019E; Mon, 7 Oct 2024 15:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728315954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZTX+6cRA+/ltHCjvlFktg7Y59mCZ2nEaRmncVeNd1ko=; b=D+jDJ2sRvul/ejKjM5HA0ogkTkD+Wm/5H05P300BTb4pwLh4bRy0yKNLNs9sSXZY8QMPzn G4KRiDlmTX2x3ZqrHy8jqvL0aS8BeMK8YiBQfjxhaife8iu5pa/YEfTgpJvETNkRcjacqh MoN8jRYb0jvCwyh91QgiCetlbek7ZFo= X-MC-Unique: AbbImbsWNQSWd0oDYgUtlg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/3] scripts: mandate that new files have SPDX-License-Identifier Date: Mon, 7 Oct 2024 16:45:46 +0100 Message-ID: <20241007154548.1144961-2-berrange@redhat.com> In-Reply-To: <20241007154548.1144961-1-berrange@redhat.com> References: <20241007154548.1144961-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.153, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1728316017196116600 Going forward we want all newly created source files to have an SPDX-License-Identifier tag present. Initially mandate this for C, Python and Perl source files, and encourage this for other file types. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Brian Cain Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/checkpatch.pl | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1b21249c91..cc266abdcd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1378,6 +1378,8 @@ sub process { my $in_imported_file =3D 0; my $in_no_imported_file =3D 0; my $non_utf8_charset =3D 0; + my $expect_spdx =3D 0; + my $expect_spdx_file; =20 our @report =3D (); our $cnt_lines =3D 0; @@ -1615,6 +1617,30 @@ sub process { WARN("added, moved or deleted file(s), does MAINTAINERS need updating?\= n" . $herecurr); } =20 +# All new files should have a SPDX-License-Identifier tag + if ($line =3D~ /^new file mode\s*\d+\s*$/) { + if ($expect_spdx) { + if ($expect_spdx_file =3D~ /\.(c|h|py|pl|c\.inc)$/) { + # source code files MUST have SPDX license declared + ERROR("expected 'SPDX-License-Identifer' in new file $expect_spdx_f= ile"); + } else { + # Other files MAY have SPDX license if appropriate + WARNING("Does new file $expect_spdx_file need 'SPDX-License-Identif= er'?"); + } + } + $expect_spdx =3D 1; + $expect_spdx_file =3D undef; + } elsif ($expect_spdx) { + $expect_spdx_file =3D $realfile unless defined $expect_spdx_file; + + # SPDX tagsd may occurr in comments which were + # stripped from '$line', so use '$rawline' + if ($rawline =3D~ /SPDX-License-Identifier/) { + $expect_spdx =3D 0; + $expect_spdx_file =3D undef; + } + } + # Check for wrappage within a valid hunk of the file if ($realcnt !=3D 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("patch seems to be corrupt (line wrapped?)\n" . --=20 2.46.0