From nobody Sat Nov 23 22:18:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1728258348; cv=pass; d=zohomail.com; s=zohoarc; b=YkCBEKvY/7kZJ9cNKmhOD877meR/os5FmS+w7oI8BtwAgCKZq261y9Rt5WfIjhC8ytLThaQm2LcRckjuhyHWfbV77th6O37GFHuETr0KPE5bUw9ERcR10u25fY74JlDsBnVxx04PqHbMsteC6f/0+46KJ29SjCd++B+X132OuDg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728258348; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WmH0g9uXaTATJwwc+jZZxbH6AdRXlW8CeEtxhmUnXpA=; b=ic6cXWZ/q16X8aMlZtT3Q+e+GyISx8E8rPjyeO77+K/L6p+bH0dH1u3gcUu2kvAVqzFwUZ7hoHEMXrmSvGMWTheeRZqevLzRbsTSepiltOH/FE4jAR6skkrmkBy8xeF335RNZ4wdDr4A+2Zame4sW8iKP6UppFTE9biiqbRVaVY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728258348115886.3716972036373; Sun, 6 Oct 2024 16:45:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxaw5-00027R-Iv; Sun, 06 Oct 2024 19:45:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxavz-00024m-Sc for qemu-devel@nongnu.org; Sun, 06 Oct 2024 19:45:09 -0400 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxavt-00086W-Nn for qemu-devel@nongnu.org; Sun, 06 Oct 2024 19:45:05 -0400 Received: by mx.zohomail.com with SMTPS id 172825829083773.62333018968206; Sun, 6 Oct 2024 16:44:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728258292; cv=none; d=zohomail.com; s=zohoarc; b=i9ilvuxdzlPjRdwq1uFjilY/aCwAK6PhMkw/mnC62v0VAfBIbD+QqAuQUGRo2eq1MYKUuF6aUd7ptDW07RxSclxasZ6BPe1IBSycOIG8WxtPCywwhoxfIfgwcMcHOugoMTSMbVf+C8afbFk63eyHfGUbTIWFG6Wf+uNJuaLObsI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728258292; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=WmH0g9uXaTATJwwc+jZZxbH6AdRXlW8CeEtxhmUnXpA=; b=eUbgcnHOKA7h9U+jLjnNUXjc2O6KaxOLD5JW47XKwzPQoNnMMYuv4I44NTmSIufM2GanvrqCWFRN4v7AqPlYfmKtRMA6Tj/beirAJSYsL7S09Wy7OWip2hckRHhx45ovHem4wCFUNq1ZB+MFSC1tPX0TsWJxV+Sw/3PzojvWLqU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1728258292; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WmH0g9uXaTATJwwc+jZZxbH6AdRXlW8CeEtxhmUnXpA=; b=Zg6/F1yx5zey7P3nSggNai6VI0QrkurL+yHRm6mx82w8PkszofzQ3sn8jzWDhpOl A5lq4VjX6ZYOc2+5mbtvzjZ7Xm4pgx7GMXtIssWXHVgpjUlxsIM++Xqu6J1X8sjuSlx 97lIIz0Qy6J2HKw5iyXJjo+/F0GNKtGCygsbpZJw= From: Dmitry Osipenko To: Akihiko Odaki , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= Cc: Gert Wollny , qemu-devel@nongnu.org, Pierre-Eric Pelloux-Prayer Subject: [PATCH v1 1/2] ui/sdl2: Don't disable scanout when display is refreshed Date: Mon, 7 Oct 2024 02:43:52 +0300 Message-ID: <20241006234353.3201037-2-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241006234353.3201037-1-dmitry.osipenko@collabora.com> References: <20241006234353.3201037-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1728258349109116600 Content-Type: text/plain; charset="utf-8" Display refreshment is invoked by a timer and it erroneously disables the active scanout if it happens to be invoked after scanout has been enabled. This offending scanout-disable race condition with a timer can be easily hit when Qemu runs with a disabled vsync by using SDL or GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Signed-off-by: Dmitry Osipenko Reviewed-by: Akihiko Odaki Tested-by: Bernhard Beschow --- ui/sdl2-gl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index e01d9ab0c7bf..4975d923db38 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -51,7 +51,6 @@ static void sdl2_gl_render_surface(struct sdl2_console *s= con) int ww, wh; =20 SDL_GL_MakeCurrent(scon->real_window, scon->winctx); - sdl2_set_scanout_mode(scon, false); =20 SDL_GetWindowSize(scon->real_window, &ww, &wh); surface_gl_setup_viewport(scon->gls, scon->surface, ww, wh); --=20 2.46.0 From nobody Sat Nov 23 22:18:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1728258348; cv=pass; d=zohomail.com; s=zohoarc; b=OD0swQZbRDUkvVR0Tr5A/3w3wiR7vTYrii02pQbuZJeZvhNzrmO0WboQRs4K6EEbgU2+1+g/UWslF73Vv+vBRHlVSF8S/Tyn3WSQmXbExtJwXto9InBbJdwBj5louOzA2ZQkpstc6Z62Ld0u7E1V5/K1hTXn9HC783vCBIOPb18= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728258348; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=269vnLvX9Vv2nIzv48+PQhmt/ShfXsGuqSei/5TIQxk=; b=bceIfQ7PbKf++BUxHhrGXvcDOodPrh0JpzSHYAkxa2w7KJA16sBlehvk/HGRbij6PCF0IeJ5T4lUPhT27nlYCg6AM5MZSmVeQpH8zg5qaLuyKBxfriSvaFanxmqyT5NVfQI9Ca+9HGNiIFptq/jKEkNZi5psYirQn4HWJA5nGTE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172825834799244.16383421678154; Sun, 6 Oct 2024 16:45:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxaw9-000283-Bx; Sun, 06 Oct 2024 19:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxavx-000235-Fe for qemu-devel@nongnu.org; Sun, 06 Oct 2024 19:45:05 -0400 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxavt-00086n-Nl for qemu-devel@nongnu.org; Sun, 06 Oct 2024 19:45:04 -0400 Received: by mx.zohomail.com with SMTPS id 1728258293400764.5992852244028; Sun, 6 Oct 2024 16:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728258294; cv=none; d=zohomail.com; s=zohoarc; b=Ya2QUqFvFmtL1Q+6ZC44ruKPLVylb63zW2fwlsKMPmKohs+w2RtPTb53bnrXfHiT05/caQmQYxqG64QLw+qV9w4wEuGg7eoDYCLN8HNmesoAr40PyQsEB+1gZNFJpeVSqL24DPZqw1lGrS22oEgyqohoFIsbGrrfat3rdnFQ3jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728258294; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=269vnLvX9Vv2nIzv48+PQhmt/ShfXsGuqSei/5TIQxk=; b=QOUiBnp4WX0sHy4qmauwFfnkDIuQOhxt8Rb5iHaGmVcHgrFzaR1onTNVfFLrDQvJ8UBayEGuFMWaxT/Mb4q0h1GwPyphm1EEeg+aQGtRcB+c/cAWKz8Oy7DhkDhFs/ToruXxJt71G4tH8k2En0Zg7hrsMePhGPPc5wRMdpIn/fM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1728258294; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=269vnLvX9Vv2nIzv48+PQhmt/ShfXsGuqSei/5TIQxk=; b=kESga++DvQzbd0o6Wm2nbr0RUvNFvwi12DdPabYI0R51ef4ym208wXYs4/KgKH0X bLeNyr78YHyEHn/30GqiuHnIU/96nuNG4wuwr1VB04EZA4SimREUtMm3aoE/xfkX5uK iSr50AGE3XfrsHCWH+RtpGIS/F6Hj1aqwcOm9FUk= From: Dmitry Osipenko To: Akihiko Odaki , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= Cc: Gert Wollny , qemu-devel@nongnu.org, Pierre-Eric Pelloux-Prayer Subject: [PATCH v1 2/2] ui/gtk: Don't disable scanout when display is refreshed Date: Mon, 7 Oct 2024 02:43:53 +0300 Message-ID: <20241006234353.3201037-3-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20241006234353.3201037-1-dmitry.osipenko@collabora.com> References: <20241006234353.3201037-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.112; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1728258349111116600 Content-Type: text/plain; charset="utf-8" Display refreshment is invoked by a timer and it erroneously disables the active scanout if it happens to be invoked after scanout has been enabled. This offending scanout-disable race condition with a timer can be easily hit when Qemu runs with a disabled vsync by using SDL or GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Signed-off-by: Dmitry Osipenko Reviewed-by: Akihiko Odaki --- ui/gtk-egl.c | 1 - ui/gtk-gl-area.c | 1 - 2 files changed, 2 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index 9831c10e1bd5..6b85a51c4284 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -179,7 +179,6 @@ void gd_egl_refresh(DisplayChangeListener *dcl) =20 if (vc->gfx.glupdates) { vc->gfx.glupdates =3D 0; - gtk_egl_set_scanout_mode(vc, false); gd_egl_draw(vc); } } diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index b628b354510d..b00817abc011 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -148,7 +148,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl) =20 if (vc->gfx.glupdates) { vc->gfx.glupdates =3D 0; - gtk_gl_area_set_scanout_mode(vc, false); gtk_gl_area_queue_render(GTK_GL_AREA(vc->gfx.drawing_area)); } } --=20 2.46.0