From nobody Sat Nov 23 23:30:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1728046982; cv=none; d=zohomail.com; s=zohoarc; b=WS/hlMoXFzIF6Jpa/ccWucdPLmFQx2+ZTT+vGLdwNQRvQypty1VS00sf9qiOEOsodUcGG3iNdWlyFWzt2aT7hb1NyHu5lgiGb9bIFEVSJflmWrVff7TfqrQOKZAZvrvGS+IALhPjL6Itv1G0RnoxT8ApBaWhEtoIhzVgDzuf4Vc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1728046982; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DtReNS6pT4fNYyHx94Lkyyryh1zP1mLYJecc8WY04KY=; b=A00iH/OlP9Ogh+Qy8t9iV6FzV8g7XfwEs9TNA2eHtuFJFCXh0k6JZpcOWhmsRz+VpXH+ZYMOXSaEFyHWt1M63JFAaZfWeRuGafP/qZiqlDSRqpl5o2RqfhYTPcO+XzlZXq+n0SdixAT+R8oU50SZ1qBoZbVavVqqZGv83hwfE6k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1728046982745737.0654579787986; Fri, 4 Oct 2024 06:03:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swhxC-0001HU-Fo; Fri, 04 Oct 2024 09:02:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swhx5-0001Gs-Iw for qemu-devel@nongnu.org; Fri, 04 Oct 2024 09:02:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swhx4-0007mt-2G for qemu-devel@nongnu.org; Fri, 04 Oct 2024 09:02:35 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-tydbeoHjOIa5kS9lTofiWQ-1; Fri, 04 Oct 2024 09:02:31 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F0BF21955F42; Fri, 4 Oct 2024 13:02:29 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.65]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 62EFB19560AE; Fri, 4 Oct 2024 13:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728046952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DtReNS6pT4fNYyHx94Lkyyryh1zP1mLYJecc8WY04KY=; b=G6gU+peh4sVsNtc5TFgUslJ8OZmiSutOGD1zZ6GNOw5sdqB88VQMsr7d5hU8Sfw4TCuXzC 2SvtnpYZShSM8PowjSNVx88BXcnBrL0V/oHB0WkbrCUdXbnPYHLP2VLrZI7DFrOHk2KGCW xq6PXE+FF5W5kw4ExDB0qEcq2apOe8k= X-MC-Unique: tydbeoHjOIa5kS9lTofiWQ-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain Subject: [PATCH] tests/functional: Fix hash validation Date: Fri, 4 Oct 2024 15:02:25 +0200 Message-ID: <20241004130225.217441-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.146, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1728046984492116600 Content-Type: text/plain; charset="utf-8" The _check() function is supposed to check whether the hash of the downloaded file matches the expected one. Unfortunately, during the last rework of this function, the check was accidentally turned into returning the hash value itself instead of a True/False value, effectively accepting each hash as valid. Let's do a proper check again now. Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...") Signed-off-by: Thomas Huth Reviewed-by: Manos Pitsidianakis --- tests/functional/qemu_test/asset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_te= st/asset.py index 3ec429217e..e47bfac035 100644 --- a/tests/functional/qemu_test/asset.py +++ b/tests/functional/qemu_test/asset.py @@ -57,7 +57,7 @@ def _check(self, cache_file): break hl.update(chunk) =20 - return hl.hexdigest() + return self.hash =3D=3D hl.hexdigest() =20 def valid(self): return self.cache_file.exists() and self._check(self.cache_file) --=20 2.46.1