From nobody Sun Nov 24 02:33:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1727858324; cv=none; d=zohomail.com; s=zohoarc; b=NPM+l+F0WmMvl58KOWBOoq8asAuVos4c9bLHyMRZjkwsNHYxDFygKT4QhvLEqEeBZMPMG39BuwXSaRVLsxNqfPhOKNZpLgWWUIX+JhZM5Zq+c6fok/JCnOfA6So+o6dYHGadAqGcDqG+SRFLueZpG9+kDCM7Wvs7OuCswoqkVO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727858324; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JWGVABklCLrU7/ALyC116NV9eFWhHW+S/KvcK29JhAU=; b=mnallNWMJX53vIBfe2aWRJT174Pw8RnBSCgI9JZRs8r0eLEYsB5U6LOUdVqiYCiz+qVr/BRX2myx36tCjAfTKgpbnAn9Aetv3mOjopSygdI3/L1HQM6eRJIuTUuJqiY+BmvLF5WFtqDVSH2m2TAmtfRuRQgoc8R/DDjpM9gU+4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1727858324678664.62867457426; Wed, 2 Oct 2024 01:38:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svurj-0001mF-Hl; Wed, 02 Oct 2024 04:37:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svurc-0001ds-EL for qemu-devel@nongnu.org; Wed, 02 Oct 2024 04:37:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svura-0005ib-WA for qemu-devel@nongnu.org; Wed, 02 Oct 2024 04:37:40 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-h3KgxobKNgubi7Xauoo3ow-1; Wed, 02 Oct 2024 04:37:33 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77BE71955EE9; Wed, 2 Oct 2024 08:37:32 +0000 (UTC) Received: from localhost (unknown [10.39.208.36]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 66AA33000197; Wed, 2 Oct 2024 08:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727858257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JWGVABklCLrU7/ALyC116NV9eFWhHW+S/KvcK29JhAU=; b=Gp9rkI+IolBYUnDEK+bOJiFU+gwlhCmpSfyjd3SR0bGKhr8ojfeJ+8NNicMDvaASXeHlF1 9bsZBvhnFZdFme1bUG8WbdCKAJfrk3MVCsoSvN88WiwezMmO8u6vtNQhbWnrgRRG7v30kB Ip9GINBSU8EEUGly3HsQAVCzrQHp6qI= X-MC-Unique: h3KgxobKNgubi7Xauoo3ow-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Fam Zheng , "Michael S. Tsirkin" , Stefano Garzarella Subject: [PULL 09/22] hw/vhost-scsi: fix -Werror=maybe-uninitialized Date: Wed, 2 Oct 2024 12:36:32 +0400 Message-ID: <20241002083646.2893078-10-marcandre.lureau@redhat.com> In-Reply-To: <20241002083646.2893078-1-marcandre.lureau@redhat.com> References: <20241002083646.2893078-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1727858326784116600 From: Marc-Andr=C3=A9 Lureau ../hw/scsi/vhost-scsi.c:173:12: error: =E2=80=98ret=E2=80=99 may be used un= initialized [-Werror=3Dmaybe-uninitialized] It can be reached when num_queues=3D0. It probably doesn't make much sense to instantiate a vhost-scsi with 0 IO queues though. For now, make vhost_scsi_set_workers() return success/0 anyway, when no workers have been setup. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefano Garzarella --- hw/scsi/vhost-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index 49cff2a0cb..22d16dc26b 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -172,7 +172,7 @@ static int vhost_scsi_set_workers(VHostSCSICommon *vsc,= bool per_virtqueue) struct vhost_dev *dev =3D &vsc->dev; struct vhost_vring_worker vq_worker; struct vhost_worker_state worker; - int i, ret; + int i, ret =3D 0; =20 /* Use default worker */ if (!per_virtqueue || dev->nvqs =3D=3D VHOST_SCSI_VQ_NUM_FIXED + 1) { --=20 2.45.2.827.g557ae147e6