From nobody Wed Oct 23 00:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1727684488; cv=none; d=zohomail.com; s=zohoarc; b=WxUX1ylFoAyk5Q6RWWKMnZxFpC3qyoFwIqTXG5BhZ3uhK0G1BQOWdaOLIRUA6SN7174KHPxp5PBTnjhPUOGiXbAWp9HDkSx8i1ZrNQdEDIrarMzioXWKAh396kGAnb+JWGSdYHNSjwxGx7/ahBFaFp9j4cdRqhYul7RW+K3p+I4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727684488; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xtGJwVXMrFzPBkMfLTJwPBwE9R7SBDoRTUi3pO0/Y7E=; b=f9xEdGixq3c5ugneonvh2p9XDqxjwsI3V7SgtMUMY19S49aU985ZN66XC4IXiDqOHis/QNAWTX7V6WfKNfm3+h734d+WJvpS8HAoDS5B0HFDyo3IPyvpLjh0BSP2RXSoMeBKRr2iAZOQuhvQmFIYNyYVwmxlO7V4YE1eOi07I9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1727684488618481.11507066960144; Mon, 30 Sep 2024 01:21:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svBck-0007Bp-9g; Mon, 30 Sep 2024 04:19:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svBaU-0005eE-Ix for qemu-devel@nongnu.org; Mon, 30 Sep 2024 04:17:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svBaS-0005tR-8B for qemu-devel@nongnu.org; Mon, 30 Sep 2024 04:16:58 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-3T0HPuNQMMiFF_pTTiSmBQ-1; Mon, 30 Sep 2024 04:16:52 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8F3B71935852; Mon, 30 Sep 2024 08:16:48 +0000 (UTC) Received: from localhost (unknown [10.39.208.36]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 504091955DC7; Mon, 30 Sep 2024 08:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727684215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xtGJwVXMrFzPBkMfLTJwPBwE9R7SBDoRTUi3pO0/Y7E=; b=dWGrVnP0GMBocT4irmiv5yMCh0py7AFUf8bzOiv7OysZJcZfsYAWwbqYjkNJtqkR8huCUf u6b5lKe4FBfeK5+ODFVxZyK3+wBeXZbuKXwChfC0eplU4NCzfXp9iHD8pXh/ETMXBehIXB PaDJS6f4u96ftJbScwET2eYe8HNqqKM= X-MC-Unique: 3T0HPuNQMMiFF_pTTiSmBQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Hanna Reitz , Christian Schoenebeck , Fam Zheng , Song Gao , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , Mahmoud Mandour , qemu-block@nongnu.org, Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Vladimir Sementsov-Ogievskiy , Greg Kurz , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Gerd Hoffmann , Bin Meng , Fabiano Rosas , Eric Blake , Hyman Huang , Kevin Wolf , Stefano Garzarella , "Michael S. Tsirkin" , Alexandre Iooss , Marcel Apfelbaum , John Snow , Eduardo Habkost , Jesper Devantier , Peter Xu , Stefan Hajnoczi , Klaus Jensen , Keith Busch , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Yuval Shaia , Bin Meng , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v3 15/22] linux-user/hppa: fix -Werror=maybe-uninitialized false-positive Date: Mon, 30 Sep 2024 12:14:50 +0400 Message-ID: <20240930081458.1926382-16-marcandre.lureau@redhat.com> In-Reply-To: <20240930081458.1926382-1-marcandre.lureau@redhat.com> References: <20240930081458.1926382-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.095, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1727684490033116600 From: Marc-Andr=C3=A9 Lureau ../linux-user/hppa/cpu_loop.c: In function =E2=80=98hppa_lws=E2=80=99: ../linux-user/hppa/cpu_loop.c:106:17: error: =E2=80=98ret=E2=80=99 may be u= sed uninitialized [-Werror=3Dmaybe-uninitialized] 106 | env->gr[28] =3D ret; Signed-off-by: Marc-Andr=C3=A9 Lureau --- linux-user/hppa/cpu_loop.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/linux-user/hppa/cpu_loop.c b/linux-user/hppa/cpu_loop.c index bc093b8fe8..f4da95490e 100644 --- a/linux-user/hppa/cpu_loop.c +++ b/linux-user/hppa/cpu_loop.c @@ -43,7 +43,7 @@ static abi_ulong hppa_lws(CPUHPPAState *env) old =3D tswap32(old); new =3D tswap32(new); ret =3D qatomic_cmpxchg((uint32_t *)g2h(cs, addr), old, new); - ret =3D tswap32(ret); + env->gr[28] =3D tswap32(ret); break; =20 case 2: /* elf32 atomic "new" cmpxchg */ @@ -64,19 +64,19 @@ static abi_ulong hppa_lws(CPUHPPAState *env) old =3D *(uint8_t *)g2h(cs, old); new =3D *(uint8_t *)g2h(cs, new); ret =3D qatomic_cmpxchg((uint8_t *)g2h(cs, addr), old, new); - ret =3D ret !=3D old; + env->gr[28] =3D ret !=3D old; break; case 1: old =3D *(uint16_t *)g2h(cs, old); new =3D *(uint16_t *)g2h(cs, new); ret =3D qatomic_cmpxchg((uint16_t *)g2h(cs, addr), old, new); - ret =3D ret !=3D old; + env->gr[28] =3D ret !=3D old; break; case 2: old =3D *(uint32_t *)g2h(cs, old); new =3D *(uint32_t *)g2h(cs, new); ret =3D qatomic_cmpxchg((uint32_t *)g2h(cs, addr), old, new); - ret =3D ret !=3D old; + env->gr[28] =3D ret !=3D old; break; case 3: { @@ -97,13 +97,13 @@ static abi_ulong hppa_lws(CPUHPPAState *env) } end_exclusive(); #endif + env->gr[28] =3D ret; } break; } break; } =20 - env->gr[28] =3D ret; return 0; } =20 --=20 2.45.2.827.g557ae147e6