From nobody Wed Oct 23 00:31:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1727684423; cv=none; d=zohomail.com; s=zohoarc; b=L/aZRL3Ll5UjrW/JVLLYIOKhEpdByW5x9q7D0vt4ea/pTQks61kPsxzu6JUCWoAeilXtpf54gGjNv0fc92E4RbENx31fvCbYkubhvejB5Ug6qY4z5syFG0vEC8nl7Sr/XxUY4tIa5dTUtT9AgaPKcFfxR1WjP/EuonRv696OMD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727684423; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=n8dGE0A38f5VTr5H+JPJ+JEIz9Dt2fSH4V7WEzu6LPU=; b=ZbV58Zakp3U8NoZarVq2/PH+JlxCcuy27YFOgh9hhMsqisnZ76hHUpxmSaacTnvNlox1DMQIHkM5u+nSx08oZXRvYHSiCLcEfNc0JeHhzW/yq8oUiXM2QYFaQ73f166sQk6Sfxx63lFOcqZ1J18fJkHrfDkHOisZgsxb1kOyGF4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1727684423335307.95744134774145; Mon, 30 Sep 2024 01:20:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svBbE-0007sF-Eh; Mon, 30 Sep 2024 04:17:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svBaB-0004dV-PO for qemu-devel@nongnu.org; Mon, 30 Sep 2024 04:16:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svBa9-0005qG-1C for qemu-devel@nongnu.org; Mon, 30 Sep 2024 04:16:38 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-leZvvJVBOCydAAzUohkKSg-1; Mon, 30 Sep 2024 04:16:32 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D71661933140; Mon, 30 Sep 2024 08:16:29 +0000 (UTC) Received: from localhost (unknown [10.39.208.36]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D10F91955DC7; Mon, 30 Sep 2024 08:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727684196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n8dGE0A38f5VTr5H+JPJ+JEIz9Dt2fSH4V7WEzu6LPU=; b=COaj88y/I5Q5S0mNdwqxHu+aw6i6OzHzckvxBZNxFNshKIb2ldc+ig2DnhZ0ZHfntWhlA7 JSZlPqCSzOnKpwtvQRjlDYK6rzqbrAv8UstjcAFfnKPE+hOskZFBfRFQkdnj4bsa0T1d8a mrBybZDcJYHRoC5mWc3AzWyA7hrzlBE= X-MC-Unique: leZvvJVBOCydAAzUohkKSg-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Hanna Reitz , Christian Schoenebeck , Fam Zheng , Song Gao , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , Mahmoud Mandour , qemu-block@nongnu.org, Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Vladimir Sementsov-Ogievskiy , Greg Kurz , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Gerd Hoffmann , Bin Meng , Fabiano Rosas , Eric Blake , Hyman Huang , Kevin Wolf , Stefano Garzarella , "Michael S. Tsirkin" , Alexandre Iooss , Marcel Apfelbaum , John Snow , Eduardo Habkost , Jesper Devantier , Peter Xu , Stefan Hajnoczi , Klaus Jensen , Keith Busch , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Yuval Shaia , Bin Meng , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v3 12/22] migration: fix -Werror=maybe-uninitialized false-positives Date: Mon, 30 Sep 2024 12:14:47 +0400 Message-ID: <20240930081458.1926382-13-marcandre.lureau@redhat.com> In-Reply-To: <20240930081458.1926382-1-marcandre.lureau@redhat.com> References: <20240930081458.1926382-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.095, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1727684424454116600 From: Marc-Andr=C3=A9 Lureau ../migration/dirtyrate.c:186:5: error: =E2=80=98records=E2=80=99 may be use= d uninitialized [-Werror=3Dmaybe-uninitialized] ../migration/dirtyrate.c:168:12: error: =E2=80=98gen_id=E2=80=99 may be use= d uninitialized [-Werror=3Dmaybe-uninitialized] ../migration/migration.c:2273:5: error: =E2=80=98file=E2=80=99 may be used = uninitialized [-Werror=3Dmaybe-uninitialized] Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Peter Xu Reviewed-by: Hyman Huang --- migration/dirtyrate.c | 4 ++-- migration/migration.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 5478d58de3..233acb0855 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -149,12 +149,12 @@ int64_t vcpu_calculate_dirtyrate(int64_t calc_time_ms, unsigned int flag, bool one_shot) { - DirtyPageRecord *records; + DirtyPageRecord *records =3D NULL; int64_t init_time_ms; int64_t duration; int64_t dirtyrate; int i =3D 0; - unsigned int gen_id; + unsigned int gen_id =3D 0; =20 retry: init_time_ms =3D qemu_clock_get_ms(QEMU_CLOCK_REALTIME); diff --git a/migration/migration.c b/migration/migration.c index ae2be31557..021faee2f3 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2278,7 +2278,7 @@ static bool migrate_handle_rp_resume_ack(MigrationSta= te *s, */ static void migration_release_dst_files(MigrationState *ms) { - QEMUFile *file; + QEMUFile *file =3D NULL; =20 WITH_QEMU_LOCK_GUARD(&ms->qemu_file_lock) { /* --=20 2.45.2.827.g557ae147e6