From nobody Wed Oct 23 01:26:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1727183246; cv=none; d=zohomail.com; s=zohoarc; b=NBg5lK6YWo5JoZ321LRE0rjR3scJ66tiw6ENKQvCCl3BCRlI7OIrdpVtRb2WkU37cuUEXvmQxIx1QiI6C2Eh0gHUqfF6Z0tx7B9Y3ZRqzUVwGv35E9UfZMJXG3PxSjnsB80Ty96RRTXjDP4hckrKNRllIGFeXuQ1KBIE/T5CRG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1727183246; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lM3KpPrye86/Cu4EqGuleHP2TkpZj/gEzbpsHn25xPs=; b=lX3cDn3l50wSkyMACZHlWE9B4fhi2tgZ5Sy848P54T8TuTd5MxqpG3OIwO4MnqWTeYHnFmEvoWMWGjddMi5+5A47Q+uKH8IIR6TdfQ9Nuz38kklv5VLZFI3yS8fg0bzsLEE/C+C8OY8WytpjIwg+A45ZtXDTJUGFccq+o2JvP20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1727183246629507.21292063025385; Tue, 24 Sep 2024 06:07:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st5G0-0001HX-H2; Tue, 24 Sep 2024 09:07:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st5FY-0008Fk-Ro for qemu-devel@nongnu.org; Tue, 24 Sep 2024 09:06:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st5FX-0000U1-7q for qemu-devel@nongnu.org; Tue, 24 Sep 2024 09:06:40 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-aogsTG9rN4mymFWT5uF2aQ-1; Tue, 24 Sep 2024 09:06:34 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 61F0918E6E3F; Tue, 24 Sep 2024 13:06:31 +0000 (UTC) Received: from localhost (unknown [10.39.208.3]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5122F1956048; Tue, 24 Sep 2024 13:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727183198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lM3KpPrye86/Cu4EqGuleHP2TkpZj/gEzbpsHn25xPs=; b=eURLnsqnloCeF3iip4dQB4psfc2Xou0GXHxwS+grTX2kFJqFzKmZZtUMiXIriiRaRiw537 nvbtAfDmU28aSfvbYVx/mHj2+brcPmOmdAzsHwmLjKwd1bVSXO/r78x7nHEqszYwXYq29K 7RoqE5PI8BM6jR+T/GBLtrGYzamqLmY= X-MC-Unique: aogsTG9rN4mymFWT5uF2aQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: Song Gao , Peter Xu , Bin Meng , Mahmoud Mandour , Hyman Huang , Klaus Jensen , Alexandre Iooss , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Marcel Apfelbaum , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , John Snow , Jesper Devantier , Bin Meng , Greg Kurz , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Stefan Hajnoczi , Yuval Shaia , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Vladimir Sementsov-Ogievskiy , Christian Schoenebeck , Pierrick Bouvier , Fabiano Rosas , Keith Busch , Eric Blake , qemu-block@nongnu.org, Kevin Wolf , Laurent Vivier , Gerd Hoffmann , Fam Zheng , Eduardo Habkost , Stefano Garzarella , Hanna Reitz , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH v2 06/22] block/mirror: fix -Werror=maybe-uninitialized false-positive Date: Tue, 24 Sep 2024 17:05:37 +0400 Message-ID: <20240924130554.749278-7-marcandre.lureau@redhat.com> In-Reply-To: <20240924130554.749278-1-marcandre.lureau@redhat.com> References: <20240924130554.749278-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.09, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1727183247840116600 From: Marc-Andr=C3=A9 Lureau ../block/mirror.c:404:5: error: =E2=80=98ret=E2=80=99 may be used uninitial= ized [-Werror=3Dmaybe-uninitialized] ../block/mirror.c:895:12: error: =E2=80=98ret=E2=80=99 may be used uninitia= lized [-Werror=3Dmaybe-uninitialized] ../block/mirror.c:578:12: error: =E2=80=98ret=E2=80=99 may be used uninitia= lized [-Werror=3Dmaybe-uninitialized] Signed-off-by: Marc-Andr=C3=A9 Lureau --- block/mirror.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 54e3a7ea9d..fd55a580fb 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -349,7 +349,7 @@ static void coroutine_fn mirror_co_read(void *opaque) MirrorOp *op =3D opaque; MirrorBlockJob *s =3D op->s; int nb_chunks; - uint64_t ret; + uint64_t ret =3D -1; uint64_t max_bytes; =20 max_bytes =3D s->granularity * s->max_iov; @@ -565,7 +565,7 @@ static void coroutine_fn GRAPH_UNLOCKED mirror_iteratio= n(MirrorBlockJob *s) =20 bitmap_set(s->in_flight_bitmap, offset / s->granularity, nb_chunks); while (nb_chunks > 0 && offset < s->bdev_length) { - int ret; + int ret =3D -1; int64_t io_bytes; int64_t io_bytes_acct; MirrorMethod mirror_method =3D MIRROR_METHOD_COPY; @@ -841,7 +841,7 @@ static int coroutine_fn GRAPH_UNLOCKED mirror_dirty_ini= t(MirrorBlockJob *s) int64_t offset; BlockDriverState *bs; BlockDriverState *target_bs =3D blk_bs(s->target); - int ret; + int ret =3D -1; int64_t count; =20 bdrv_graph_co_rdlock(); --=20 2.45.2.827.g557ae147e6