From nobody Tue Oct 22 23:28:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1726903882; cv=none; d=zohomail.com; s=zohoarc; b=KgJAlT9VGmHMXhNPAu8VIKntMbihKn2hi5GIHmLzEEAY35eeOoiIbfrxZYY6FkD4Vktju9zyxQF2D+ymHPF95HrqX1wd4P0fz0np7Cw2gL95kydhLNkYsTrGFUAyEkkjcwVGK2liofm1RrM14Uu+X0gIBNDvkl77QkeUkcKDSpw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726903882; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=k0Wxs7kBfWOJ5yX+nxciaC89wdOb1WYHBZYFrLIkU0c=; b=jyfxxBb2ip2+yGcgtkhbFXVRAQP3ZlgKDKDf5h/7bEk74wxl9TrTH7n+6Z4MuTxl4h/TrAJ7yGQ8qYUtnTjXvV4ij442aZ10bvgbxr+2Z/+2fazVTBiOOS3sXCEBUbZfVOVlHw/7pMUbYq3SwWwiPmnKRA6Ru3KrPT9nWY1CXRY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1726903882806809.0731999506697; Sat, 21 Sep 2024 00:31:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sruZZ-0003fa-JL; Sat, 21 Sep 2024 03:30:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sruZW-0003dN-Ll for qemu-devel@nongnu.org; Sat, 21 Sep 2024 03:30:26 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sruZU-0004JM-I1 for qemu-devel@nongnu.org; Sat, 21 Sep 2024 03:30:26 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2f753375394so20826641fa.0 for ; Sat, 21 Sep 2024 00:30:21 -0700 (PDT) Received: from fitlet2.primaryno.de ([185.154.111.57]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f79d2e1eb5sm21204591fa.27.2024.09.21.00.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Sep 2024 00:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726903820; x=1727508620; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k0Wxs7kBfWOJ5yX+nxciaC89wdOb1WYHBZYFrLIkU0c=; b=U2cz8mGgyc8kEfdMBVUnpgJhLPfqHse2qt4IUEnz2+2OzEF0MipMZedFGKbPBL+dLJ OwOdsBgmVGTh7kFG1gd5wZHpB+CJ6vp03VUyyrGxISYQmpYTtJ1Qg0JatPElqkRK6dj+ Rnv2gDvjVq1+OyXR7VhBRhn3jLA/xp3m4LPDpo0murNpaVtGM4jm6j8jaB/Yh/pY/Isi LnkcLdUMHgQ4ymT5oDVcUWuaF3c9X0eOl7g7J6H5o3ATHV/jB8FtzKVXzLjK24FH3ojg JpmyYEhQ0NgK91AWe2a0YLb0bFAxQK4UM8e4cONxNHaVdefHy1qzaId6QlyG8gcOK2pB TOHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726903820; x=1727508620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k0Wxs7kBfWOJ5yX+nxciaC89wdOb1WYHBZYFrLIkU0c=; b=T8TPilONJRSYIb7v2eLeso5Zbpktp2yNE3UA+067TYVnQ0mEwC0oeRLvnggA6AY/Bb qX+2tBqzcWar6v4JMFGXuxYxPbt2HYl0kFfsNKjUNKJnukZ+W0h2VWGZPcRuS3NQeOqX g5lwNpiLNmbig651xctpS+oo2atG6y8MRUIIuklk7c/1wEg/46bz0vGTs/ncJXbR+sbG 73v/f7OZxFpSnPf1Od1ikUgD/sFtbisBItEDI6ommDc8FqAaxwZL0C5U9ZmEuu5yNiyP d+MP9IaziyVSX7IaQ2ckL7Aj/28iQ+VOtS6OYwNI1wBRr6/Et8yTNIWA3kWBOjkiW7He Mxxw== X-Forwarded-Encrypted: i=1; AJvYcCWVH9Bue7zwLYyfcCi9sO6ouVQ389BlDSm776kC42sqjR8U9HT6XKYv19RVZXHEr1Jxiq/zTMed7xpL@nongnu.org X-Gm-Message-State: AOJu0Yxzx+9XCDlnhcKB/j1eknMGsE7YcG+ENZ8QwWmN2am//pyR4DPd b06AxpMBu8AUNaSJUl9fk8MSoCms4SnuDpsGnAyuWNYmmy76djYs X-Google-Smtp-Source: AGHT+IEGlBo5nanFXphY7i36DysS0rtnC8Jcu3qMLF5iLgKlCPf+Lbdv96iy6HKfyC2G9Oqn0i/dUw== X-Received: by 2002:a2e:be0e:0:b0:2f7:7cc3:306 with SMTP id 38308e7fff4ca-2f7cc366f4emr31073721fa.17.1726903819720; Sat, 21 Sep 2024 00:30:19 -0700 (PDT) From: Hal Martin To: mst@redhat.com Cc: Hal Martin , qemu-devel@nongnu.org, imammedo@redhat.com, anisinha@redhat.com Subject: [PATCH v2] hw/smbios: support for type 7 (cache information) Date: Sat, 21 Sep 2024 07:29:55 +0000 Message-Id: <20240921072955.7150-1-hal.martin@gmail.com> X-Mailer: git-send-email 2.38.5 In-Reply-To: <20240911071848-mutt-send-email-mst@kernel.org> References: <20240911071848-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=hal.martin@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1726903884662116600 Content-Type: text/plain; charset="utf-8" This patch adds support for SMBIOS type 7 (Cache Information) to qemu. level: cache level (1-8) size: cache size in bytes Example usage: -smbios type=3D7,level=3D1,size=3D0x8000 Signed-off-by: Hal Martin --- hw/smbios/smbios.c | 64 ++++++++++++++++++++++++++++++++++++ include/hw/firmware/smbios.h | 18 ++++++++++ qemu-options.hx | 2 ++ 3 files changed, 84 insertions(+) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index a394514264..b71d5b0a92 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -83,6 +83,12 @@ static struct { .processor_family =3D 0x01, /* Other */ }; =20 +struct type7_instance { + uint16_t level, size; + QTAILQ_ENTRY(type7_instance) next; +}; +static QTAILQ_HEAD(, type7_instance) type7 =3D QTAILQ_HEAD_INITIALIZER(typ= e7); + struct type8_instance { const char *internal_reference, *external_reference; uint8_t connector_type, port_type; @@ -330,6 +336,23 @@ static const QemuOptDesc qemu_smbios_type4_opts[] =3D { { /* end of list */ } }; =20 +static const QemuOptDesc qemu_smbios_type7_opts[] =3D { + { + .name =3D "type", + .type =3D QEMU_OPT_NUMBER, + .help =3D "SMBIOS element type", + },{ + .name =3D "level", + .type =3D QEMU_OPT_NUMBER, + .help =3D "cache level", + },{ + .name =3D "size", + .type =3D QEMU_OPT_NUMBER, + .help =3D "cache size", + }, + { /* end of list */ } +}; + static const QemuOptDesc qemu_smbios_type8_opts[] =3D { { .name =3D "type", @@ -733,6 +756,33 @@ static void smbios_build_type_4_table(MachineState *ms= , unsigned instance, smbios_type4_count++; } =20 +static void smbios_build_type_7_table(void) +{ + unsigned instance =3D 0; + struct type7_instance *t7; + char designation[20]; + + QTAILQ_FOREACH(t7, &type7, next) { + SMBIOS_BUILD_TABLE_PRE(7, T0_BASE + instance, true); + sprintf(designation, "CPU Internal L%d", t7->level); + SMBIOS_TABLE_SET_STR(7, socket_designation, designation); + /* cache not socketed, enabled, write back */ + t->cache_configuration =3D 0x180 | ((t7->level) - 1); + t->installed_size =3D t7->size; + t->maximum_cache_size =3D t7->size; /* set max to installed */ + t->supported_sram_type =3D 0x10; /* pipeline burst */ + t->current_sram_type =3D 0x10; /* pipeline burst */ + t->cache_speed =3D 0x1; /* 1 ns */ + t->error_correction_type =3D 0x6; /* Multi-bit ECC */ + t->system_cache_type =3D 0x05; /* Unified */ + t->associativity =3D 0x6; /* Fully Associative */ + t->maximum_cache_size2 =3D t7->size; + t->installed_cache_size2 =3D t7->size; + SMBIOS_BUILD_TABLE_POST; + instance++; + } +} + static void smbios_build_type_8_table(void) { unsigned instance =3D 0; @@ -1120,6 +1170,7 @@ static bool smbios_get_tables_ep(MachineState *ms, } } =20 + smbios_build_type_7_table(); smbios_build_type_8_table(); smbios_build_type_9_table(errp); smbios_build_type_11_table(); @@ -1478,6 +1529,19 @@ void smbios_entry_add(QemuOpts *opts, Error **errp) UINT16_MAX); } return; + case 7: + if (!qemu_opts_validate(opts, qemu_smbios_type7_opts, errp)) { + return; + } + struct type7_instance *t7_i; + t7_i =3D g_new0(struct type7_instance, 1); + t7_i->level =3D qemu_opt_get_number(opts, "level", 0x0); + t7_i->size =3D qemu_opt_get_number(opts, "size", 0x0200); + /* Only cache levels 1-8 are permitted */ + if (t7_i->level > 0 && t7_i->level < 9) { + QTAILQ_INSERT_TAIL(&type7, t7_i, next); + } + return; case 8: if (!qemu_opts_validate(opts, qemu_smbios_type8_opts, errp)) { return; diff --git a/include/hw/firmware/smbios.h b/include/hw/firmware/smbios.h index f066ab7262..1ea1506b46 100644 --- a/include/hw/firmware/smbios.h +++ b/include/hw/firmware/smbios.h @@ -220,6 +220,24 @@ typedef enum smbios_type_4_len_ver { SMBIOS_TYPE_4_LEN_V30 =3D offsetofend(struct smbios_type_4, thread_cou= nt2), } smbios_type_4_len_ver; =20 +/* SMBIOS type 7 - Cache Information (v2.0+) */ +struct smbios_type_7 { + struct smbios_structure_header header; + uint8_t socket_designation; + uint16_t cache_configuration; + uint16_t maximum_cache_size; + uint16_t installed_size; + uint16_t supported_sram_type; + uint16_t current_sram_type; + uint8_t cache_speed; + uint8_t error_correction_type; + uint8_t system_cache_type; + uint8_t associativity; + uint32_t maximum_cache_size2; + uint32_t installed_cache_size2; + /* contained elements follow */ +} QEMU_PACKED; + /* SMBIOS type 8 - Port Connector Information */ struct smbios_type_8 { struct smbios_structure_header header; diff --git a/qemu-options.hx b/qemu-options.hx index d94e2cbbae..21c05821d5 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2706,6 +2706,8 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios, " [,asset=3Dstr][,part=3Dstr][,max-speed=3D%d][,current-s= peed=3D%d]\n" " [,processor-family=3D%d][,processor-id=3D%d]\n" " specify SMBIOS type 4 fields\n" + "-smbios type=3D7[,level=3D%d][,size=3D%d]\n" + " specify SMBIOS type 7 fields\n" "-smbios type=3D8[,external_reference=3Dstr][,internal_reference=3Dstr= ][,connector_type=3D%d][,port_type=3D%d]\n" " specify SMBIOS type 8 fields\n" "-smbios type=3D11[,value=3Dstr][,path=3Dfilename]\n" --=20 2.42.0