From nobody Wed Oct 23 01:35:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1726721778; cv=none; d=zohomail.com; s=zohoarc; b=K952CmHEFfHbtetineQ19p9MRqX8GuUMvynLf27n6UwwSoOKa5mDlhxlEQz9+j3HIFU2qdr/NPz1mP6me9MaR62csIq7lCvH5EkaGm5Snn8M/9ct6z+3WIeXKogu1S2d83/mhRHChW/lr7Ygfrn9hakHKjQRkGla3MjymkGW/pE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726721778; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=hpuf7Hz/nnboqctGM+eF5tUHnfJukhx/Vl/pv0YGeriPWhkIUK0qggAtGoHpqbyoT5RkYYjxsgxE0NhBBPua/y9J+GxxwaBKoXImTAAYwbhRfcI4oFckc+lOjg4Ufnm6+X2DzJoz4njjSWGtB0beRi+qewiL1cKpdt058GZTtTI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172672177796373.16521713606187; Wed, 18 Sep 2024 21:56:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sr94T-0000AE-G5; Thu, 19 Sep 2024 00:47:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sr94R-0008T4-Nn for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:11 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sr94J-0007AW-Sw for qemu-devel@nongnu.org; Thu, 19 Sep 2024 00:47:09 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-7db299608e7so261291a12.1 for ; Wed, 18 Sep 2024 21:47:03 -0700 (PDT) Received: from linaro.. (216-180-64-156.dyn.novuscom.net. [216.180.64.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944bc279csm7478601b3a.188.2024.09.18.21.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 21:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726721222; x=1727326022; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=H8Q65y5Ao5sBkRZk9kHAZB4bWbl1BNRmzMwZCNSwh7ZMBMbaH92/bYXa27w7uSVNbv Jmow8uSLPK3B9tUQLscDD5uXizmsIO39xEbNBcAysEqaJD9W1uSB8OprkqN/JWP/T10M Gdd6MMEH0JXirEa7h+HzjVCDN6h6K9KwNTvwQpqEHQb1vKJYoZRhRmyEgCBGGJ1mvecm QzBl8i9MGJu7aMcDtIyRBYvEMX5a7mbVszuc4MmDYOpI3yXOE5ARQBWzttkDbo04+JRS XNUDLppI/VQq8m4UZQz+Jx/j+Ik6UGXUOzJbwkd0kSdrJrXr09k5AvryvhMG4M/r+gGN JMNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726721222; x=1727326022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=De4sKLPybVhT2+Pc9xtI+CTmpF8ivUBlmtwhnsMRIOQ=; b=WehQq/kgfIDCQn31aONq2+Xo2XGxHd06xHnHEaAlE7ab790G3jiorNA0cDue1qIe4j 6Qen4/SWFvexJQbpFHq/3SeO9ZQkAWfKynhgdc5DPn6NgZz9ALnMSllFbdrkk9Qmr8N0 TMr4ZVcovMsHB4/27bgCSjaHIBoZl6OsH/ZsLvx2i4D+8TCX1LmEbuCJ1g7CjinuDCre bEkv7pCdhW6evJSJ5wdEo9XdVYNH0bsgGTtBEXQeIQq3IJykRqbK9wMnyn15phfg8hPu PKCiNWhnjAJIs2fmR8UUSrA/sFfSsjegQAOfmzq2o58xniWoOIL2uhJ5dqHnLW2/JcgL XszA== X-Gm-Message-State: AOJu0YygKwB4vg1K/y4u84youckFanxNAmXzUYQVEjo5q3aIJO3rzmFW zEdguSZX0wWymefHNP6vGMkhOU95woxcnfbsEcqCgFlNGhltg/U9ZOutmWEkJTaPH4lcztym8jU +erhPwg== X-Google-Smtp-Source: AGHT+IE2Y81B/LKedghyO/XIB5KqiZokca4F2Biq0KEcZsGPJCLDi0vE6MjHgWLkzwtVTNzR2l7/8A== X-Received: by 2002:a05:6a21:3a87:b0:1cf:4326:5602 with SMTP id adf61e73a8af0-1d112e8bf15mr31788153637.36.1726721222472; Wed, 18 Sep 2024 21:47:02 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Hyman Huang , Halil Pasic , kvm@vger.kernel.org, Bin Meng , Peter Xu , Liu Zhiwei , David Gibson , Daniel Henrique Barboza , qemu-s390x@nongnu.org, Dmitry Fleytman , Hanna Reitz , Klaus Jensen , Corey Minyard , Laurent Vivier , WANG Xuerui , Thomas Huth , Rob Herring , Eduardo Habkost , Nicholas Piggin , "Michael S. Tsirkin" , Harsh Prateek Bora , "Maciej S. Szmigiero" , Ani Sinha , Stefan Berger , Fam Zheng , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Keith Busch , Jean-Christophe Dubois , qemu-riscv@nongnu.org, Igor Mammedov , Akihiko Odaki , Sriram Yagnaraman , Jason Wang , Eric Farman , "Richard W.M. Jones" , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Nina Schoetterl-Glausch , Aurelien Jarno , Markus Armbruster , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Fabiano Rosas , Marcel Apfelbaum , qemu-arm@nongnu.org, Christian Borntraeger , qemu-ppc@nongnu.org, Zhao Liu , Daniel Henrique Barboza , qemu-block@nongnu.org, Joel Stanley , Weiwei Li , Kevin Wolf , Helge Deller , Yanan Wang , Michael Rolnik , Jesper Devantier , Marcelo Tosatti , Peter Maydell , Pierrick Bouvier Subject: [PATCH v3 08/34] hw/hyperv: replace assert(false) with g_assert_not_reached() Date: Wed, 18 Sep 2024 21:46:15 -0700 Message-Id: <20240919044641.386068-9-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240919044641.386068-1-pierrick.bouvier@linaro.org> References: <20240919044641.386068-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1726721778494116600 Content-Type: text/plain; charset="utf-8" This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Maciej S. Szmigiero Signed-off-by: Pierrick Bouvier --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index 9a56ddf83fe..ef50e490c4e 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -88,7 +88,7 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, return sint_route; } } - assert(false); + g_assert_not_reached(); return NULL; } =20 @@ -187,7 +187,7 @@ static void msg_conn_destroy(HypervTestDev *dev, uint8_= t conn_id) return; } } - assert(false); + g_assert_not_reached(); } =20 static void evt_conn_handler(EventNotifier *notifier) @@ -237,7 +237,7 @@ static void evt_conn_destroy(HypervTestDev *dev, uint8_= t conn_id) return; } } - assert(false); + g_assert_not_reached(); } =20 static uint64_t hv_test_dev_read(void *opaque, hwaddr addr, unsigned size) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 15e0d600c7f..03f415bf226 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1874,7 +1874,7 @@ static void send_create_gpadl(VMBus *vmbus) } } =20 - assert(false); + g_assert_not_reached(); } =20 static bool complete_create_gpadl(VMBus *vmbus) @@ -1889,7 +1889,7 @@ static bool complete_create_gpadl(VMBus *vmbus) } } =20 - assert(false); + g_assert_not_reached(); return false; } =20 @@ -1931,7 +1931,7 @@ static void send_teardown_gpadl(VMBus *vmbus) } } =20 - assert(false); + g_assert_not_reached(); } =20 static bool complete_teardown_gpadl(VMBus *vmbus) @@ -1946,7 +1946,7 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } } =20 - assert(false); + g_assert_not_reached(); return false; } =20 @@ -1996,7 +1996,7 @@ static void send_open_channel(VMBus *vmbus) } } =20 - assert(false); + g_assert_not_reached(); } =20 static bool complete_open_channel(VMBus *vmbus) @@ -2020,7 +2020,7 @@ static bool complete_open_channel(VMBus *vmbus) } } =20 - assert(false); + g_assert_not_reached(); return false; } =20 --=20 2.39.5