From nobody Sun Nov 24 05:51:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1726693675437571.4686887899965; Wed, 18 Sep 2024 14:07:55 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 54C8B14F8; Wed, 18 Sep 2024 17:07:54 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id CCD741526; Wed, 18 Sep 2024 17:07:22 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 3279314DF; Wed, 18 Sep 2024 17:07:18 -0400 (EDT) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 669E114C9 for ; Wed, 18 Sep 2024 17:07:17 -0400 (EDT) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5c3d2f9f896so214133a12.1 for ; Wed, 18 Sep 2024 14:07:17 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb89e07sm5328729a12.76.2024.09.18.14.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 14:07:14 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 536405F8A7; Wed, 18 Sep 2024 22:07:12 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726693636; x=1727298436; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3/HyHbGcSckOdKLF1EYAUB114Xir6Orehr4YuOmz0iw=; b=Pp/oGPHA/i/vNd/qtqcvfLeUgQmSlW4PTVRvU9AZQ5sC0TBzyc1FQwRl2fsm0Yd1Ix sA8vyYXwFyviJTaX6LSnYYxcCT9bSbV276WF1P/opCDdXyfLV1YrByZ5PLX3q7gOlpBL d4agMIdEXWTX9nc655zDX+Jpx/Dcw+yiy95FZlxVgICeVazJXeGnTA9eiSOezLYImgvx jGy+hjQ20hJOxmpQvN7thxoJfsoe7sDO7TZ3LhGzJH3lSM/vWsBkUOstpMLvmKFZ3z9J awclMYOm1KEEJSZpZUUBAsKdbtu6hmoJm0L/5Rd3L2QPOgS5nG9zbvsaplXpW3jRpDoB HjBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726693636; x=1727298436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3/HyHbGcSckOdKLF1EYAUB114Xir6Orehr4YuOmz0iw=; b=GT7X11iuFYK4IhRNfObVYP1stbxKN9JMHvMv2c3SedtOHBfpitc+SYsIr/srlc/uxH AJLUDrF2U9WLbuiirMsBBcjVWDOD64uM7bcttjbQ/YfRmV0SelCU9gaXDp6uQ7VUKqNA iCh/UALcX5vobpRkOCQclcdFtOxKDwlOAG4IDrWNbzyDNtxBhBrA8NN8SR75kGNGgxAU W5oR0nES4C3PksG/hz3RqUy6bh8Dc5ykpWXY2iO5lIMzoYXqtR5IfXOvnDxJAtKfe909 eDLtzx3+sHmu2w5je7YmBlW05yMUukhYEfKMBze/CPnLu/bN7t+00d/hUH1fHQYS51eb GsWg== X-Forwarded-Encrypted: i=1; AJvYcCVJN4Rc1fbNW/PHACrALYy4nuIkoNnHJsw3jNgbeDSJQb21Tw+QNi2GohKuFfnEvVGsKK3hcQ==@lists.libvirt.org X-Gm-Message-State: AOJu0YwDbxaA/SEwJAge2L8MJ6cRsozYjjtQmuqbHPW3wdcOMGZfBPY1 2RdVwQLV0PPBZV3yGCbWh8I3A/2TQHIkpwvcad6BRCF0aOHYJ3f4ehEIc1MWa0c= X-Google-Smtp-Source: AGHT+IHV58QftuvwXXi76HH8XPGKkDy1FaR5lmC5k3xJm23VXa7bFtHvHqFj0VNXwS2rCu/Nz9RQTw== X-Received: by 2002:a05:6402:3551:b0:5c4:1c74:56f2 with SMTP id 4fb4d7f45d1cf-5c41e1904edmr14275902a12.15.1726693635673; Wed, 18 Sep 2024 14:07:15 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PULL 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts Date: Wed, 18 Sep 2024 22:06:55 +0100 Message-Id: <20240918210712.2336854-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240918210712.2336854-1-alex.bennee@linaro.org> References: <20240918210712.2336854-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EE2T5MUW6OPKVD5MJJRRRZ6FC4YPSMVR X-Message-ID-Hash: EE2T5MUW6OPKVD5MJJRRRZ6FC4YPSMVR X-MailFrom: alex.bennee@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , Paolo Bonzini , Thomas Huth , "reviewer:Incompatible changes" X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726693676024116600 Content-Type: text/plain; charset="utf-8" The existing plugins already liberally use host pointer stuffing for passing user data which will fail when doing 64 bit guests on 32 bit hosts. We should discourage this by officially deprecating support and adding another nail to the 32 bit host coffin. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240916085400.1046925-2-alex.bennee@linaro.org> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ed31d4b0b2..809b2b9b81 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -184,6 +184,17 @@ be an effective use of its limited resources, and thus= intends to discontinue it. Since all recent x86 hardware from the past >10 years is capable of the 64-bit x86 extensions, a corresponding 64-bit OS should be used instead. =20 +TCG Plugin support not enabled by default on 32-bit hosts (since 9.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +While it is still possible to enable TCG plugin support for 32-bit +hosts there are a number of potential pitfalls when instrumenting +64-bit guests. The plugin APIs typically pass most addresses as +uint64_t but practices like encoding that address in a host pointer +for passing as user-data will lose data. As most software analysis +benefits from having plenty of host memory it seems reasonable to +encourage users to use 64 bit builds of QEMU for analysis work +whatever targets they are instrumenting. =20 System emulator CPUs -------------------- diff --git a/configure b/configure index f3e7572afb..cc8e1ed5b8 100755 --- a/configure +++ b/configure @@ -516,6 +516,25 @@ case "$cpu" in ;; esac =20 +# Now we have our CPU_CFLAGS we can check if we are targeting a 32 or +# 64 bit host. + +check_64bit_host() { +cat > $TMPC <