From nobody Mon Nov 17 22:46:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1726560594; cv=none; d=zohomail.com; s=zohoarc; b=M5pGVG6Ufc2McnM+Z4moMTg27h2ZytQZfPGXQKvoLa5+v311fcTwB9QSDfdKTCUO7cwNwiTWl5g+5z4eaK0qobRqTCZ/9oVLI1Opyn55ysrU9ggYIcseySOcwx845g4oMffR+d5AvJMWEY9FGL0NCEkIgJnOg3kecrTePqEOqtY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726560594; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=63/NQbx+LSZeSTq0vqtSgR/3tXFurfWMPk4pgzCm/Bw=; b=J8OIkuNLFwBVa1GEPZTvJSH7aGAhnywZmCZvlMXlY3Dlg7FOdVwMfrq9TZ6JTRnXOahHk/kcQnVkdqUmIPlh5jTAKxFB1I0d4qEnjLA9E7EP/GEARYW+Jb9ZsMP2yN93n8OUBgbbZh1HGAfz/Lnj4DKhA4bYv2BUCHIAm0zcki0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1726560594097613.1534123142945; Tue, 17 Sep 2024 01:09:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqTGe-0002QO-7J; Tue, 17 Sep 2024 04:09:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqTGT-0002JT-A1; Tue, 17 Sep 2024 04:08:50 -0400 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqTGP-0002ap-BX; Tue, 17 Sep 2024 04:08:48 -0400 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1726560517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=63/NQbx+LSZeSTq0vqtSgR/3tXFurfWMPk4pgzCm/Bw=; b=IQ+dBY/Wz3uSFeOiGgDOW6r17uQTjBCQERBlgeyoqzh3ZZSkOAGM1rpf2tovnKa6lVmoWu KPB+TSWIy6zI1TWf0QA9Mpm/0TLv/sK/u6wkoZXNKmaKRja6lz1lzylVsybsg9yu5U15Qz kIuwIipDOjH/LgJjRM602YLASrJuVng= To: stefanha@redhat.com Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, qemu-block@nongnu.org, Dmitry Frolov Subject: [PATCH] hw/block: fix uint32 overflow Date: Tue, 17 Sep 2024 11:03:18 +0300 Message-ID: <20240917080356.270576-2-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1726560599301116600 Content-Type: text/plain; charset="utf-8" The product bs->bl.zone_size * (bs->bl.nr_zones - 1) may overflow uint32. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 73bdfd6122..115795392c 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -700,7 +700,7 @@ static int virtio_blk_handle_zone_mgmt(VirtIOBlockReq *= req, BlockZoneOp op) } else { if (bs->bl.zone_size > capacity - offset) { /* The zoned device allows the last smaller zone. */ - len =3D capacity - bs->bl.zone_size * (bs->bl.nr_zones - 1); + len =3D capacity - bs->bl.zone_size * (bs->bl.nr_zones - 1ull); } else { len =3D bs->bl.zone_size; } --=20 2.43.0