From nobody Sun Nov 24 05:35:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 172647698571021.727817521471366; Mon, 16 Sep 2024 01:56:25 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 693431A50; Mon, 16 Sep 2024 04:56:24 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 7414D1A54; Mon, 16 Sep 2024 04:54:13 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 9FB51A18; Mon, 16 Sep 2024 04:54:05 -0400 (EDT) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id ED5FB1387 for ; Mon, 16 Sep 2024 04:54:04 -0400 (EDT) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-374ca65cafdso1959639f8f.2 for ; Mon, 16 Sep 2024 01:54:04 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e73e7feesm6566584f8f.29.2024.09.16.01.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 01:54:01 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 747B85F8F6; Mon, 16 Sep 2024 09:54:00 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726476844; x=1727081644; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tM22JfJ8MqQx0zkIxo3mmiSupSHk/2QTpOs0HmJJEsE=; b=CUHtBACXvvHQu+EewHhp5/j/45cD96Ht9a4JBceA0bptMn46FyBy7fP9duc+h3c/W6 r84hChxFF0lY3/Or+mipDav5okulEKoUKfeqZyYUKbjdYn/xxVV4t1s3DLWLqhgfR1Y4 0sKcP5dm/Ywu4E3FFtO/9cPhhbXChhF5UDk4zaZu37QbvMaNXm/dg+meZhO+sxzIjHi7 CN7RfOY8VqPIHYmQpQyo4fD523e8crEVQDGCzkRwCwbk0fGl5IbHoMbxOYubr8vsm0dp q7VII3EivCbmLXFVS5Tsc9dGUTHAdUUviZ+fAUr4nP7mc3yIembj2XGO5QEG0GROzhaC 18Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726476844; x=1727081644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tM22JfJ8MqQx0zkIxo3mmiSupSHk/2QTpOs0HmJJEsE=; b=hr1tB8PJ/0QlqQz122irr9y6FfIKkEt+aieHEG6nFqvLAWNXZZT2VxqdCutmhMd0UP CN2/P0VnXf9XAoO+QTVb0yS3rRqWUVuh55jijlXNFBMSOYB3oQhWCD0gOKUZm9JXBL4h cibJqD6kXBIcZutaDIulb6hnNzqaCbm7I8Ps1YX21/txM+3JCEHNHLxlo7IcSST2cFDv x8WlJWxVsjrw8TpNVxTB4z8uGL9dKn7UZJV4h2+Kh2tmYi2Cr0lyga0CGfbthxc7lPWf n5JXtalkoClsjyWFCxNW+EoiraQBsKBPIRvXrjjFCJ5kBI123hsNr0+RzeAFloRVMjRl 1iRQ== X-Forwarded-Encrypted: i=1; AJvYcCVW/I46g+9mlSt23jmt0bhxI7bQawJUql8eGphdGKzcJpphFVJn8MzkBAlACcknUlqck6C1FQ==@lists.libvirt.org X-Gm-Message-State: AOJu0Yxcvbqili3fvirkOzE1hUKCxKpvSvk+bIyCGjOCBeDnfNjV0TUc TvA3uaHwLzxDI+v9Rzz4yfxlsb2JJuIAx7qSYt6b+PSBUfuMqJCX5YyX5f17Riw= X-Google-Smtp-Source: AGHT+IFLXJ+7V/1aaQoFam8TjRU/0MUzurvEQwqqJnRBJNRuxRXtksWyXaMEyQsLXdONHgHk3eQ2wg== X-Received: by 2002:a5d:6da6:0:b0:374:cd96:f73 with SMTP id ffacd0b85a97d-378d61d51bcmr7590148f8f.3.1726476843593; Mon, 16 Sep 2024 01:54:03 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 02/18] deprecation: don't enable TCG plugins by default with TCI Date: Mon, 16 Sep 2024 09:53:44 +0100 Message-Id: <20240916085400.1046925-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20240916085400.1046925-1-alex.bennee@linaro.org> References: <20240916085400.1046925-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: CNFM34QPXGBQ2LMYVJKHAHJ3QELXEHLM X-Message-ID-Hash: CNFM34QPXGBQ2LMYVJKHAHJ3QELXEHLM X-MailFrom: alex.bennee@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: qemu-s390x@nongnu.org, Thomas Huth , Richard Henderson , qemu-ppc@nongnu.org, Ilya Leoshkevich , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Alexandre Iooss , Eduardo Habkost , Daniel Henrique Barboza , Yanan Wang , Nicholas Piggin , David Hildenbrand , devel@lists.libvirt.org, Mahmoud Mandour , Zhao Liu , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726476987057116600 Content-Type: text/plain; charset="utf-8" The softmmu memory instrumentation test sees so many more accesses than a normal translated host and its really not worth fixing up. Lets deprecate this odd configuration and save on the CI cycles. Message-Id: <20240910140733.4007719-13-alex.bennee@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Benn=C3=A9e --- docs/about/deprecated.rst | 8 ++++++++ configure | 11 +++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index f7c7c33d39..5aa2e35314 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -196,6 +196,14 @@ benefits from having plenty of host memory it seems re= asonable to encourage users to use 64 bit builds of QEMU for analysis work whatever targets they are instrumenting. =20 +TCG Plugin support not enabled by default with TCI (since 9.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +While the TCG interpreter can interpret the TCG ops used by plugins it +is going to be so much slower it wouldn't make sense for any serious +instrumentation. Due to implementation differences there will also be +anomalies in things like memory instrumentation. + System emulator CPUs -------------------- =20 diff --git a/configure b/configure index f376fa24b3..3778b61c40 100755 --- a/configure +++ b/configure @@ -629,6 +629,9 @@ meson_option_parse() { exit 1 fi } +has_meson_option() { + test "${meson_options#*"$1"}" !=3D "$meson_options" +} =20 meson_add_machine_file() { if test "$cross_compile" =3D "yes"; then @@ -1048,8 +1051,12 @@ if test "$static" =3D "yes" ; then plugins=3D"no" fi if test "$plugins" !=3D "no" && test $host_bits -eq 64; then - plugins=3Dyes - subdirs=3D"$subdirs contrib/plugins" + if has_meson_option "-Dtcg_interpreter=3Dtrue"; then + plugins=3D"no" + else + plugins=3Dyes + subdirs=3D"$subdirs contrib/plugins" + fi fi =20 cat > $TMPC << EOF --=20 2.39.5